New issue
Advanced search Search tips

Issue 647756 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Clean out LEGACY flags from SkUserConfig.h

Project Member Reported by reed@google.com, Sep 16 2016

Issue description

As Skia evolves/refines, it sometimes needs to deprecate or change public APIs. This can require refactoring changes in Chrome/blink. To stage these changes, skia/config/SkUserConfig.h is used to define legacy flags during the transition period. These flags should eventually be removed. This is a tracking bug for that effort.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Sep 17 2016

Labels: Hotlist-Google
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff7e85cb9b649940e25ef66cbf84910867551f75

commit ff7e85cb9b649940e25ef66cbf84910867551f75
Author: reed <reed@google.com>
Date: Mon Sep 19 13:40:06 2016

Subclasses of SkDevice that overrode onAccessBitmap can remove that code -- it is not being called.

One caller on platform_skia was calling it (incidentally), but they can call accessPixels() instead for the same result.

BUG=647756

Review-Url: https://codereview.chromium.org/2340813006
Cr-Commit-Position: refs/heads/master@{#419446}

[modify] https://crrev.com/ff7e85cb9b649940e25ef66cbf84910867551f75/skia/config/SkUserConfig.h
[modify] https://crrev.com/ff7e85cb9b649940e25ef66cbf84910867551f75/skia/ext/bitmap_platform_device_skia.cc
[modify] https://crrev.com/ff7e85cb9b649940e25ef66cbf84910867551f75/skia/ext/bitmap_platform_device_win.cc
[modify] https://crrev.com/ff7e85cb9b649940e25ef66cbf84910867551f75/skia/ext/bitmap_platform_device_win.h
[modify] https://crrev.com/ff7e85cb9b649940e25ef66cbf84910867551f75/skia/ext/platform_canvas_unittest.cc

Components: Internals>Skia
Status: Assigned (was: Untriaged)
Owner: reed@chromium.org
Owner: reed@google.com

Sign in to add a comment