We are running experiment on 10% of the user for M53, and will expand to 100% user for M54 we can now unitify the download code path with that of desktop's
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aea2c7d5fcc45b9c606f7595c4c12f652ce03abd commit aea2c7d5fcc45b9c606f7595c4c12f652ce03abd Author: qinmin <qinmin@chromium.org> Date: Wed Sep 21 22:19:25 2016 Defaulting all downloads to go through Chrome network stack In M53, we started a experiment on disabling system DownloadManager. And In M54, we expect the experiment to be expanded to 100% of the user. This change removes this field trial flag to default all download through Chrome. This allows us to unify the download code path between android and desktop. Android DownloadManager will still be used by OMA downloads. And will clean up all the code that calls into ChromeDownloadDelegate::EnqueueDownloadManagerRequest() in a separate CL. BUG=647755 Review-Url: https://codereview.chromium.org/2341643008 Cr-Commit-Position: refs/heads/master@{#420179} [modify] https://crrev.com/aea2c7d5fcc45b9c606f7595c4c12f652ce03abd/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java [modify] https://crrev.com/aea2c7d5fcc45b9c606f7595c4c12f652ce03abd/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java [modify] https://crrev.com/aea2c7d5fcc45b9c606f7595c4c12f652ce03abd/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java [modify] https://crrev.com/aea2c7d5fcc45b9c606f7595c4c12f652ce03abd/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadTest.java [modify] https://crrev.com/aea2c7d5fcc45b9c606f7595c4c12f652ce03abd/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadTestBase.java [modify] https://crrev.com/aea2c7d5fcc45b9c606f7595c4c12f652ce03abd/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImplTest.java [modify] https://crrev.com/aea2c7d5fcc45b9c606f7595c4c12f652ce03abd/chrome/app/generated_resources.grd [modify] https://crrev.com/aea2c7d5fcc45b9c606f7595c4c12f652ce03abd/chrome/browser/BUILD.gn [modify] https://crrev.com/aea2c7d5fcc45b9c606f7595c4c12f652ce03abd/chrome/browser/about_flags.cc [modify] https://crrev.com/aea2c7d5fcc45b9c606f7595c4c12f652ce03abd/chrome/browser/android/chrome_feature_list.cc [modify] https://crrev.com/aea2c7d5fcc45b9c606f7595c4c12f652ce03abd/chrome/browser/android/chrome_feature_list.h [delete] https://crrev.com/824ee601b46b707b4bc121d2ceef67202b3f2bc0/chrome/browser/android/intercept_download_resource_throttle.cc [delete] https://crrev.com/824ee601b46b707b4bc121d2ceef67202b3f2bc0/chrome/browser/android/intercept_download_resource_throttle.h [modify] https://crrev.com/aea2c7d5fcc45b9c606f7595c4c12f652ce03abd/chrome/browser/download/download_ui_controller.cc [modify] https://crrev.com/aea2c7d5fcc45b9c606f7595c4c12f652ce03abd/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc [modify] https://crrev.com/aea2c7d5fcc45b9c606f7595c4c12f652ce03abd/chrome/test/data/android/download/dangerous.html [rename] https://crrev.com/aea2c7d5fcc45b9c606f7595c4c12f652ce03abd/chrome/test/data/android/download/test.swf [modify] https://crrev.com/aea2c7d5fcc45b9c606f7595c4c12f652ce03abd/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5fc08cfb098acce49344d2e89cc27c915903f81c commit 5fc08cfb098acce49344d2e89cc27c915903f81c Author: qinmin <qinmin@chromium.org> Date: Tue Sep 27 20:59:00 2016 Clean up Android DownloadManager code as most download now go through Chrome Network stack The only exception is OMA DRM download. And it only applies to context menu download interception. Clean up the remaining unused code now. BUG=647755 Review-Url: https://codereview.chromium.org/2371773003 Cr-Commit-Position: refs/heads/master@{#421332} [modify] https://crrev.com/5fc08cfb098acce49344d2e89cc27c915903f81c/chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java [modify] https://crrev.com/5fc08cfb098acce49344d2e89cc27c915903f81c/chrome/browser/android/download/chrome_download_delegate.cc [modify] https://crrev.com/5fc08cfb098acce49344d2e89cc27c915903f81c/chrome/browser/android/download/chrome_download_delegate.h [modify] https://crrev.com/5fc08cfb098acce49344d2e89cc27c915903f81c/chrome/browser/android/download/download_controller.cc [modify] https://crrev.com/5fc08cfb098acce49344d2e89cc27c915903f81c/chrome/browser/android/download/download_controller.h [modify] https://crrev.com/5fc08cfb098acce49344d2e89cc27c915903f81c/chrome/browser/android/download/download_controller_base.h [modify] https://crrev.com/5fc08cfb098acce49344d2e89cc27c915903f81c/chrome/browser/android/download/mock_download_controller.cc [modify] https://crrev.com/5fc08cfb098acce49344d2e89cc27c915903f81c/chrome/browser/android/download/mock_download_controller.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2ef8d9323057b8858ce2a17423c393663a803ef1 commit 2ef8d9323057b8858ce2a17423c393663a803ef1 Author: qinmin <qinmin@chromium.org> Date: Wed Sep 28 18:34:24 2016 remove DownloadController::SetDefaultDownloadFileName() All download now goes through Chrome's network stack. Default file name will be determined in download_target_determiner.cc. As a result, this function is no longer being called. BUG=647755 Review-Url: https://codereview.chromium.org/2374853002 Cr-Commit-Position: refs/heads/master@{#421586} [modify] https://crrev.com/2ef8d9323057b8858ce2a17423c393663a803ef1/chrome/browser/android/download/download_controller.cc [modify] https://crrev.com/2ef8d9323057b8858ce2a17423c393663a803ef1/chrome/browser/android/download/download_controller.h [modify] https://crrev.com/2ef8d9323057b8858ce2a17423c393663a803ef1/chrome/browser/android/download/download_controller_base.h [modify] https://crrev.com/2ef8d9323057b8858ce2a17423c393663a803ef1/chrome/browser/android/download/download_manager_service.cc
Fixed?
Comment 1 by bugdroid1@chromium.org
, Sep 21 2016