Issue 647752 link

Starred by 1 user

Issue metadata

Status:	Archived
Owner:	----
Closed:	Dec 2017
Cc:	seanmccullough@chromium.org martiniss@chromium.org zhangtiff@chromium.org
Components:	Infra>Sheriffing>SheriffOMatic
EstimatedDays:	----
NextAction:	----
OS:	Linux
Pri:	2
Type:	Bug-Regression
Milestone-Reliability

Alerts dispatcher should generate information about v8 and nacl regression ranges

Project Member Reported by martiniss@chromium.org, Sep 16 2016

Issue description

builder_alerts used to do this, using the got_v8_revision_cp and got_nacl_revision_cp properties of builds. 

The DEPS rolls are still included, as chromium commits, so sheriffs will see that v8 changed, it will just not be presented as a separate item.

Project Member

Comment 1 by bugdroid1@chromium.org, Sep 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/83b28f10ad793e6837f91beeffd3d89d141e84e9

commit 83b28f10ad793e6837f91beeffd3d89d141e84e9
Author: Stephen Martinis <martiniss@chromium.org>
Date: Mon Sep 19 23:02:58 2016

AD: Use first failed build for regression ranges.

This also removes checking for v8 and nacl revisions using the build
properties. This should be re-implemented eventually, but was deemed
low priority for launch.

Also cleans up tests a bit.

BUG= 647752 

Change-Id: Ieef039e61f66d42fcecd618a4514a1b7e613050c
Reviewed-on: https://chromium-review.googlesource.com/386329
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Sean McCullough <seanmccullough@chromium.org>

[modify] https://crrev.com/83b28f10ad793e6837f91beeffd3d89d141e84e9/go/src/infra/monitoring/analyzer/analyzer.go
[modify] https://crrev.com/83b28f10ad793e6837f91beeffd3d89d141e84e9/go/src/infra/monitoring/analyzer/analyzer_test.go
[add] https://crrev.com/83b28f10ad793e6837f91beeffd3d89d141e84e9/go/src/infra/monitoring/analyzer/regrange/regrange.go
[add] https://crrev.com/83b28f10ad793e6837f91beeffd3d89d141e84e9/go/src/infra/monitoring/analyzer/regrange/regrange.infra_testing
[add] https://crrev.com/83b28f10ad793e6837f91beeffd3d89d141e84e9/go/src/infra/monitoring/analyzer/regrange/regrange_test.go
[modify] https://crrev.com/83b28f10ad793e6837f91beeffd3d89d141e84e9/go/src/infra/monitoring/analyzer/test/test_helpers.go
[modify] https://crrev.com/83b28f10ad793e6837f91beeffd3d89d141e84e9/go/src/infra/monitoring/analyzer/test/test_helpers_test.go
[modify] https://crrev.com/83b28f10ad793e6837f91beeffd3d89d141e84e9/go/src/infra/monitoring/messages/alerts.go
[modify] https://crrev.com/83b28f10ad793e6837f91beeffd3d89d141e84e9/go/src/infra/monitoring/messages/buildextract.go