New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 647725 link

Starred by 3 users
Status: Fixed
Owner:
█ hubbe@chromium.org
Last visit > 30 days ago
Closed: Dec 1
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Make sure all hardware video decoders tag their video frames with colorspace information.

Project Member Reported by hubbe@chromium.org, Sep 16 2016 
There are lots of hardware decoders, so I might break this up into several bugs later. The ones I know of are:

Windows-H264
Windows-VP9
Mac-H264
Android-H264
Android-VPx
Linux-H264
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b213e899246050d799ccb6df0e40837b619da8fb

commit b213e899246050d799ccb6df0e40837b619da8fb
Author: hubbe <hubbe@chromium.org>
Date: Tue Oct 04 21:39:59 2016

Attach color space information to hardware decoded NV12 video frames.

This extracts the color information from the h264 stream and attaches
it to the video frame. Currently this is only done if the result is
NV12 as we don't have the code yet to do it for RGB frames.

BUG= 622133 ,  647725 

Review-Url: https://codereview.chromium.org/2345123002
Cr-Commit-Position: refs/heads/master@{#422942}

[modify] https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb/content/renderer/pepper/video_decoder_shim.cc
[modify] https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb/media/filters/gpu_video_decoder.cc
[modify] https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb/media/filters/h264_parser.cc
[modify] https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb/media/filters/h264_parser.h
[modify] https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb/media/gpu/android_video_decode_accelerator.cc
[modify] https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb/media/gpu/dxva_picture_buffer_win.h
[modify] https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb/media/gpu/dxva_video_decode_accelerator_win.cc
[modify] https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb/media/gpu/dxva_video_decode_accelerator_win.h
[modify] https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb/media/gpu/fake_video_decode_accelerator.cc
[modify] https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb/media/gpu/ipc/client/BUILD.gn
[modify] https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb/media/gpu/ipc/client/gpu_video_decode_accelerator_host.cc
[modify] https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb/media/gpu/ipc/client/gpu_video_decode_accelerator_host.h
[modify] https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb/media/gpu/ipc/common/BUILD.gn
[modify] https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb/media/gpu/ipc/common/media_messages.h
[modify] https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb/media/gpu/ipc/service/BUILD.gn
[modify] https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb/media/gpu/ipc/service/gpu_video_decode_accelerator.cc
[modify] https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb/media/gpu/v4l2_slice_video_decode_accelerator.cc
[modify] https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb/media/gpu/v4l2_video_decode_accelerator.cc
[modify] https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb/media/gpu/vaapi_video_decode_accelerator.cc
[modify] https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb/media/gpu/vt_video_decode_accelerator_mac.cc
[modify] https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb/media/video/picture.cc
[modify] https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb/media/video/picture.h
[modify] https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb/ui/gfx/ipc/color/gfx_param_traits_macros.h
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5d6ad8849efdb60d7d42d540997b36a144b8797

commit c5d6ad8849efdb60d7d42d540997b36a144b8797
Author: hubbe <hubbe@chromium.org>
Date: Thu Oct 06 18:47:33 2016

Revert of Attach color space information to hardware decoded NV12 video frames. (patchset #11 id:200001 of https://codereview.chromium.org/2345123002/ )

Reason for revert:
https://bugs.chromium.org/p/chromium/issues/detail?id=653388

Original issue's description:
> Attach color space information to hardware decoded NV12 video frames.
>
> This extracts the color information from the h264 stream and attaches
> it to the video frame. Currently this is only done if the result is
> NV12 as we don't have the code yet to do it for RGB frames.
>
> BUG= 622133 ,  647725 
>
> Committed: https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb
> Cr-Commit-Position: refs/heads/master@{#422942}

TBR=sandersd@chromium.org,posciak@chromium.org,jbauman@chromium.org,bbudge@chromium.org,tsepez@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 622133 ,  647725 

Review-Url: https://codereview.chromium.org/2399133002
Cr-Commit-Position: refs/heads/master@{#423605}

[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/content/renderer/pepper/video_decoder_shim.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/filters/gpu_video_decoder.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/filters/h264_parser.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/filters/h264_parser.h
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/android_video_decode_accelerator.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/dxva_picture_buffer_win.h
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/dxva_video_decode_accelerator_win.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/dxva_video_decode_accelerator_win.h
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/fake_video_decode_accelerator.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/ipc/client/BUILD.gn
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/ipc/client/gpu_video_decode_accelerator_host.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/ipc/client/gpu_video_decode_accelerator_host.h
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/ipc/common/BUILD.gn
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/ipc/common/media_messages.h
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/ipc/service/BUILD.gn
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/ipc/service/gpu_video_decode_accelerator.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/v4l2_slice_video_decode_accelerator.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/v4l2_video_decode_accelerator.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/vaapi_video_decode_accelerator.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/vt_video_decode_accelerator_mac.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/video/picture.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/video/picture.h
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/ui/gfx/ipc/color/gfx_param_traits_macros.h
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 6 2016

Labels: merge-merged-2882
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a65782c053825f9f287b1c5d09fc9804aa8af451

commit a65782c053825f9f287b1c5d09fc9804aa8af451
Author: Fredrik Hubinette <hubbe@google.com>
Date: Thu Oct 06 18:59:06 2016

Revert of Attach color space information to hardware decoded NV12 video frames. (patchset #11 id:200001 of https://codereview.chromium.org/2345123002/ )

Reason for revert:
https://bugs.chromium.org/p/chromium/issues/detail?id=653388

Original issue's description:
> Attach color space information to hardware decoded NV12 video frames.
>
> This extracts the color information from the h264 stream and attaches
> it to the video frame. Currently this is only done if the result is
> NV12 as we don't have the code yet to do it for RGB frames.
>
> BUG= 622133 ,  647725 
>
> Committed: https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb
> Cr-Commit-Position: refs/heads/master@{#422942}

TBR=sandersd@chromium.org,posciak@chromium.org,jbauman@chromium.org,bbudge@chromium.org,tsepez@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 622133 ,  647725 

Review-Url: https://codereview.chromium.org/2399133002
Cr-Commit-Position: refs/heads/master@{#423605}
(cherry picked from commit c5d6ad8849efdb60d7d42d540997b36a144b8797)

Review URL: https://codereview.chromium.org/2392343007 .

Cr-Commit-Position: refs/branch-heads/2882@{#5}
Cr-Branched-From: 03e86d027151639ad79c2074199f4e75beab0674-refs/heads/master@{#423378}

[modify] https://crrev.com/a65782c053825f9f287b1c5d09fc9804aa8af451/content/renderer/pepper/video_decoder_shim.cc
[modify] https://crrev.com/a65782c053825f9f287b1c5d09fc9804aa8af451/media/filters/gpu_video_decoder.cc
[modify] https://crrev.com/a65782c053825f9f287b1c5d09fc9804aa8af451/media/filters/h264_parser.cc
[modify] https://crrev.com/a65782c053825f9f287b1c5d09fc9804aa8af451/media/filters/h264_parser.h
[modify] https://crrev.com/a65782c053825f9f287b1c5d09fc9804aa8af451/media/gpu/android_video_decode_accelerator.cc
[modify] https://crrev.com/a65782c053825f9f287b1c5d09fc9804aa8af451/media/gpu/dxva_picture_buffer_win.h
[modify] https://crrev.com/a65782c053825f9f287b1c5d09fc9804aa8af451/media/gpu/dxva_video_decode_accelerator_win.cc
[modify] https://crrev.com/a65782c053825f9f287b1c5d09fc9804aa8af451/media/gpu/dxva_video_decode_accelerator_win.h
[modify] https://crrev.com/a65782c053825f9f287b1c5d09fc9804aa8af451/media/gpu/fake_video_decode_accelerator.cc
[modify] https://crrev.com/a65782c053825f9f287b1c5d09fc9804aa8af451/media/gpu/ipc/client/BUILD.gn
[modify] https://crrev.com/a65782c053825f9f287b1c5d09fc9804aa8af451/media/gpu/ipc/client/gpu_video_decode_accelerator_host.cc
[modify] https://crrev.com/a65782c053825f9f287b1c5d09fc9804aa8af451/media/gpu/ipc/client/gpu_video_decode_accelerator_host.h
[modify] https://crrev.com/a65782c053825f9f287b1c5d09fc9804aa8af451/media/gpu/ipc/common/BUILD.gn
[modify] https://crrev.com/a65782c053825f9f287b1c5d09fc9804aa8af451/media/gpu/ipc/common/media_messages.h
[modify] https://crrev.com/a65782c053825f9f287b1c5d09fc9804aa8af451/media/gpu/ipc/service/BUILD.gn
[modify] https://crrev.com/a65782c053825f9f287b1c5d09fc9804aa8af451/media/gpu/ipc/service/gpu_video_decode_accelerator.cc
[modify] https://crrev.com/a65782c053825f9f287b1c5d09fc9804aa8af451/media/gpu/v4l2_slice_video_decode_accelerator.cc
[modify] https://crrev.com/a65782c053825f9f287b1c5d09fc9804aa8af451/media/gpu/v4l2_video_decode_accelerator.cc
[modify] https://crrev.com/a65782c053825f9f287b1c5d09fc9804aa8af451/media/gpu/vaapi_video_decode_accelerator.cc
[modify] https://crrev.com/a65782c053825f9f287b1c5d09fc9804aa8af451/media/gpu/vt_video_decode_accelerator_mac.cc
[modify] https://crrev.com/a65782c053825f9f287b1c5d09fc9804aa8af451/media/video/picture.cc
[modify] https://crrev.com/a65782c053825f9f287b1c5d09fc9804aa8af451/media/video/picture.h
[modify] https://crrev.com/a65782c053825f9f287b1c5d09fc9804aa8af451/ui/gfx/ipc/color/gfx_param_traits_macros.h
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f33dc1134c8c48a11280e8f62c96d749c4caf4a0

commit f33dc1134c8c48a11280e8f62c96d749c4caf4a0
Author: hubbe <hubbe@chromium.org>
Date: Fri Oct 07 01:40:03 2016

Attach color space information to hardware decoded NV12 video frames.

This extracts the color information from the h264 stream and attaches
it to the video frame. Currently this is only done if the result is
NV12 as we don't have the code yet to do it for RGB frames.

BUG= 622133 ,  647725 

Committed: https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb
Review-Url: https://codereview.chromium.org/2345123002
Cr-Original-Commit-Position: refs/heads/master@{#422942}
Cr-Commit-Position: refs/heads/master@{#423776}

[modify] https://crrev.com/f33dc1134c8c48a11280e8f62c96d749c4caf4a0/content/renderer/pepper/video_decoder_shim.cc
[modify] https://crrev.com/f33dc1134c8c48a11280e8f62c96d749c4caf4a0/media/filters/gpu_video_decoder.cc
[modify] https://crrev.com/f33dc1134c8c48a11280e8f62c96d749c4caf4a0/media/filters/h264_parser.cc
[modify] https://crrev.com/f33dc1134c8c48a11280e8f62c96d749c4caf4a0/media/filters/h264_parser.h
[modify] https://crrev.com/f33dc1134c8c48a11280e8f62c96d749c4caf4a0/media/gpu/android_video_decode_accelerator.cc
[modify] https://crrev.com/f33dc1134c8c48a11280e8f62c96d749c4caf4a0/media/gpu/dxva_picture_buffer_win.h
[modify] https://crrev.com/f33dc1134c8c48a11280e8f62c96d749c4caf4a0/media/gpu/dxva_video_decode_accelerator_win.cc
[modify] https://crrev.com/f33dc1134c8c48a11280e8f62c96d749c4caf4a0/media/gpu/dxva_video_decode_accelerator_win.h
[modify] https://crrev.com/f33dc1134c8c48a11280e8f62c96d749c4caf4a0/media/gpu/fake_video_decode_accelerator.cc
[modify] https://crrev.com/f33dc1134c8c48a11280e8f62c96d749c4caf4a0/media/gpu/ipc/client/BUILD.gn
[modify] https://crrev.com/f33dc1134c8c48a11280e8f62c96d749c4caf4a0/media/gpu/ipc/client/gpu_video_decode_accelerator_host.cc
[modify] https://crrev.com/f33dc1134c8c48a11280e8f62c96d749c4caf4a0/media/gpu/ipc/client/gpu_video_decode_accelerator_host.h
[modify] https://crrev.com/f33dc1134c8c48a11280e8f62c96d749c4caf4a0/media/gpu/ipc/common/BUILD.gn
[modify] https://crrev.com/f33dc1134c8c48a11280e8f62c96d749c4caf4a0/media/gpu/ipc/common/media_messages.h
[modify] https://crrev.com/f33dc1134c8c48a11280e8f62c96d749c4caf4a0/media/gpu/ipc/service/BUILD.gn
[modify] https://crrev.com/f33dc1134c8c48a11280e8f62c96d749c4caf4a0/media/gpu/ipc/service/gpu_video_decode_accelerator.cc
[modify] https://crrev.com/f33dc1134c8c48a11280e8f62c96d749c4caf4a0/media/gpu/v4l2_slice_video_decode_accelerator.cc
[modify] https://crrev.com/f33dc1134c8c48a11280e8f62c96d749c4caf4a0/media/gpu/v4l2_video_decode_accelerator.cc
[modify] https://crrev.com/f33dc1134c8c48a11280e8f62c96d749c4caf4a0/media/gpu/vaapi_video_decode_accelerator.cc
[modify] https://crrev.com/f33dc1134c8c48a11280e8f62c96d749c4caf4a0/media/gpu/vt_video_decode_accelerator_mac.cc
[modify] https://crrev.com/f33dc1134c8c48a11280e8f62c96d749c4caf4a0/media/video/picture.cc
[modify] https://crrev.com/f33dc1134c8c48a11280e8f62c96d749c4caf4a0/media/video/picture.h
[modify] https://crrev.com/f33dc1134c8c48a11280e8f62c96d749c4caf4a0/ui/gfx/ipc/color/gfx_param_traits_macros.h
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5d6ad8849efdb60d7d42d540997b36a144b8797

commit c5d6ad8849efdb60d7d42d540997b36a144b8797
Author: hubbe <hubbe@chromium.org>
Date: Thu Oct 06 18:47:33 2016

Revert of Attach color space information to hardware decoded NV12 video frames. (patchset #11 id:200001 of https://codereview.chromium.org/2345123002/ )

Reason for revert:
https://bugs.chromium.org/p/chromium/issues/detail?id=653388

Original issue's description:
> Attach color space information to hardware decoded NV12 video frames.
>
> This extracts the color information from the h264 stream and attaches
> it to the video frame. Currently this is only done if the result is
> NV12 as we don't have the code yet to do it for RGB frames.
>
> BUG= 622133 ,  647725 
>
> Committed: https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb
> Cr-Commit-Position: refs/heads/master@{#422942}

TBR=sandersd@chromium.org,posciak@chromium.org,jbauman@chromium.org,bbudge@chromium.org,tsepez@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 622133 ,  647725 

Review-Url: https://codereview.chromium.org/2399133002
Cr-Commit-Position: refs/heads/master@{#423605}

[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/content/renderer/pepper/video_decoder_shim.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/filters/gpu_video_decoder.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/filters/h264_parser.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/filters/h264_parser.h
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/android_video_decode_accelerator.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/dxva_picture_buffer_win.h
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/dxva_video_decode_accelerator_win.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/dxva_video_decode_accelerator_win.h
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/fake_video_decode_accelerator.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/ipc/client/BUILD.gn
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/ipc/client/gpu_video_decode_accelerator_host.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/ipc/client/gpu_video_decode_accelerator_host.h
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/ipc/common/BUILD.gn
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/ipc/common/media_messages.h
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/ipc/service/BUILD.gn
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/ipc/service/gpu_video_decode_accelerator.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/v4l2_slice_video_decode_accelerator.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/v4l2_video_decode_accelerator.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/vaapi_video_decode_accelerator.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/gpu/vt_video_decode_accelerator_mac.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/video/picture.cc
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/media/video/picture.h
[modify] https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797/ui/gfx/ipc/color/gfx_param_traits_macros.h

Comment 6 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba7b76c799d7ed719aba76ced546935ddf3da9fd

commit ba7b76c799d7ed719aba76ced546935ddf3da9fd
Author: hubbe <hubbe@chromium.org>
Date: Wed Mar 22 06:51:03 2017

Read color space from container.

This lets webm files with color tags actually convey that information to the decoder.
This already worked for MSE, but did not work for src= because it uses a different demuxer.

BUG= 647725 

Review-Url: https://codereview.chromium.org/2764173002
Cr-Commit-Position: refs/heads/master@{#458649}

[modify] https://crrev.com/ba7b76c799d7ed719aba76ced546935ddf3da9fd/media/ffmpeg/ffmpeg_common.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d83ff4273b91a70b23ec36c968c245a6739056e

commit 3d83ff4273b91a70b23ec36c968c245a6739056e
Author: Christopher Cameron <ccameron@chromium.org>
Date: Sun Aug 20 12:24:44 2017

Extract color space from CVImageBufferRef

The parameters for the color space can be extracted from the
CVImageBufferRef produced by the hardware decoder.

Of note is that if this is composited using the GLRenderer then it
is sent through a bogus conversion in YUVToRGBConverter. That part
also needs to be fixed.

Bug:  647725 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Iee6fa43ef359e2936582bfeb083abbc418134f04
Reviewed-on: https://chromium-review.googlesource.com/618326
Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Commit-Queue: ccameron chromium <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495841}
[modify] https://crrev.com/3d83ff4273b91a70b23ec36c968c245a6739056e/media/gpu/vt_video_decode_accelerator_mac.cc
[modify] https://crrev.com/3d83ff4273b91a70b23ec36c968c245a6739056e/ui/gfx/color_space.cc
[modify] https://crrev.com/3d83ff4273b91a70b23ec36c968c245a6739056e/ui/gfx/color_space.h
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/161ca16a30d167dc143ba177046ac67733c88a51

commit 161ca16a30d167dc143ba177046ac67733c88a51
Author: Fredrik Hubinette <hubbe@google.com>
Date: Fri Aug 03 18:30:01 2018

add test for full-range video color space

Bug:  647725 
Change-Id: I8c5ca15c75e2a0114a39f6eed64fec5fbd863b7c
Reviewed-on: https://chromium-review.googlesource.com/1161321
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580606}
[modify] https://crrev.com/161ca16a30d167dc143ba177046ac67733c88a51/media/test/pipeline_integration_test.cc
[modify] https://crrev.com/161ca16a30d167dc143ba177046ac67733c88a51/media/test/pipeline_integration_test_base.cc
[modify] https://crrev.com/161ca16a30d167dc143ba177046ac67733c88a51/media/test/pipeline_integration_test_base.h
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f6687dc0980b0687a5f45e2da571a0edab66054

commit 3f6687dc0980b0687a5f45e2da571a0edab66054
Author: Fredrik Hubinette <hubbe@google.com>
Date: Mon Aug 27 18:25:05 2018

Propagate H264 color spaces to video frames on chromeos

Also makes some preparations for doing the same for VP9.

Bug:  647725 , 847573
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Id263a35b9f53be062ebae54d05c603a3efb270e8
Reviewed-on: https://chromium-review.googlesource.com/1153840
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586324}
[modify] https://crrev.com/3f6687dc0980b0687a5f45e2da571a0edab66054/media/gpu/vaapi/vaapi_h264_accelerator.cc
[modify] https://crrev.com/3f6687dc0980b0687a5f45e2da571a0edab66054/media/gpu/vaapi/vaapi_video_decode_accelerator.cc
[modify] https://crrev.com/3f6687dc0980b0687a5f45e2da571a0edab66054/media/gpu/vaapi/vaapi_video_decode_accelerator.h
[modify] https://crrev.com/3f6687dc0980b0687a5f45e2da571a0edab66054/media/gpu/vaapi/vaapi_vp8_accelerator.cc
[modify] https://crrev.com/3f6687dc0980b0687a5f45e2da571a0edab66054/media/gpu/vaapi/vaapi_vp9_accelerator.cc
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3cebc620edb6974da7682741361e8f6e9f7a2a4e

commit 3cebc620edb6974da7682741361e8f6e9f7a2a4e
Author: Fredrik Hubinette <hubbe@google.com>
Date: Sat Oct 27 01:01:12 2018

make VP9Decoder understand color spaces

This should make VP9Decoder set color spaces on returned
video frames correctly on windows and chromeos.

Bug:  647725 , 847573
Change-Id: I602e61e078795a511caef134256a0676199f031e
Reviewed-on: https://chromium-review.googlesource.com/c/1298635
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603270}
[modify] https://crrev.com/3cebc620edb6974da7682741361e8f6e9f7a2a4e/media/filters/vp9_parser.cc
[modify] https://crrev.com/3cebc620edb6974da7682741361e8f6e9f7a2a4e/media/filters/vp9_parser.h
[modify] https://crrev.com/3cebc620edb6974da7682741361e8f6e9f7a2a4e/media/filters/vp9_parser_unittest.cc
[modify] https://crrev.com/3cebc620edb6974da7682741361e8f6e9f7a2a4e/media/gpu/vaapi/vaapi_video_decode_accelerator.cc
[modify] https://crrev.com/3cebc620edb6974da7682741361e8f6e9f7a2a4e/media/gpu/vp9_decoder.cc
[modify] https://crrev.com/3cebc620edb6974da7682741361e8f6e9f7a2a4e/media/gpu/vp9_decoder.h
[modify] https://crrev.com/3cebc620edb6974da7682741361e8f6e9f7a2a4e/media/gpu/windows/d3d11_video_decoder.cc
[modify] https://crrev.com/3cebc620edb6974da7682741361e8f6e9f7a2a4e/media/gpu/windows/dxva_video_decode_accelerator_win.cc

Comment 12 by hubbe@chromium.org, Dec 1

Status: Fixed (was: Assigned)
I have tried my best to make all hardware decoders tag things with color spaces.
I do not know if I got all decoders and it all works, but I will be closing this bug for now.
►

Sign in to add a comment