New issue
Advanced search Search tips

Issue 647724 link

Starred by 1 user
Status: Fixed
Owner:
dougarnett@chromium.org
Closed: Sep 2016
Cc:
tbansal@chromium.org
petewil@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature



Sign in to add a comment

[Offline Pages] Leverage NetworkQualityEstimator for determining whether to immediately start background loading

Project Member Reported by dougarnett@chromium.org, Sep 16 2016 
Currently we may trigger immeditiate background loading upon adding or resuming a request if the system thinks it has a network connection. In case the network connection is poor, it would be good to defer starting the processing. Consider using the NetworkQualityEstimator to determine that.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e385c12e9e4f2b5969bb18ef63ebd66df8c0283

commit 2e385c12e9e4f2b5969bb18ef63ebd66df8c0283
Author: dougarnett <dougarnett@chromium.org>
Date: Mon Sep 19 21:45:51 2016

[OfflinePages, NetworkQualityEstimator] Use NetworkQualityEstimator to decide on triggering Background Loading immediately.
Defines a NetworkQualityEstimator interface, plumbs it into Offline Pages RequestCoordinator, and uses it in logic to determine immediate StartProcessing.

BUG= 647724 

Review-Url: https://codereview.chromium.org/2347783003
Cr-Commit-Position: refs/heads/master@{#419572}

[modify] https://crrev.com/2e385c12e9e4f2b5969bb18ef63ebd66df8c0283/chrome/browser/android/offline_pages/request_coordinator_factory.cc
[modify] https://crrev.com/2e385c12e9e4f2b5969bb18ef63ebd66df8c0283/chrome/browser/net/nqe/ui_network_quality_estimator_service.cc
[modify] https://crrev.com/2e385c12e9e4f2b5969bb18ef63ebd66df8c0283/chrome/browser/net/nqe/ui_network_quality_estimator_service.h
[modify] https://crrev.com/2e385c12e9e4f2b5969bb18ef63ebd66df8c0283/components/offline_pages/background/request_coordinator.cc
[modify] https://crrev.com/2e385c12e9e4f2b5969bb18ef63ebd66df8c0283/components/offline_pages/background/request_coordinator.h
[modify] https://crrev.com/2e385c12e9e4f2b5969bb18ef63ebd66df8c0283/components/offline_pages/background/request_coordinator_unittest.cc
[modify] https://crrev.com/2e385c12e9e4f2b5969bb18ef63ebd66df8c0283/net/nqe/network_quality_estimator.h

Comment 2 by dougarnett@chromium.org, Sep 22 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment