New issue
Advanced search Search tips

Issue 647723 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

H264 main profile video is loaded but not played on Mac when H/W decoding is enabled

Project Member Reported by yini...@chromium.org, Sep 16 2016

Issue description

Version: 55.0.2859.0
OS: Mac

This issue only repro on Mac. The other profiles (e.g baseline, high) not repro either. 
Video can play after disable H/W decoding.

What steps will reproduce the problem?
(1) navigate to http://172.31.18.18/videostack/testmatrix/index.html?file=brian2.mp4

What is the expected output?
video is loaded and played

What do you see instead?
the video is loaded, I can see all properties are displayed on chrome://media-internals, but the video is not played. 

 
Labels: Needs-Feedback
I am unable to reproduce this.

When I tested, the server was occasionally slow and on one occasion took ~10s to start playback.

Are you able to reproduce this consistently?
I can repro it all the time. what build are you using? I have tried different profile, all have the same results.
Turns out I had a local change in my checkout that was fixing this issue, a clean build reproduced.

This was broken by commit 8cbe5d69e18a9c387cfc61adf826ae121cf89834, which means M54 is also affected.
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1eaf4265002a158eadc3645b3aa31cdb0aefb2fc

commit 1eaf4265002a158eadc3645b3aa31cdb0aefb2fc
Author: sandersd <sandersd@chromium.org>
Date: Fri Sep 16 23:21:03 2016

VTVDA: Fix reorder queue size.

This size was incorrectly reduced in commit
8cbe5d69e18a9c387cfc61adf826ae121cf89834.

This commit also adds DVLOG()s to most methods. These should
have been there from the beginning.

BUG= 647723 

Review-Url: https://codereview.chromium.org/2345633006
Cr-Commit-Position: refs/heads/master@{#419323}

[modify] https://crrev.com/1eaf4265002a158eadc3645b3aa31cdb0aefb2fc/media/gpu/vt_video_decode_accelerator_mac.cc

Labels: Merge-Request-54

Comment 6 by dimu@chromium.org, Sep 19 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 19 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e55b55f71ea581ec25db045dbc48af5db16a7ae

commit 8e55b55f71ea581ec25db045dbc48af5db16a7ae
Author: Dan Sanders <sandersd@chromium.org>
Date: Mon Sep 19 21:46:07 2016

Merge to M54: VTVDA: Fix reorder queue size.

This size was incorrectly reduced in commit
8cbe5d69e18a9c387cfc61adf826ae121cf89834.

This commit also adds DVLOG()s to most methods. These should
have been there from the beginning.

BUG= 647723 
TBR=watk@chromium.org

Review-Url: https://codereview.chromium.org/2345633006
Cr-Commit-Position: refs/heads/master@{#419323}
(cherry picked from commit 1eaf4265002a158eadc3645b3aa31cdb0aefb2fc)

Review URL: https://codereview.chromium.org/2356573002 .

Cr-Commit-Position: refs/branch-heads/2840@{#422}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/8e55b55f71ea581ec25db045dbc48af5db16a7ae/media/gpu/vt_video_decode_accelerator_mac.cc

Status: Fixed (was: Assigned)
this probably breaks live site http://mediaelementjs.com, http://vine.co
need verify these sites after CL is in.
Unable to open the url "http://172.31.18.18/videostack/testmatrix/index.html?file=brian2.mp4" as its giving Uberproxy error.
Was able to play the videos on http://mediaelementjs.com, http://vine.co and its working fine.Attached screen cast for the same tested on mac 10.11.6 using 54.0.2840.34.
sandersd@ : Could you please confirm if its fine.
647723_Sept_21.mp4
1.9 MB View Download
Not holding Beta Release for today, we will verify once the steps are available. Requesting  yiningc@ to verify since we are unable to open the test site.
I have tested the current Canary to operate correctly, but I have not personally tested the M54 branch.
I have verified this bug does repro on present beta build 54.0.2840.27. It also repro on Vine.co and mediaelementjs.com.
@re # 13
yiningc@ : Could you please check on Beta # 54.0.2840.34 and confirm once.
I have verified this bug is fixed on 54.0.2840.34.
All these sites play normally now
vine.co
mediaelementjs.com
http://172.31.18.18/videostack/testmatrix/index.html?file=brian2.mp4
Project Member

Comment 16 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e55b55f71ea581ec25db045dbc48af5db16a7ae

commit 8e55b55f71ea581ec25db045dbc48af5db16a7ae
Author: Dan Sanders <sandersd@chromium.org>
Date: Mon Sep 19 21:46:07 2016

Merge to M54: VTVDA: Fix reorder queue size.

This size was incorrectly reduced in commit
8cbe5d69e18a9c387cfc61adf826ae121cf89834.

This commit also adds DVLOG()s to most methods. These should
have been there from the beginning.

BUG= 647723 
TBR=watk@chromium.org

Review-Url: https://codereview.chromium.org/2345633006
Cr-Commit-Position: refs/heads/master@{#419323}
(cherry picked from commit 1eaf4265002a158eadc3645b3aa31cdb0aefb2fc)

Review URL: https://codereview.chromium.org/2356573002 .

Cr-Commit-Position: refs/branch-heads/2840@{#422}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/8e55b55f71ea581ec25db045dbc48af5db16a7ae/media/gpu/vt_video_decode_accelerator_mac.cc

Sign in to add a comment