New issue
Advanced search Search tips

Issue 647719 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Nov 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

TouchActionBrowserTest.DefaultAuto failing on some devices (based on DIP scale)

Reported by kra...@amazon.com, Sep 16 2016 
Chrome Version       : Any

What steps will reproduce the problem?
1. Attach a device with a DIP scale of 1.3312500715255737
2. Run content_browsertests -f TouchActionBrowserTest.DefaultAuto

What is the expected result?
The test passes

What happens instead?
C   97.615s Main  ********************************************************************************
C   97.615s Main  [UNKNOWN] TouchActionBrowserTest.DefaultAuto:
C   97.615s Main  [ RUN      ] TouchActionBrowserTest.DefaultAuto
C   97.615s Main  [ERROR:devtools_http_handler.cc(228)] Cannot start http server for devtools. Stop devtools.
C   97.615s Main  [ERROR:shell_android.cc(72)] Not implemented reached in void content::Shell::PlatformSetTitle(const string16&): ready
C   97.615s Main  referenceTable head length=54 1
C   97.615s Main  ../../content/browser/renderer_host/input/touch_action_browsertest.cc:176: Failure
C   97.615s Main  Value of: scrollTop
C   97.615s Main    Actual: 44
C   97.615s Main  Expected: distance.y()
C   97.615s Main  Which is: 45
C   97.615s Main  [  FAILED  ] TouchActionBrowserTest.DefaultAuto, where TypeParam =  and GetParam() =  (3138 ms)
C   97.616s Main  [----------] 1 test from TouchActionBrowserTest (3140 ms total)
C   97.616s Main
C   97.616s Main  [----------] Global test environment tear-down
C   97.616s Main  [==========] 1 test from 1 test case ran. (3142 ms total)
C   97.616s Main  [  PASSED  ] 0 tests.
C   97.616s Main  [  FAILED  ] 1 test, listed below:
C   97.616s Main
C   97.616s Main   1 FAILED TEST
C   97.616s Main
C   97.616s Main  TouchActionBrowserTest.DefaultAutoFAILED
C   97.616s Main  FAILURES!!! Tests run: 1, Failures: 1, Errors: 0
C   97.616s Main  ********************************************************************************
C   97.616s Main  Summary
C   97.616s Main  ********************************************************************************
C   97.617s Main  [==========] 1 test ran.
C   97.617s Main  [  PASSED  ] 0 tests.
C   97.617s Main  [  FAILED  ] 1 test, listed below:
C   97.617s Main  [  FAILED  ] TouchActionBrowserTest.DefaultAuto (UNKNOWN)
C   97.617s Main
C   97.617s Main  1 FAILED TEST
C   97.617s Main  ********************************************************************************

Please provide any additional information below. Attach a screenshot if
possible.
This seems similar to other Android scrolling tests with similar problems in the past, e.g.:
https://bugs.chromium.org/p/chromium/issues/detail?id=537343

Comment 2 by kra...@amazon.com, Sep 16 2016 

For reference, one of the devices this is happening on is a Fire HD 7
Using org.chromium.ui.gfx.DeviceDisplayInfo, I get the following numbers:
getDisplayWidth() 800
getDisplayHeight() 1216
getDIPScale() 1.3312500715255737
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91e62e1806ecaf761a64619b51bb48b8a0d1784d

commit 91e62e1806ecaf761a64619b51bb48b8a0d1784d
Author: kraush <kraush@amazon.com>
Date: Fri Sep 16 21:39:53 2016

Allow for 1px rounding errors in scroll tests

Dependent on device screen sizes, scrolling can lead to
1px deviations from anticipated scroll values on Android
devices.
This change alters touch_action_browsertest to allow those
deviations.

BUG= 647719 

Review-Url: https://codereview.chromium.org/2347903002
Cr-Commit-Position: refs/heads/master@{#419282}

[modify] https://crrev.com/91e62e1806ecaf761a64619b51bb48b8a0d1784d/content/browser/renderer_host/input/touch_action_browsertest.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91e62e1806ecaf761a64619b51bb48b8a0d1784d

commit 91e62e1806ecaf761a64619b51bb48b8a0d1784d
Author: kraush <kraush@amazon.com>
Date: Fri Sep 16 21:39:53 2016

Allow for 1px rounding errors in scroll tests

Dependent on device screen sizes, scrolling can lead to
1px deviations from anticipated scroll values on Android
devices.
This change alters touch_action_browsertest to allow those
deviations.

BUG= 647719 

Review-Url: https://codereview.chromium.org/2347903002
Cr-Commit-Position: refs/heads/master@{#419282}

[modify] https://crrev.com/91e62e1806ecaf761a64619b51bb48b8a0d1784d/content/browser/renderer_host/input/touch_action_browsertest.cc

Comment 5 by dtapu...@chromium.org, Nov 11 2016

Status: Fixed (was: Untriaged)
►

Sign in to add a comment