Unsafe nested URL blocking needs to work with PlzNavigate |
||||
Issue descriptionr419019 added blocking of requests with nested URLs with extension origins originating from non-extension processes. Looks like these checks are incompatible with PlzNavigate and cause the following browser_tests failures: WebViewGuestTouchFocusTest.TouchFocusesBrowserPluginInEmbedder WebViewScrollGuestContent/WebViewScrollGuestContentTest.ScrollGuestContent/0 WebViewScrollBubbling/WebViewGuestScrollTouchTest.TestGuestGestureScrollsBubble/0 WebViewScrollBubbling/WebViewGuestScrollTouchTest.TestGuestGestureScrollsBubble/1 WebViewScrollBubbling/WebViewGuestScrollTouchTest.TestGuestGestureScrollsBubble/2 WebViewScrollBubbling/WebViewGuestScrollTouchTest.TestGuestGestureScrollsBubble/3 WebViewTests/WebViewFocusTest.TouchFocusesEmbedder/0 ProcessManagerBrowserTest.NestedURLNavigationsToExtensionAllowed The failures started in https://build.chromium.org/p/chromium.fyi/builders/Browser%20Side%20Navigation%20Linux/builds/21327 The WebView tests are failing because the <webview> src in these tests is set to a chrome-extension:// URL (from same app as where the embedder is served from), and the <webview> load is blocked. I don't quite know how these requests are issued with PlzNavigate, but from what Nasko tells me, they use blob URLs underneath with no renderer process being responsible for the request, and further the <webview> makes it seem like a top-level navigation, so it kind of makes sense why the blocking occurs. We'll need to fix this to work with PlzNavigate. I'll disable these tests while I investigate further.
,
Oct 4 2016
I started looking at some failing tests and saw that this is the same issue. I'll take care of this.
,
Oct 4 2016
Note that we've just relaxed this blocking for apps that embed <webview> in https://codereview.chromium.org/2387323002. This might already fix most of these tests.
,
Oct 4 2016
Thanks for the pointer. Yes your patch does fix -WebViewGuestTouchFocusTest.TouchFocusesBrowserPluginInEmbedder -WebViewScrollGuestContent/WebViewScrollGuestContentTest.ScrollGuestContent/0 -WebViewScrollBubbling/WebViewGuestScrollTouchTest.TestGuestGestureScrollsBubble* -WebViewTests/WebViewFocusTest.TouchFocusesEmbedder/0 I had an in progress patch that fixed them along with ProcessManagerBrowserTest.NestedURLNavigationsToExtensionAllowed I can update it now, unless you have fixes for them? I haven't fixed ProcessManagerBrowserTest.NestedURLNavigationsToExtensionBlocked yet, it's crashing in the renderer.
,
Oct 4 2016
I wasn't planning on fixing ProcessManagerBrowserTest.NestedURLNavigationsToExtension*, so please feel free to fix those.
,
Nov 4 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Sep 16 2016