New issue
Advanced search Search tips

Issue 647708 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Setting AnalyserNode.fftSize should reset internal state

Project Member Reported by rtoy@chromium.org, Sep 16 2016

Issue description

If the AnalyserNode.fftSize is set to a new value, the internal state used for computing the (smoothed) FFT results should be reset.

See https://github.com/WebAudio/web-audio-api/issues/924
Proposed change: https://github.com/WebAudio/web-audio-api/pull/978
 

Comment 1 by rtoy@chromium.org, Sep 26 2016

Owner: rtoy@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/647f68a193fdf3a1eeb26fd51badf0bffeb18edc

commit 647f68a193fdf3a1eeb26fd51badf0bffeb18edc
Author: rtoy <rtoy@chromium.org>
Date: Wed Sep 28 17:17:35 2016

Test setting Analyser.fftSize resets state

When the fftSize of an AnalyserNode is changed, the internal state
used for managing the smoothing of the FFT data should be reset.

Add test for this.

BUG= 647708 
TEST=realtimeanalyser-fftsize-reset.html

Review-Url: https://codereview.chromium.org/2344353002
Cr-Commit-Position: refs/heads/master@{#421553}

[add] https://crrev.com/647f68a193fdf3a1eeb26fd51badf0bffeb18edc/third_party/WebKit/LayoutTests/webaudio/realtimeanalyser-fftsize-reset.html

Comment 3 by rtoy@chromium.org, Oct 3 2016

Status: Fixed (was: Started)

Sign in to add a comment