Issue 647706 link

Starred by 1 user

Issue metadata

Status:	Archived
Owner:	agrieve@chromium.org
Closed:	Dec 2016
Cc:	x...@chromium.org █ keta...@chromium.org dpranke@chromium.org steve...@chromium.org
Components:	Build
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	1
Type:	Bug
VerifyIn-58 VerifyIn-59 VerifyIn-60 VerifyIn-61

BuildPackages failures due to GN errors on Informational builders

Project Member Reported by afakhry@chromium.org, Sep 16 2016

Issue description

The failure is:

chromeos-chrome-55.0.2863.0_alpha-r1: ERROR Input to target not generated by a dependency.
chromeos-chrome-55.0.2863.0_alpha-r1: The file:
chromeos-chrome-55.0.2863.0_alpha-r1:   /var/cache/chromeos-chrome/chrome-src-internal/src/out_x86-alex/Release/dump_syms
chromeos-chrome-55.0.2863.0_alpha-r1: is listed as an input or source for the target:
chromeos-chrome-55.0.2863.0_alpha-r1:   //blimp/engine:blimp_symbols
chromeos-chrome-55.0.2863.0_alpha-r1: but no targets in the build generate that file.


Builders failing:
x86-alex-tot-chrome-pfq-informational: https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/x86-alex-tot-chrome-pfq-informational/builds/21290
peach_pit-tot-chrome-pfq-informational: https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/peach_pit-tot-chrome-pfq-informational/builds/2904
cyan-tot-chrome-pfq-informational: https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/cyan-tot-chrome-pfq-informational/builds/446
veyron_minnie-tot-chrome-pfq-informational: https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/veyron_minnie-tot-chrome-pfq-informational/builds/457
amd64-generic Trusty (Informational): https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/amd64-generic%20Trusty%20%28Informational%29/builds/45687

The only recent CL that touches GN files is https://codereview.chromium.org/2348793002, but I'm not sure if it is to blame.

Comment 1 by afakhry@chromium.org, Sep 16 2016

Cc: -agrieve@chromium.org
Owner: agrieve@chromium.org
Status: Assigned (was: Untriaged)

This is indeed the culprit CL: https://codereview.chromium.org/2348793002.

It has a dependent CL, so I'm not sure if I should revert both.

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a07b9abadda659da084e94fc2a6a2d45da52a7a5

commit a07b9abadda659da084e94fc2a6a2d45da52a7a5
Author: afakhry <afakhry@chromium.org>
Date: Fri Sep 16 16:48:58 2016

Revert of Make chrome/BUILD.gn use symlink.gni rather than symlink.py directly (patchset #1 id:1 of https://codereview.chromium.org/2349603002/ )

Reason for revert:
Breaks BuildPackages due to GN error (https://bugs.chromium.org/p/chromium/issues/detail?id=647706).

BUG= 647706 

Original issue's description:
> Make chrome/BUILD.gn use symlink.gni rather than symlink.py directly
>
> Committed: https://crrev.com/ca5b9cba81bf335ce205cc06e094587b25c79758
> Cr-Commit-Position: refs/heads/master@{#419168}

TBR=dpranke@chromium.org,agrieve@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2344223002
Cr-Commit-Position: refs/heads/master@{#419190}

[modify] https://crrev.com/a07b9abadda659da084e94fc2a6a2d45da52a7a5/chrome/BUILD.gn

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b15725becf35dd933aedfa818b4b319910016c38

commit b15725becf35dd933aedfa818b4b319910016c38
Author: afakhry <afakhry@chromium.org>
Date: Fri Sep 16 16:50:09 2016

Revert of Use a stamp file when symlinking in GN work around mtime issues (patchset #1 id:1 of https://codereview.chromium.org/2348793002/ )

Reason for revert:
Breaks BuildPackages due to GN error (https://bugs.chromium.org/p/chromium/issues/detail?id=647706).

BUG= 647706 

Original issue's description:
> Use a stamp file when symlinking in GN work around mtime issues
>
> Ninja follows a symlink when stat'ing, so you can't use a symlink as an
> output and have dirty checking work properly.
> https://github.com/ninja-build/ninja/issues/1186
>
> BUG=646165
>
> Committed: https://crrev.com/fef37c4393d059c9125353928de7e49d4ea04ab4
> Cr-Commit-Position: refs/heads/master@{#419156}

TBR=dpranke@chromium.org,agrieve@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=646165

Review-Url: https://codereview.chromium.org/2348493005
Cr-Commit-Position: refs/heads/master@{#419191}

[modify] https://crrev.com/b15725becf35dd933aedfa818b4b319910016c38/build/symlink.gni