NetworkChangeNotifierAutoDetect slow to initialize |
||
Issue descriptionVersion: ToT OS: Android Repeatedly fetches WiFi SSID. Could directly query WifiManager for WifiInfo if app has ACCESS_WIFI_STATE permission. Internal bug b/30756545 Fix: https://codereview.chromium.org/2319753002/
,
Sep 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e30b8a04dde1f68f8a03f915bf448e65bbd7a19 commit 0e30b8a04dde1f68f8a03f915bf448e65bbd7a19 Author: pauljensen <pauljensen@chromium.org> Date: Fri Sep 23 17:50:40 2016 Non-functional simplification of NetworkChangeNotifierAutoDetect code Turns out NetworkState was only needed for the current default network, so simplify unnecessary pieces. This is in preparation for adding WiFi SSID to NetworkState, so I wanted to reduce the dependence on NetworkState so the code wouldn't be required to fetch the Wifi SSID as much. BUG= 647691 R=xunjieli Review-Url: https://codereview.chromium.org/2361563003 Cr-Commit-Position: refs/heads/master@{#420653} [modify] https://crrev.com/0e30b8a04dde1f68f8a03f915bf448e65bbd7a19/content/public/android/java/src/org/chromium/content/browser/BackgroundSyncNetworkObserver.java [modify] https://crrev.com/0e30b8a04dde1f68f8a03f915bf448e65bbd7a19/net/android/java/src/org/chromium/net/NetworkChangeNotifier.java [modify] https://crrev.com/0e30b8a04dde1f68f8a03f915bf448e65bbd7a19/net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java [modify] https://crrev.com/0e30b8a04dde1f68f8a03f915bf448e65bbd7a19/net/android/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java
,
Sep 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8788690b9a7d547bc55c0aa4bc54e3c230ca9391 commit 8788690b9a7d547bc55c0aa4bc54e3c230ca9391 Author: pauljensen <pauljensen@chromium.org> Date: Fri Sep 23 19:26:30 2016 Remove WiFi link speed tracking from Android NetworkChangeNotifier Chrome has eschewed ACCESS_WIFI_STATE permission so this code is disabled. Chrome is also the only user of this NetworkChangeNotifier signal so remove the code as it is consequently dead. BUG= 647691 R=jkarlin Review-Url: https://codereview.chromium.org/2359173002 Cr-Commit-Position: refs/heads/master@{#420692} [modify] https://crrev.com/8788690b9a7d547bc55c0aa4bc54e3c230ca9391/net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java [modify] https://crrev.com/8788690b9a7d547bc55c0aa4bc54e3c230ca9391/net/android/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java
,
Sep 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/336a75e2356486da08bd04996affa8a43aa3056e commit 336a75e2356486da08bd04996affa8a43aa3056e Author: pauljensen <pauljensen@chromium.org> Date: Fri Sep 30 16:29:24 2016 Non-functional improvement to reduce querying of WiFi SSID upon startup Include WiFi SSID in NetworkState so it can be reused without re-querying. Also improve how we fetch WiFi SSID if needed: 1. On Android 4.2+ devices, SSID can be retreived from NetworkInfo which NetworkChangeNotifierAutoDetect already queried 2. When an app has the ACCESS_WIFI_STATE permission, the SSID can be queried quickly directly from WifiManager. BUG= 647691 R=xunjieli Review-Url: https://codereview.chromium.org/2360303002 Cr-Commit-Position: refs/heads/master@{#422128} [modify] https://crrev.com/336a75e2356486da08bd04996affa8a43aa3056e/net/android/BUILD.gn [modify] https://crrev.com/336a75e2356486da08bd04996affa8a43aa3056e/net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java [modify] https://crrev.com/336a75e2356486da08bd04996affa8a43aa3056e/net/android/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java
,
Sep 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9d22a638fceab53238e8ac65dad0f732376ae3a commit c9d22a638fceab53238e8ac65dad0f732376ae3a Author: pauljensen <pauljensen@chromium.org> Date: Fri Sep 30 18:37:14 2016 Non-functional optimization to Android NetworkChangeNotifier startup Ignore the initial onReceive() callback when registering a BroadcastRecevier for a sticky Intent as it doesn't offer any new information. BUG= 647691 R=xunjieli Review-Url: https://codereview.chromium.org/2366503003 Cr-Commit-Position: refs/heads/master@{#422162} [modify] https://crrev.com/c9d22a638fceab53238e8ac65dad0f732376ae3a/net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java
,
Oct 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/077c5724607adaa7fcc6ca04cdf5975133560eb0 commit 077c5724607adaa7fcc6ca04cdf5975133560eb0 Author: pauljensen <pauljensen@chromium.org> Date: Mon Oct 03 01:28:50 2016 Non-functional optimization to Android NetworkChangeNotifier startup part 2 Avoid needlessly computing whether a change signal needs to be sent out during initialization (when there can't be a change). This allows avoiding needlessly requerying the current connection state. BUG= 647691 R=xunjieli Review-Url: https://codereview.chromium.org/2363743002 Cr-Commit-Position: refs/heads/master@{#422357} [modify] https://crrev.com/077c5724607adaa7fcc6ca04cdf5975133560eb0/net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java
,
Oct 3 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by pauljensen@chromium.org
, Sep 16 2016Labels: OS-Android