New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 647683 link

Starred by 3 users
Status: Fixed
Owner:
jam@chromium.org
Closed: Sep 2016
Cc:
tedc...@chromium.org
est...@chromium.org
█ f...@chromium.org
█ nasko@chromium.org
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug-Security



Sign in to add a comment

Wrong security state when going back/forward after HTML5 history push

Reported by jleedev@gmail.com, Sep 16 2016 
UserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2860.0 Safari/537.36

Steps to reproduce the problem:
Either:
1. Visit https://github.com/rust-lang/rust
2. Click on README.md
3. Go back

Or (minimal):
1. Visit https://www.example.com
2. history.pushState({}, '', '');
3. Go back

What is the expected behavior?
Security state should remain secure.

What went wrong?
Security state switches to "not secure".

Did this work before? Yes 53 and 54 are ok.

Chrome version: 55.0.2860.0  Channel: canary
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: 

This looks like another edge case of  Issue 643173 .

Comment 1 by est...@chromium.org, Sep 16 2016

Cc: nasko@chromium.org est...@chromium.org
Components: Security>UX
Labels: -OS-Windows OS-All
Owner: jam@chromium.org
Status: Assigned (was: Unconfirmed)
Confirmed on 55.0.2861.0. jam, could you take a look please?

Comment 2 by est...@chromium.org, Sep 19 2016

Labels: -Restrict-View-SecurityTeam ReleaseBlock-Beta Security_Impact-None
De-restricting and taking out of the security sheriff queue, since we are failing to show the lock icon when we should be. (Instead of, for example, showing it when we shouldn't be, which would be a security bug.) Still, I think we should fix this ASAP.

Comment 3 by jam@chromium.org, Sep 19 2016

Status: Started (was: Assigned)
doh, looking.
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9edf16001930c58297ae6790c74c5b36050906e8

commit 9edf16001930c58297ae6790c74c5b36050906e8
Author: jam <jam@chromium.org>
Date: Tue Sep 20 01:40:58 2016

Fix navigations after HTML5 history push losing their SSL status.

BUG= 647683 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2348203003
Cr-Commit-Position: refs/heads/master@{#419633}

[modify] https://crrev.com/9edf16001930c58297ae6790c74c5b36050906e8/chrome/browser/ssl/ssl_browser_tests.cc
[modify] https://crrev.com/9edf16001930c58297ae6790c74c5b36050906e8/content/browser/frame_host/navigation_controller_impl.cc

Comment 5 by jam@chromium.org, Sep 20 2016

Status: Fixed (was: Started)
Project Member

Comment 6 by sheriffbot@chromium.org, Sep 20 2016

Labels: -ReleaseBlock-Beta

Comment 7 by f...@chromium.org, Sep 28 2016

Cc: f...@chromium.org tedc...@chromium.org
 Issue 649552  has been merged into this issue.
Project Member

Comment 8 by sheriffbot@chromium.org, Oct 1 2016

Labels: Restrict-View-SecurityNotify

Comment 9 by lafo...@chromium.org, Dec 9 2016

Components: -Security>UX
Labels: Team-Security-UX
Security>UX component is deprecated in favor of the Team-Security-UX label
Project Member

Comment 10 by sheriffbot@chromium.org, Dec 27 2016

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 11 by awhalley@chromium.org, Nov 12

Labels: reward-topanel

Comment 12 by awhalley@google.com, Dec 3

Labels: -reward-topanel reward-0
►

Sign in to add a comment