New issue
Advanced search Search tips

Issue 647679 link

Starred by 1 user
Status: Fixed
Owner:
agrieve@chromium.org
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

GN: rebase_path("//foo", "//foo") results in "../foo" rather than "."

Project Member Reported by agrieve@chromium.org, Sep 16 2016 
gn --version: 417994

This came up from:
"--libraries-dir", rebase_path(root_shlib_dir, root_build_dir),

It was being forwarded on as being the prefix to a depfile (".d" file), but ninja does not handle it correctly (presumably because it goes above the build root)
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d56c98e60572a809a47918ef98e7b3d9138c5ad

commit 3d56c98e60572a809a47918ef98e7b3d9138c5ad
Author: agrieve <agrieve@chromium.org>
Date: Fri Sep 16 18:40:49 2016

Make rebase_path("//foo", "//foo") resolve to "." (not "../foo")

BUG= 647679 

Review-Url: https://codereview.chromium.org/2346913003
Cr-Commit-Position: refs/heads/master@{#419229}

[modify] https://crrev.com/3d56c98e60572a809a47918ef98e7b3d9138c5ad/tools/gn/function_rebase_path.cc
[modify] https://crrev.com/3d56c98e60572a809a47918ef98e7b3d9138c5ad/tools/gn/function_rebase_path_unittest.cc

Comment 2 by agrieve@chromium.org, Sep 16 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment