New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 647670 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: ----
Type: ----



Sign in to add a comment

Separate managed and un-managed for ARC provisioning result historgram

Project Member Reported by phweiss@chromium.org, Sep 16 2016

Issue description

Original bug at b/31442315
Feature request: Deprecate histogram "Arc.Provisioning.Result" and replace it by two new histograms "Arc.Provisioning.Result.Managed" and "Arc.Provisioning.Result.Unmanaged" for more detailed data.


 
Labels: -Merge-Request-54
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ca52852f992b97cf3bfefff7e70a605ed2295bc

commit 1ca52852f992b97cf3bfefff7e70a605ed2295bc
Author: phweiss <phweiss@chromium.org>
Date: Thu Sep 22 13:48:40 2016

Separate ARC++ Provisioning Histogram into managed and unmanaged

Deprecate "Arc.Provisioning.Result" and replace it by
"Arc.Provisioning.Result.Managed" and "Arc.Provisioning.Result.Unmanaged"
for more detailed feedback.

BUG= 647670 
BUG=b/31442315

Review-Url: https://codereview.chromium.org/2339393002
Cr-Commit-Position: refs/heads/master@{#420322}

[modify] https://crrev.com/1ca52852f992b97cf3bfefff7e70a605ed2295bc/chrome/browser/chromeos/arc/arc_auth_service.cc
[modify] https://crrev.com/1ca52852f992b97cf3bfefff7e70a605ed2295bc/chrome/browser/chromeos/arc/arc_optin_uma.cc
[modify] https://crrev.com/1ca52852f992b97cf3bfefff7e70a605ed2295bc/chrome/browser/chromeos/arc/arc_optin_uma.h
[modify] https://crrev.com/1ca52852f992b97cf3bfefff7e70a605ed2295bc/tools/metrics/histograms/histograms.xml

Labels: Merge-Request-54

Comment 4 by dimu@chromium.org, Sep 23 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)
Project Member

Comment 5 by sheriffbot@chromium.org, Sep 26 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Merging failed, "Got exception while uploading" was the only error message from git drover. Maybe because I never got around to become full committer? Luis, could you try to run this command?

git drover --branch 2840 --cherry-pick 1ca52852f992b97cf3bfefff7e70a605ed2295bc
Never mind, I did it manually:
https://codereview.chromium.org/2373473003
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 27 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed36c84b926b5cd8aa294a9b662a149b58b89b3b

commit ed36c84b926b5cd8aa294a9b662a149b58b89b3b
Author: phweiss <phweiss@chromium.org>
Date: Tue Sep 27 14:52:47 2016

Separate ARC++ Provisioning Histogram into managed and unmanaged

Deprecate "Arc.Provisioning.Result" and replace it by
"Arc.Provisioning.Result.Managed" and "Arc.Provisioning.Result.Unmanaged"
for more detailed feedback.

BUG= 647670 
BUG=b/31442315
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2339393002
Cr-Commit-Position: refs/heads/master@{#420322}
(cherry picked from commit 1ca52852f992b97cf3bfefff7e70a605ed2295bc)

Review-Url: https://codereview.chromium.org/2373473003
Cr-Commit-Position: refs/branch-heads/2840@{#545}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/ed36c84b926b5cd8aa294a9b662a149b58b89b3b/chrome/browser/chromeos/arc/arc_auth_service.cc
[modify] https://crrev.com/ed36c84b926b5cd8aa294a9b662a149b58b89b3b/chrome/browser/chromeos/arc/arc_optin_uma.cc
[modify] https://crrev.com/ed36c84b926b5cd8aa294a9b662a149b58b89b3b/chrome/browser/chromeos/arc/arc_optin_uma.h
[modify] https://crrev.com/ed36c84b926b5cd8aa294a9b662a149b58b89b3b/tools/metrics/histograms/histograms.xml

Labels: -Hotlist-Merge-Approved
Status: Fixed (was: Started)
Labels: VerifyIn-55
Project Member

Comment 13 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed36c84b926b5cd8aa294a9b662a149b58b89b3b

commit ed36c84b926b5cd8aa294a9b662a149b58b89b3b
Author: phweiss <phweiss@chromium.org>
Date: Tue Sep 27 14:52:47 2016

Separate ARC++ Provisioning Histogram into managed and unmanaged

Deprecate "Arc.Provisioning.Result" and replace it by
"Arc.Provisioning.Result.Managed" and "Arc.Provisioning.Result.Unmanaged"
for more detailed feedback.

BUG= 647670 
BUG=b/31442315
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2339393002
Cr-Commit-Position: refs/heads/master@{#420322}
(cherry picked from commit 1ca52852f992b97cf3bfefff7e70a605ed2295bc)

Review-Url: https://codereview.chromium.org/2373473003
Cr-Commit-Position: refs/branch-heads/2840@{#545}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/ed36c84b926b5cd8aa294a9b662a149b58b89b3b/chrome/browser/chromeos/arc/arc_auth_service.cc
[modify] https://crrev.com/ed36c84b926b5cd8aa294a9b662a149b58b89b3b/chrome/browser/chromeos/arc/arc_optin_uma.cc
[modify] https://crrev.com/ed36c84b926b5cd8aa294a9b662a149b58b89b3b/chrome/browser/chromeos/arc/arc_optin_uma.h
[modify] https://crrev.com/ed36c84b926b5cd8aa294a9b662a149b58b89b3b/tools/metrics/histograms/histograms.xml

Sign in to add a comment