New issue
Advanced search Search tips

Issue 647668 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Poor test coverage for preparser because allow_natives disables it

Project Member Reported by marja@chromium.org, Sep 16 2016

Issue description

A lot of the compiler tests need --allow-natives-syntax, and that just disables preparsing.

We need a lot more coverage now since we're going to lazy-parse more functions than before (esp. inner functions).

Source: the "preparse inner functions, just track unresolved variables but don't track variable declarations" approach was utterly, horribly wrong (breaks recompilation), but no test failed. Most tests trigger recompilation by %OptimizeFunctionOnNextCall / %BaselineFunctionOnNextCall / %OptimizeOSR, which means that we don't ever lazy parse in tests which do that.

Ouch.
 

Comment 1 by marja@chromium.org, Sep 16 2016

Components: Blink>JavaScript

Comment 2 by marja@chromium.org, Sep 16 2016

Boah, wrong project, how do I migrate this to a different project... I don't?

Comment 3 by marja@chromium.org, Sep 16 2016

Status: WontFix (was: Untriaged)
Here's the V8 bug, closing this one:
https://bugs.chromium.org/p/v8/issues/detail?id=5398

Comment 4 by adamk@chromium.org, Sep 16 2016

For future reference, it is possible to migrate across projects: look for "Move issue" under the "More actions" dropdown menu.

Sign in to add a comment