New issue
Advanced search Search tips

Issue 647620 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

1.6% regression in jetstream at 417939:417973

Project Member Reported by primiano@chromium.org, Sep 16 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=647620

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgucCYvgoM


Bot(s) for this bug's original alert(s):

linux-release
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Sep 16 2016

Cc: bmeu...@chromium.org
Owner: bmeu...@chromium.org

=== Auto-CCing suspected CL author bmeurer@chromium.org ===

Hi bmeurer@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : [turbofan] Ship eval.
Author  : bmeurer
Commit description:
  
No longer disable TurboFan for functions with eval, but only disable
Crankshaft in those cases.

R=mstarzinger@chromium.org
BUG=v8:5267

Review-Url: https://codereview.chromium.org/2334633002
Cr-Commit-Position: refs/heads/master@{#39338}
Commit  : f0a0c432a5d048d39f250a7bb20d662d14e1cd17
Date    : Mon Sep 12 09:41:29 2016


===== TESTED REVISIONS =====
Revision                       Mean     Std Dev   N  Good?
chromium@417938                196.875  0.64087   8  good
chromium@417940                196.5    0.92582   8  good
chromium@417940,v8@f0a0c432a5  195.0    0.707107  5  bad    <--
chromium@417940,v8@685d488288  194.75   0.886405  8  bad
chromium@417941                194.625  0.517549  8  bad
chromium@417943                194.8    0.83666   5  bad
chromium@417947                194.2    0.83666   5  bad
chromium@417956                194.6    0.547723  5  bad
chromium@417973                195.375  0.744024  8  bad

Bisect job ran on: linux_perf_bisect
Bug ID: 647620

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests jetstream
Test Metric: Score/Score
Relative Change: 0.81%
Score: 99.8

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_bisect/builds/6714
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9001371223812183344


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6203008180813824

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
bmeurer, seems your patch caused the regression. Can you take a look?
Ping bmeurer@

Comment 6 by benhenry@google.com, Oct 25 2016

Labels: -Pri-2 Pri-1
Ping. It's been over a month. PTAL, thanks.
Status: WontFix (was: Assigned)
Yap, this is expected. We do now optimize more, and with TurboFan that's not cheap. Some benchmarks go up, some go down.

Sign in to add a comment