New issue
Advanced search Search tips

Issue 647603 link

Starred by 1 user
Status: Duplicate
Owner:
primiano@chromium.org
Closed: Oct 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression

Blocked on:
issue 644865
issue 653519


Sign in to add a comment

487.6% regression in page_cycler_v2.intl_hi_ru at 418813:418831

Project Member Reported by primiano@chromium.org, Sep 16 2016 
I'm pretty sure this is the TSProxy thing again.
https://codereview.chromium.org/2341723004

Comment 1 by primiano@chromium.org, Sep 16 2016 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=647603

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg2cD1pwkM


Bot(s) for this bug's original alert(s):

chromium-rel-win8-dual
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Sep 16 2016 

Bisect failed: http://build.chromium.org/p/tryserver.chromium.perf/builders/win_8_perf_bisect/builds/2197
Failure reason: the build has failed.
Additional errors:
The metric was not found in the test output.
Either of the initial "good" or "bad" revisions failed to be tested or built.

Comment 4 by sullivan@chromium.org, Sep 20 2016

Blockedon: 644865
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Oct 4 2016

Mergedinto: 649983
Status: Duplicate (was: Assigned)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Revert of "[telemetry] Wire TsProxy through telemetry's network stack." (patchset #1 id:1 of https://codereview.chromium.org/2335403003/ )
Author  : perezju
Commit description:
  
Reason for revert:
Did not actually break WPR. Fine to reland and enable TsProxy

Original issue's description:
> Reland of "[telemetry] Wire TsProxy through telemetry's network stack." (patchset #1 id:1 of https://codereview.chromium.org/2342503002/ )
>
> Reason for revert:
> Broke WPR replay on WebView bots
>
> Original issue's description:
> > Revert of Revert "[telemetry] Wire TsProxy through telemetry's network stack." (patchset #1 id:1 of https://codereview.chromium.org/2267613002/ )
> >
> > Reason for revert:
> > Webview now support --proxy-server flag (see attached bug)
> >
> > Original issue's description:
> > > Revert "[telemetry] Wire TsProxy through telemetry's network stack."
> > >
> > > This reverts commit 9fcccf0b65703994c9541273f00a993806a95356.
> > >
> > > Revert "[Telemetry] Explictly initialize & clean up network_controller"
> > >
> > > This reverts commit 30ce231266c6fb6147bb6df7c56a7eb75c23fccf.
> > >
> > > Seems like webview currently does not support proxy server?
> > > (See attached chromium bug)
> > >
> > > BUG=chromium:639632
> > > BUG=catapult:#2584
> > >
> > > TBR=pmeenan@chromium.org
> > >
> > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/947506bacfb5047857a52033256635faebf38af2
> >
> > TBR=nednguyen@chromium.org
> > # Not skipping CQ checks because original CL landed more than 1 days ago.
> > BUG=chromium:639632
> >
> > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/b86cfef4b9da4749ff51e0fc4432869f8209dc42
>
> TBR=nednguyen@chromium.org,nednguyen@google.com
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=chromium:639632
>
> Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/32dd31095913725705e9cf5f5bc1671f32821a35

TBR=nednguyen@chromium.org,nednguyen@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:639632

Review-Url: https://codereview.chromium.org/2346773002
Commit  : 3cc40b37372927435ed69f91aec2117488b0825c
Date    : Thu Sep 15 09:25:34 2016


===== TESTED REVISIONS =====
Revision                             Mean     Std Dev  N  Good?
chromium@418807                      130.331  24.2299  5  good
chromium@418815                      123.819  31.397   5  good
chromium@418819                      127.635  58.8302  5  good
chromium@418821                      150.245  41.0131  5  good
chromium@418822                      124.036  41.998   5  good
chromium@418822,catapult@3cc40b3737  739.733  2.68352  5  bad    <--
chromium@418823                      743.652  6.04782  5  bad

Bisect job ran on: winx64intel_perf_bisect
Bug ID: 647603

Test Command: src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --also-run-disabled-tests page_cycler_v2.intl_hi_ru
Test Metric: timeToFirstMeaningfulPaint_avg/pcv1-cold/http___ru.wikipedia.org_
Relative Change: 470.59%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64intel_perf_bisect/builds/1184
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8999799927403051408


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6191958563749888

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Project Member

Comment 8 by 42576172...@developer.gserviceaccount.com, Oct 4 2016 


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Revert of "[telemetry] Wire TsProxy through telemetry's network stack." (patchset #1 id:1 of https://codereview.chromium.org/2335403003/ )
Author  : perezju
Commit description:
  
Reason for revert:
Did not actually break WPR. Fine to reland and enable TsProxy

Original issue's description:
> Reland of "[telemetry] Wire TsProxy through telemetry's network stack." (patchset #1 id:1 of https://codereview.chromium.org/2342503002/ )
>
> Reason for revert:
> Broke WPR replay on WebView bots
>
> Original issue's description:
> > Revert of Revert "[telemetry] Wire TsProxy through telemetry's network stack." (patchset #1 id:1 of https://codereview.chromium.org/2267613002/ )
> >
> > Reason for revert:
> > Webview now support --proxy-server flag (see attached bug)
> >
> > Original issue's description:
> > > Revert "[telemetry] Wire TsProxy through telemetry's network stack."
> > >
> > > This reverts commit 9fcccf0b65703994c9541273f00a993806a95356.
> > >
> > > Revert "[Telemetry] Explictly initialize & clean up network_controller"
> > >
> > > This reverts commit 30ce231266c6fb6147bb6df7c56a7eb75c23fccf.
> > >
> > > Seems like webview currently does not support proxy server?
> > > (See attached chromium bug)
> > >
> > > BUG=chromium:639632
> > > BUG=catapult:#2584
> > >
> > > TBR=pmeenan@chromium.org
> > >
> > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/947506bacfb5047857a52033256635faebf38af2
> >
> > TBR=nednguyen@chromium.org
> > # Not skipping CQ checks because original CL landed more than 1 days ago.
> > BUG=chromium:639632
> >
> > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/b86cfef4b9da4749ff51e0fc4432869f8209dc42
>
> TBR=nednguyen@chromium.org,nednguyen@google.com
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=chromium:639632
>
> Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/32dd31095913725705e9cf5f5bc1671f32821a35

TBR=nednguyen@chromium.org,nednguyen@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:639632

Review-Url: https://codereview.chromium.org/2346773002
Commit  : 3cc40b37372927435ed69f91aec2117488b0825c
Date    : Thu Sep 15 09:25:34 2016


===== TESTED REVISIONS =====
Revision                             Mean     Std Dev  N  Good?
chromium@418812                      668.719  219.477  5  good
chromium@418822                      542.432  217.584  5  good
chromium@418822,catapult@3cc40b3737  1108.25  117.209  5  bad    <--
chromium@418823                      1150.22  80.5471  5  bad
chromium@418824                      1076.3   88.3715  5  bad
chromium@418825                      1153.06  77.0097  5  bad
chromium@418827                      1101.78  122.636  5  bad
chromium@418831                      1074.56  51.7706  5  bad

Bisect job ran on: win_8_perf_bisect
Bug ID: 647603

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests page_cycler_v2.intl_hi_ru
Test Metric: timeToFirstContentfulPaint_avg/pcv1-cold/http___photofile.ru_
Relative Change: 60.69%
Score: 99.5

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/win_8_perf_bisect/builds/2220
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8999800268457864768


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5812432033808384

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Comment 9 by nedngu...@google.com, Oct 6 2016

Blockedon: 653519
►

Sign in to add a comment