Document.write() fails parse after calling CustomElementRegistry.define() |
|||||||||
Issue descriptionWebkit tests fail. https://github.com/WebKit/webkit/blob/master/LayoutTests/fast/custom-elements/defined-pseudo-class.html Running the following code does not parse 'another-node'. customElements.define('returns-node', class extends HTMLElement {}); document.write('<returns-node></returns-node>'); document.write('<another-node></another-node>');
,
Sep 16 2016
,
Sep 16 2016
,
Sep 21 2016
,
Sep 21 2016
,
Sep 23 2016
,
Sep 23 2016
,
Sep 26 2016
Patch up at https://codereview.chromium.org/2369853002/
,
Sep 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/89a6eed72ae35c6219934b7a11b61dfc60819b97 commit 89a6eed72ae35c6219934b7a11b61dfc60819b97 Author: davaajav <davaajav@google.com> Date: Fri Sep 30 06:21:11 2016 HTML parser: implementing throw-on-dynamic-markup-insertion counter https://html.spec.whatwg.org/#throw-on-dynamic-markup-insertion-counter Custom Element constructor should not be able to use document.write(), document.open(), document.close(). https://html.spec.whatwg.org/#dom-document-write https://html.spec.whatwg.org/#dom-document-open https://html.spec.whatwg.org/#dom-document-close Throw-on-dynamic-markup-insertion count is incremented/decremented in create an element for the token algorithm. https://html.spec.whatwg.org/#create-an-element-for-the-token Layout test changes: Custom Element constructor should not use document.write(), for both "destructive" and "non-destructive" writes. BUG= 647586 Review-Url: https://codereview.chromium.org/2369853002 Cr-Commit-Position: refs/heads/master@{#422042} [modify] https://crrev.com/89a6eed72ae35c6219934b7a11b61dfc60819b97/third_party/WebKit/LayoutTests/custom-elements/spec/parsing.html [modify] https://crrev.com/89a6eed72ae35c6219934b7a11b61dfc60819b97/third_party/WebKit/Source/core/dom/BUILD.gn [modify] https://crrev.com/89a6eed72ae35c6219934b7a11b61dfc60819b97/third_party/WebKit/Source/core/dom/Document.cpp [modify] https://crrev.com/89a6eed72ae35c6219934b7a11b61dfc60819b97/third_party/WebKit/Source/core/dom/Document.h [add] https://crrev.com/89a6eed72ae35c6219934b7a11b61dfc60819b97/third_party/WebKit/Source/core/dom/ThrowOnDynamicMarkupInsertionCountIncrementer.h [modify] https://crrev.com/89a6eed72ae35c6219934b7a11b61dfc60819b97/third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp
,
Oct 3 2016
dominicc@, can we close this bug?
,
Oct 4 2016
Davaa's patch should have fixed this. Thanks, Davaa! |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by davaajav@google.com
, Sep 16 2016