New issue
Advanced search Search tips

Issue 647582 link

Starred by 3 users

Issue metadata

Status: Duplicate
Owner: ----
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 629332



Sign in to add a comment

Consider dropping the auto-detection of ISO-2022-JP

Project Member Reported by js...@chromium.org, Sep 16 2016

Issue description

Taken from https://github.com/whatwg/encoding/issues/68#issuecomment-237506739 : 

>  does existing Web content actually require ISO-2022-JP to be heuristically detected
> Wouldn't in be a security improvement not to detect ISO-2022-JP ? 

Do we have statistics on what percentage of ISO-2022-JP pages are NOT labelled?  
 
I don't think we have those statistics. If we wanted to add them it looks like you could add a histogram here:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/text/TextEncodingDetector.cpp?rcl=1479802672&l=38

I imagine we go this route if we decide we need to do auto-detection, but you'll want to double check.

Comment 2 by benhenry@google.com, Nov 24 2016

Blocking: 629332
Status: Available (was: Untriaged)
Project Member

Comment 4 by sheriffbot@chromium.org, Feb 21 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: tkent@chromium.org kojii@chromium.org
+tkent, kojii who seem to be experts on that area

Comment 6 by kojii@chromium.org, Feb 23 2018

jshin, is this still valid, or superseded by related bugs such as issue 691985 or issue 778994?
Mergedinto: 780024
Status: Duplicate (was: Untriaged)
I suggest we follow up from Issue 780024. I am initially assigned to it but I can't help but think we need more inputs from native Japanese who will get direct impact with the suggested changes. 

Sign in to add a comment