video_encode_accelerator_unittest: incorrect aligned allocation for non-ARM platforms |
|||||
Issue descriptionvideo_encode_accelerator_unittest is incorrectly allocating memory for the test stream with alignment = 1 (https://cs.chromium.org/chromium/src/media/gpu/video_encode_accelerator_unittest.cc?rcl=1464045517&l=168). Alignment must be a multiple of pointer size.
,
Sep 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa9176904652aafddc53351571dd2dc2c65a36db commit fa9176904652aafddc53351571dd2dc2c65a36db Author: lionel.g.landwerlin <lionel.g.landwerlin@intel.com> Date: Fri Sep 16 07:33:49 2016 media: gpu: vea_unittest: fix alignment on non ARM platforms The base::AlignedAlloc expects a alignement multiple of sizeof(void*) : DCHECK_EQ(alignment % sizeof(void*), 0U); This fixes this error : [0826/162544:FATAL:aligned_memory.cc(19)] Check failed: alignment % sizeof(void*) == 0U (1 vs. 0) BUG= 647570 TEST=run video_encode_accelerator_unittest on a non ARM platform Review-Url: https://codereview.chromium.org/2281043002 Cr-Commit-Position: refs/heads/master@{#419124} [modify] https://crrev.com/fa9176904652aafddc53351571dd2dc2c65a36db/media/gpu/video_encode_accelerator_unittest.cc
,
Sep 17 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 20 2016
Please help merge this.
,
Sep 20 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/87b77e4cd5c5536a0fd45268b228d02fce1f648b commit 87b77e4cd5c5536a0fd45268b228d02fce1f648b Author: Kuang-che Wu <kcwu@chromium.org> Date: Wed Sep 21 08:18:39 2016 media: gpu: vea_unittest: fix alignment on non ARM platforms The base::AlignedAlloc expects a alignement multiple of sizeof(void*) : DCHECK_EQ(alignment % sizeof(void*), 0U); This fixes this error : [0826/162544:FATAL:aligned_memory.cc(19)] Check failed: alignment % sizeof(void*) == 0U (1 vs. 0) BUG= 647570 TEST=run video_encode_accelerator_unittest on a non ARM platform Review-Url: https://codereview.chromium.org/2281043002 Cr-Commit-Position: refs/heads/master@{#419124} (cherry picked from commit fa9176904652aafddc53351571dd2dc2c65a36db) Review URL: https://codereview.chromium.org/2357733004 . Cr-Commit-Position: refs/branch-heads/2840@{#460} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/87b77e4cd5c5536a0fd45268b228d02fce1f648b/media/gpu/video_encode_accelerator_unittest.cc
,
Sep 22 2016
,
Sep 30 2016
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/87b77e4cd5c5536a0fd45268b228d02fce1f648b commit 87b77e4cd5c5536a0fd45268b228d02fce1f648b Author: Kuang-che Wu <kcwu@chromium.org> Date: Wed Sep 21 08:18:39 2016 media: gpu: vea_unittest: fix alignment on non ARM platforms The base::AlignedAlloc expects a alignement multiple of sizeof(void*) : DCHECK_EQ(alignment % sizeof(void*), 0U); This fixes this error : [0826/162544:FATAL:aligned_memory.cc(19)] Check failed: alignment % sizeof(void*) == 0U (1 vs. 0) BUG= 647570 TEST=run video_encode_accelerator_unittest on a non ARM platform Review-Url: https://codereview.chromium.org/2281043002 Cr-Commit-Position: refs/heads/master@{#419124} (cherry picked from commit fa9176904652aafddc53351571dd2dc2c65a36db) Review URL: https://codereview.chromium.org/2357733004 . Cr-Commit-Position: refs/branch-heads/2840@{#460} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/87b77e4cd5c5536a0fd45268b228d02fce1f648b/media/gpu/video_encode_accelerator_unittest.cc |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by posciak@chromium.org
, Sep 16 2016