New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 647569 link

Starred by 2 users
Status: Fixed
Owner:
dominickn@chromium.org
Closed: Sep 2016
Cc:
█ owe...@chromium.org
█ ericchou@google.com
█ mariakho...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Navigations within a PWA should never be intercepted and redirected to an external application

Project Member Reported by dominickn@chromium.org, Sep 16 2016 
Context: a user has added a PWA at https://domain.com/path to homescreen, and they have also installed a native app handling https://domain.com/path*

When the user is in the fullscreen PWA window, navigations to https://domain.com/path* should never be rerouted to the intent picker or to the native app. They should stay within the PWA and navigate normally.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/671b9d029e9ead87a24fb38e5268dee3f4de7a96

commit 671b9d029e9ead87a24fb38e5268dee3f4de7a96
Author: dominickn <dominickn@chromium.org>
Date: Mon Sep 19 01:31:52 2016

Prevent navigations within fullscreen webapps from being intercepted.

If a native app and a PWA are installed which handle the same URLs,
a navigation within the PWA may open the intent picker to ask the user
if they wish to browse in the native app.

This CL stops the picker from appearing if the user is browsing within
the fullscreen PWA. It does not do so if the user is browsing the PWA
outside of the fullscreen standalone (i.e. launched from homescreen)
mode.

BUG= 647569 

Review-Url: https://codereview.chromium.org/2348853002
Cr-Commit-Position: refs/heads/master@{#419406}

[modify] https://crrev.com/671b9d029e9ead87a24fb38e5268dee3f4de7a96/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegate.java
[modify] https://crrev.com/671b9d029e9ead87a24fb38e5268dee3f4de7a96/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java
[modify] https://crrev.com/671b9d029e9ead87a24fb38e5268dee3f4de7a96/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java
[modify] https://crrev.com/671b9d029e9ead87a24fb38e5268dee3f4de7a96/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
[modify] https://crrev.com/671b9d029e9ead87a24fb38e5268dee3f4de7a96/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java

Comment 2 by dominickn@chromium.org, Sep 19 2016

Status: Fixed (was: Started)
►

Sign in to add a comment