New issue
Advanced search Search tips

Issue 647567 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature
Team-Security-UX

Blocking:
issue 647754



Sign in to add a comment

Add a histogram for every time the HTTP bad UI is shown

Project Member Reported by f...@chromium.org, Sep 16 2016

Issue description

We should add a histogram every time the HTTP bad UI is shown in the omnibox.
 

Comment 1 by f...@chromium.org, Sep 16 2016

Blocking: 647754

Comment 2 by est...@chromium.org, Oct 19 2016

Cc: elawrence@chromium.org
Eric, could you take this one?

The only tricky part about this is that we probably want to record the histogram at most once per main-frame navigation (like the console message), not every time the toolbar redraws.

We could simply record it inside ChromeSecurityStateModelClient::VisibleSSLStateChanged[1], where we do the console message. That would be a pretty simple approach, but it has the downside that we'd have to do a separate histogram for iOS, since iOS doesn't use ChromeSecurityStateModelClient but instead has its own IOSChromeSecurityStateModelClient.

An alternative would be that we could forward the ChromeSSMClient::VisibleSSLStateChanged and DidFinishNavigation calls on to SecurityStateModel, and record the histogram in SecurityStateModel (which is shared with iOS).

I'd be fine with either approach.

[1] https://cs.chromium.org/chromium/src/chrome/browser/ssl/chrome_security_state_model_client.cc?sq=package:chromium&l=308
Cc: -elawrence@chromium.org
Owner: elawrence@chromium.org
Status: started (was: Available)
Components: UI>Browser>Omnibox>SecurityIndicators
Labels: -Pri-3 Pri-2
https://codereview.chromium.org/2451293002
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 28 2016

Status: Fixed (was: Started)
Eric, could you add a link to where I'd go to see this metric?
Components: -Security>UX

Sign in to add a comment