Update security indicator UI methods to handle the new SecurityLevel [Desktop] |
|||||||
Issue descriptionToolbarModelImpl::GetSecureVerboseText, LocationBarView::ShouldShowSecurityChip, and LocationBarViewMac::ShouldShowSecurityState will all need to be updated to handle the new SecurityLevel for HTTP Bad. https://docs.google.com/document/d/1xno6g6OnA7strcyzE-o_drevW8L0Mb6ZBEkjsiwa6x0/edit#
,
Sep 16 2016
,
Oct 17 2016
,
Oct 17 2016
,
Oct 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de79182ad7338200103842786ab2260e3ab74df3 commit de79182ad7338200103842786ab2260e3ab74df3 Author: felt <felt@chromium.org> Date: Tue Oct 18 20:20:25 2016 Show HTTP-Bad security chip UI on Mac and Views This hooks up the HTTP_SHOW_WARNING state to the security chip in the omnibox on Mac and Views. (Note that this will only display if the #mark-non-secure-as flag is set, since the SecurityStateModel only emits HTTP_SHOW_WARNING when the flag is set appropriately.) BUG= 647562 Review-Url: https://codereview.chromium.org/2422303002 Cr-Commit-Position: refs/heads/master@{#426033} [modify] https://crrev.com/de79182ad7338200103842786ab2260e3ab74df3/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm [modify] https://crrev.com/de79182ad7338200103842786ab2260e3ab74df3/chrome/browser/ui/views/location_bar/location_bar_view.cc [modify] https://crrev.com/de79182ad7338200103842786ab2260e3ab74df3/components/toolbar/toolbar_model_impl.cc
,
Oct 19 2016
felt, anything else to do here or can we mark as Fixed?
,
Oct 26 2016
,
Oct 27 2016
,
Nov 30 2016
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by f...@chromium.org
, Sep 16 2016