New issue
Advanced search Search tips

Issue 647553 link

Starred by 3 users

Issue metadata

Status: Archived
Owner: ----
Closed: Sep 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Team-Security-UX



Sign in to add a comment

Move Page Info logic into a component

Project Member Reported by lgar...@chromium.org, Sep 16 2016

Issue description

It would be isolate some of `chrome/browser/ui/website_settings` while cleaning it up.
Quite a lot of it just computes strings and icons.
Putting it into a component can also make it easier to reuse logic across platforms.

Possibilities:

- Its own component.
- `components/security_state/` (Could be called SecurityStateView? :-P)
 
Note to self: felt@ offered to pair and explore the feasibility of componentizing.

Comment 2 by est...@chromium.org, Sep 16 2016

Is there page info code that's duplicated for iOS?
iOS doesn't have much Page Info to speak of. :-/

But yeah, the part that is there is implemented separately. We should at least use the same strings as on other platforms, provided by the same part of the code.
Components: UI>Browser>Omnibox>PageInfo
Components: -UI>Browser>Omnibox>PageInfo UI>Browser>Bubbles>PageInfo
Labels: -Hotlist-PageInfo
Components: -Security>UX

Comment 8 by est...@chromium.org, Nov 10 2017

Labels: Hotlist-EnamelAndFriendsFixIt

Comment 9 by est...@chromium.org, Feb 18 2018

Labels: -Hotlist-EnamelAndFriendsFixIt
Status: Archived (was: Available)
Archiving old bugs that haven't been actively assigned in over 180 days.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!

Sign in to add a comment