New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 647551 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
Team-Security-UX


Show other hotlists

Hotlists containing this issue:
EnamelAndFriendsFixIt


Sign in to add a comment

Page Info: permission icons should use vector sources

Project Member Reported by lgar...@chromium.org, Sep 16 2016

Issue description

Last change: https://codereview.chromium.org/2269513003

All the icons in that change should eventually be changed to vector icons to save space.
 
Blocking: 512442
Components: UI>Browser>Omnibox>PageInfo
Blocking: -512442
Components: -UI>Browser>Omnibox>PageInfo UI>Browser>Bubbles>PageInfo
Labels: -Hotlist-PageInfo
Components: -Security>UX

Comment 7 by est...@chromium.org, Jul 14 2017

Cc: helenepark@chromium.org maxwalker@chromium.org bettes@chromium.org
Labels: -Pri-3 -Hotlist-GoodFirstBug Pri-2
Owner: est...@chromium.org
Status: Started (was: Available)
I'm starting on this because it's a necessary first step for updating the badged appearance of the icons (and adding motion).

There are a few content settings that use different icons in the location bar and the bubble. These include
- location
- popups
- downloads ( bug 712533 )

Switching to vector icons also implies that we should be drawing these icons at a slightly smaller size (16x16, including internal padding) or else they'll look blurry due to bad pixel alignment. The only way around this is if a designer wants to hand-craft a larger version.

Other notes:
- the microphone icon from go/icons has a solid top bit, instead of horizontal grooves; I assume we want to treat the solid mic as canonical but if not we need a new svg
- the midi icon gets a bit blurrier; again, assuming we care, to fix this we'd need a hand crafted svg

Comment 8 by est...@chromium.org, Jul 14 2017

here's a visual comparison
ogcKbiVsrCs.png
139 KB View Download
Thanks!

I defer to maxwalker@. I don't feel strongly about anything as long as the icons are sharp both at 1x and HiDPI (e.g. 2x).

Max, do you have appropriate SVGs for Page Info resolution?
ping maxwalker to address the issues described in #7
friendly weekly ping of maxwalker
Cc: -maxwalker@chromium.org est...@chromium.org
Owner: maxwalker@chromium.org
Assign back to Evan when complete. Thanks!
Pinging this as well, since I ran into it as we work on implementing autoplay policy changes.
Blocking: 759129
Blocking: -759129
Labels: Hotlist-EnamelAndFriendsFixIt
Project Member

Comment 17 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c408bd3061c9e33e1ab0cf880bf4bbda6948381d

commit c408bd3061c9e33e1ab0cf880bf4bbda6948381d
Author: Patti <patricialor@chromium.org>
Date: Thu Jan 18 02:56:55 2018

Harmony/Desktop Page Info: Update icons from .png to .icon.

Use vectors for Page Info icons, which has the added benefit of being able to
programmatically generate the red 'x' badges on blocked permission icons.

This patch also renames a few icons to match the official naming for Material
Design icons.

Screenshots - https://drive.google.com/open?id=1ZhPw2apMGNr0e6ey86y_eTHzkywnL10i

Bug:  535074 ,  647551 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ic30d0d7269395312d77dcec3ac8a88617cf221ea
Reviewed-on: https://chromium-review.googlesource.com/778640
Commit-Queue: Patti <patricialor@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530031}
[modify] https://crrev.com/c408bd3061c9e33e1ab0cf880bf4bbda6948381d/chrome/app/vector_icons/BUILD.gn
[add] https://crrev.com/c408bd3061c9e33e1ab0cf880bf4bbda6948381d/chrome/app/vector_icons/ads.icon
[add] https://crrev.com/c408bd3061c9e33e1ab0cf880bf4bbda6948381d/chrome/app/vector_icons/launch.icon
[add] https://crrev.com/c408bd3061c9e33e1ab0cf880bf4bbda6948381d/chrome/app/vector_icons/page_info_content_paste.icon
[add] https://crrev.com/c408bd3061c9e33e1ab0cf880bf4bbda6948381d/chrome/app/vector_icons/photo.icon
[delete] https://crrev.com/d2e83f778ee04311b18b6a5ee5f5f5786d6d51ea/chrome/app/vector_icons/subresource_filter_active.icon
[add] https://crrev.com/c408bd3061c9e33e1ab0cf880bf4bbda6948381d/chrome/app/vector_icons/sync.icon
[add] https://crrev.com/c408bd3061c9e33e1ab0cf880bf4bbda6948381d/chrome/app/vector_icons/volume_up.icon
[modify] https://crrev.com/c408bd3061c9e33e1ab0cf880bf4bbda6948381d/chrome/browser/media/webrtc/media_stream_capture_indicator.cc
[modify] https://crrev.com/c408bd3061c9e33e1ab0cf880bf4bbda6948381d/chrome/browser/permissions/permission_request_impl.cc
[modify] https://crrev.com/c408bd3061c9e33e1ab0cf880bf4bbda6948381d/chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.mm
[modify] https://crrev.com/c408bd3061c9e33e1ab0cf880bf4bbda6948381d/chrome/browser/ui/content_settings/content_setting_image_model.cc
[modify] https://crrev.com/c408bd3061c9e33e1ab0cf880bf4bbda6948381d/chrome/browser/ui/page_info/page_info.cc
[modify] https://crrev.com/c408bd3061c9e33e1ab0cf880bf4bbda6948381d/chrome/browser/ui/page_info/page_info.h
[modify] https://crrev.com/c408bd3061c9e33e1ab0cf880bf4bbda6948381d/chrome/browser/ui/page_info/page_info_ui.cc
[modify] https://crrev.com/c408bd3061c9e33e1ab0cf880bf4bbda6948381d/chrome/browser/ui/page_info/page_info_ui.h
[modify] https://crrev.com/c408bd3061c9e33e1ab0cf880bf4bbda6948381d/chrome/browser/ui/views/page_info/chosen_object_view.cc
[modify] https://crrev.com/c408bd3061c9e33e1ab0cf880bf4bbda6948381d/chrome/browser/ui/views/page_info/page_info_bubble_view.cc
[modify] https://crrev.com/c408bd3061c9e33e1ab0cf880bf4bbda6948381d/chrome/browser/ui/views/page_info/permission_selector_row.cc
[modify] https://crrev.com/c408bd3061c9e33e1ab0cf880bf4bbda6948381d/chrome/browser/vr/elements/audio_permission_prompt_texture.cc
[modify] https://crrev.com/c408bd3061c9e33e1ab0cf880bf4bbda6948381d/chrome/browser/vr/elements/disc_button_unittest.cc
[modify] https://crrev.com/c408bd3061c9e33e1ab0cf880bf4bbda6948381d/chrome/browser/vr/ui_scene_creator.cc
[modify] https://crrev.com/c408bd3061c9e33e1ab0cf880bf4bbda6948381d/components/vector_icons/BUILD.gn
[rename] https://crrev.com/c408bd3061c9e33e1ab0cf880bf4bbda6948381d/components/vector_icons/mic.icon

Project Member

Comment 18 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b4db5b6b1524977bc7b2d9449620f44d267a916

commit 3b4db5b6b1524977bc7b2d9449620f44d267a916
Author: Patti <patricialor@chromium.org>
Date: Fri Jan 19 00:24:33 2018

Page Info Desktop: Delete now-unused .png permission icons.

r530031 converted all the icons used in Page Info to vectors. Delete all the
unused permissions icons that were previously used.

Bug:  535074 ,  647551 
Change-Id: Ic4e6648f61751ffa16a7afeb6f61f8a9088cdd3b
Reviewed-on: https://chromium-review.googlesource.com/872471
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Patti <patricialor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530355}
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_100_percent/common/allowed_ads.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_100_percent/common/allowed_background_sync.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_100_percent/common/allowed_camera.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_100_percent/common/allowed_clipboard.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_100_percent/common/allowed_downloads.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_100_percent/common/allowed_images.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_100_percent/common/allowed_location.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_100_percent/common/allowed_mic.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_100_percent/common/allowed_notifications.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_100_percent/common/allowed_plugins.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_100_percent/common/allowed_popups.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_100_percent/common/allowed_script.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_100_percent/common/allowed_sound.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_100_percent/common/allowed_usb.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_100_percent/common/blocked_ads.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_100_percent/common/blocked_background_sync.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_100_percent/common/blocked_clipboard.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_100_percent/common/blocked_cookies.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_100_percent/common/blocked_downloads.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_100_percent/common/blocked_images.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_100_percent/common/blocked_location.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_100_percent/common/blocked_mic.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_100_percent/common/blocked_midi.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_100_percent/common/blocked_notifications.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_100_percent/common/blocked_plugins.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_100_percent/common/blocked_script.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_100_percent/common/blocked_sound.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_100_percent/common/blocked_usb.png
[rename] https://crrev.com/3b4db5b6b1524977bc7b2d9449620f44d267a916/chrome/app/theme/default_100_percent/common/cookies.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_200_percent/common/allowed_ads.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_200_percent/common/allowed_background_sync.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_200_percent/common/allowed_camera.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_200_percent/common/allowed_clipboard.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_200_percent/common/allowed_downloads.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_200_percent/common/allowed_images.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_200_percent/common/allowed_location.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_200_percent/common/allowed_mic.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_200_percent/common/allowed_notifications.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_200_percent/common/allowed_plugins.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_200_percent/common/allowed_popups.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_200_percent/common/allowed_script.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_200_percent/common/allowed_sound.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_200_percent/common/allowed_usb.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_200_percent/common/blocked_ads.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_200_percent/common/blocked_background_sync.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_200_percent/common/blocked_clipboard.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_200_percent/common/blocked_cookies.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_200_percent/common/blocked_downloads.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_200_percent/common/blocked_images.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_200_percent/common/blocked_location.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_200_percent/common/blocked_mic.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_200_percent/common/blocked_midi.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_200_percent/common/blocked_notifications.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_200_percent/common/blocked_plugins.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_200_percent/common/blocked_script.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_200_percent/common/blocked_sound.png
[delete] https://crrev.com/501d93e2ee023017c8b519961b9d6c991b04cc43/chrome/app/theme/default_200_percent/common/blocked_usb.png
[rename] https://crrev.com/3b4db5b6b1524977bc7b2d9449620f44d267a916/chrome/app/theme/default_200_percent/common/cookies.png
[modify] https://crrev.com/3b4db5b6b1524977bc7b2d9449620f44d267a916/chrome/app/theme/theme_resources.grd
[modify] https://crrev.com/3b4db5b6b1524977bc7b2d9449620f44d267a916/chrome/browser/browsing_data/cookies_tree_model.cc

Cc: maxwalker@chromium.org
Owner: patricia...@chromium.org
Status: Fixed (was: Started)

Sign in to add a comment