New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 647531 link

Starred by 2 users
Status: Fixed
Owner:
mcasas@chromium.org
Closed: Sep 2016
Cc:
█ lunalu@chromium.org
mcasas@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Use IsWebcamAvailableOnSystem in Image Capture browser test

Project Member Reported by mcasas@chromium.org, Sep 16 2016 
Use the new browser_test_utils.cc:IsWebcamAvailableOnSystem(),
introduced in  https://crbug.com/509735 , instead of
image_capture_test.html::checkForVideoDevices() [1]


[1] https://cs.chromium.org/chromium/src/content/test/data/media/image_capture_test.html?q=image_capture_test+checkforvideodevices&sq=package:chromium&l=12&dr=C
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2be0f67dbdb1f6da85fa5d4ca116daffe7da662a

commit 2be0f67dbdb1f6da85fa5d4ca116daffe7da662a
Author: mcasas <mcasas@chromium.org>
Date: Tue Sep 20 04:07:08 2016

ImageCapture browser tests: use IsWebcamAvailableOnSystem()

This CL nukes the image_capture_test.html's checkForVideoDevices()
and instead uses the newly introduced IsWebcamAvailableOnSystem()
from browser_test_utils.

BUG= 647531 
TEST=content_browsertests WebRtcImageCaptureBrowserTest working as before.

Review-Url: https://codereview.chromium.org/2341643006
Cr-Commit-Position: refs/heads/master@{#419675}

[modify] https://crrev.com/2be0f67dbdb1f6da85fa5d4ca116daffe7da662a/content/browser/webrtc/webrtc_image_capture_browsertest.cc
[modify] https://crrev.com/2be0f67dbdb1f6da85fa5d4ca116daffe7da662a/content/browser/webrtc/webrtc_webcam_browsertest.cc
[modify] https://crrev.com/2be0f67dbdb1f6da85fa5d4ca116daffe7da662a/content/test/data/media/image_capture_test.html

Comment 2 by mcasas@chromium.org, Sep 20 2016

Status: Fixed (was: Started)

Comment 3 by sshru...@google.com, Nov 23 2016

Components: -Blink>MediaStream>ImageCapture Blink>ImageCapture
►

Sign in to add a comment