New issue
Advanced search Search tips

Issue 647523 link

Starred by 2 users
Status: Fixed
Owner:
ellyjo...@chromium.org
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Harmony [Mac] - uneditable textfield with text selection should beep when typed at

Project Member Reported by shrike@chromium.org, Sep 16 2016 
Version: 55.0.2861.0
OS: 10.11

What steps will reproduce the problem?
(1) Create a new tab and search for something so that you wind up on a Google search results page
(2) Click lock icon to bring up OIB
(3) Click cookies link
(4) Expand www.google.com > Cookies in the list and select DV
(5) Select www.google.com in the Domain textfield below
(6) Press some keys on the keyboard

What is the expected output?
I expect to hear beeps, indicating that the text I'm typing is not being accepted

What do you see instead?
I hear nothing.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7da74b7ca322b813d757e0c050aa7fd479ee278

commit c7da74b7ca322b813d757e0c050aa7fd479ee278
Author: ellyjones <ellyjones@chromium.org>
Date: Mon Sep 19 16:10:33 2016

views: provide feedback when editing fails

If a user selects text in a readonly textfield, all editing operations
will silently fail. This change adds a new callback, Textfield::OnKeypressUnhandled,
which serves to provide feedback in this case. Currently feedback is only
implemented for Mac in the form of a system error beep.

BUG= 647523 

Review-Url: https://codereview.chromium.org/2342343003
Cr-Commit-Position: refs/heads/master@{#419473}

[modify] https://crrev.com/c7da74b7ca322b813d757e0c050aa7fd479ee278/ui/views/controls/textfield/textfield.cc
[modify] https://crrev.com/c7da74b7ca322b813d757e0c050aa7fd479ee278/ui/views/controls/textfield/textfield.h
[modify] https://crrev.com/c7da74b7ca322b813d757e0c050aa7fd479ee278/ui/views/style/platform_style.cc
[modify] https://crrev.com/c7da74b7ca322b813d757e0c050aa7fd479ee278/ui/views/style/platform_style.h
[modify] https://crrev.com/c7da74b7ca322b813d757e0c050aa7fd479ee278/ui/views/style/platform_style_mac.mm

Comment 2 by shrike@chromium.org, Oct 1 2016

Labels: Proj-HarmonyControls

Comment 3 by ellyjo...@chromium.org, Oct 6 2016

Status: Fixed (was: Assigned)
This was implemented by the CL in #1. Uneditable textfields (I used the one in views_examples_with_content_exe to test) beep when you try to type in them.
►

Sign in to add a comment