New issue
Advanced search Search tips

Issue 647515 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug

Blocking:
issue 630357



Sign in to add a comment

Harmony - invisible focus loop items on cookies dialog

Project Member Reported by shrike@chromium.org, Sep 16 2016

Issue description

Version: 55.0.2861.0
OS: 10.11

What steps will reproduce the problem?
(1) Click lock icon to bring up OIB
(2) Click cookies link
(3) With tab focus active, start tabbing around

What is the expected output?
Each tab should highlight a new control in the focus loop.

What do you see instead?
After the close box, the next two controls, whatever they are, are not highlighted.

 
Cc: ellyjo...@chromium.org
Owner: karandeepb@chromium.org
karandeepb@, can you take a look at this please?
So I looked at this. The focus chain order is->

-The Close button at the bottom right
-The Close icon button at the top right.
- The Tabbed pane
- The TreeView
- Block Button
- Remove Button
- Cookie data labels (if some cookie data is selected). This is a bug since Labels shouldn't get focus. This is probably because these labels are implemented as Textfields in order to be selectable. A SetFocusBehavior(FocusBehavior::NEVER) should be enough to fix this. Related -  http://crbug.com/649005 .

I think in the bug report "the next two controls" probably refer to the TabbedPane and the TreeView.

The TabbedPane does not paint any focus border. Also, the TreeView only paints a focus border around the selected node. So if it has no nodes, no focus indication is given. 

These should be pretty easy to fix. I don't generally make UI changes, so ellyjones@ can you guide me regarding the process to follow - is there any spec to follow etc? Or if you wish you can take up the issue from here.

Comment 3 by shrike@chromium.org, Sep 23 2016

Labels: Proj-MaterialDesign-NativeUI
Ping ellyjones@ regarding c#2.
Cc: -ellyjo...@chromium.org karandeepb@chromium.org
Owner: ellyjo...@chromium.org
Re #2:

* TabbedPane will shortly paint a focus border on the selected tab when it has keyboard focus, to make it clear that it  has keyboard focus. I own this bug.
* TreeView should have a focus ring on the whole control. Not a very difficult fix.

I'll take this bug back and make these UI changes.
Labels: -M-55 Proj-HarmonyControls M-56
Status: Started (was: Assigned)
The TabbedPane focus problem will be resolved by https://codereview.chromium.org/2368283002/

TreeView having a focus ring turns out to be slightly tricky, because TreeView is sometimes contained in a ScrollView and it's the ScrollView that should have the focus ring. Will put up a CL for that today or tomorrow.
Cocoa treeview screenshot
Screen Shot 2016-10-12 at 7.57.55 AM.png
27.7 KB View Download
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8cbab2b4e38a3eeb48d76f7cf839d18d6a0fc433

commit 8cbab2b4e38a3eeb48d76f7cf839d18d6a0fc433
Author: ellyjones <ellyjones@chromium.org>
Date: Mon Oct 17 12:21:42 2016

views: add focus ring to TreeView

When TreeView is focused, there should be a focus ring around the control,
at least on Mac. This is mildly complicated because TreeViews are often
hosted in a ScrollView, and in that case the focus ring should go around
the ScrollView instead of the TreeView so the focus ring does not scroll.

BUG=605589, 647515 

Review-Url: https://codereview.chromium.org/2411693002
Cr-Commit-Position: refs/heads/master@{#425662}

[modify] https://crrev.com/8cbab2b4e38a3eeb48d76f7cf839d18d6a0fc433/ui/views/controls/focus_ring.cc
[modify] https://crrev.com/8cbab2b4e38a3eeb48d76f7cf839d18d6a0fc433/ui/views/controls/focus_ring.h
[modify] https://crrev.com/8cbab2b4e38a3eeb48d76f7cf839d18d6a0fc433/ui/views/controls/scroll_view.cc
[modify] https://crrev.com/8cbab2b4e38a3eeb48d76f7cf839d18d6a0fc433/ui/views/controls/scroll_view.h
[modify] https://crrev.com/8cbab2b4e38a3eeb48d76f7cf839d18d6a0fc433/ui/views/controls/tree/tree_view.cc
[modify] https://crrev.com/8cbab2b4e38a3eeb48d76f7cf839d18d6a0fc433/ui/views/controls/tree/tree_view.h
[modify] https://crrev.com/8cbab2b4e38a3eeb48d76f7cf839d18d6a0fc433/ui/views/style/platform_style.cc
[modify] https://crrev.com/8cbab2b4e38a3eeb48d76f7cf839d18d6a0fc433/ui/views/style/platform_style.h
[modify] https://crrev.com/8cbab2b4e38a3eeb48d76f7cf839d18d6a0fc433/ui/views/style/platform_style_mac.mm

Status: Fixed (was: Started)

Sign in to add a comment