New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 647510 link

Starred by 1 user
Status: Archived
Owner: ----
Closed: Jan 10
Cc:
sadrul@chromium.org
█ hubbe@chromium.org
sky@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

mus clients should receive the ICCProfile from the window server

Project Member Reported by sadrul@chromium.org, Sep 16 2016 
Instead of getting the ICCProfile from the native system (https://cs.chromium.org/chromium/src/ui/aura/window_tree_host.cc?sq=package:chromium&dr=CSs&l=76), mus clients should get it from the mus window server (through WindowTreeClient: https://cs.chromium.org/chromium/src/services/ui/public/cpp/window_manager_delegate.h?l=42). This is because the mus clients will generally be sandboxed, and will be unable to communicate with the native platform.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a384b41d38cbab98d445c4ee205756a8f7a29f1c

commit a384b41d38cbab98d445c4ee205756a8f7a29f1c
Author: sadrul <sadrul@chromium.org>
Date: Mon Sep 19 02:15:23 2016

aura: Allow platform to choose how it retrieves ICCProfile.

In mus, the client should get the ICCProfile from the mus server,
instead of from the native platform. So get the ICCProfile from
a virtual function so that the platform can override it.

BUG= 647510 

Review-Url: https://codereview.chromium.org/2345283002
Cr-Commit-Position: refs/heads/master@{#419410}

[modify] https://crrev.com/a384b41d38cbab98d445c4ee205756a8f7a29f1c/ui/aura/window_tree_host.cc
[modify] https://crrev.com/a384b41d38cbab98d445c4ee205756a8f7a29f1c/ui/aura/window_tree_host.h
[modify] https://crrev.com/a384b41d38cbab98d445c4ee205756a8f7a29f1c/ui/views/mus/window_tree_host_mus.cc
[modify] https://crrev.com/a384b41d38cbab98d445c4ee205756a8f7a29f1c/ui/views/mus/window_tree_host_mus.h
Project Member

Comment 2 by sheriffbot@chromium.org, Sep 19 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by benhenry@google.com, Jan 10

Status: Archived (was: Untriaged)
Archiving P3s older than 1 year with no owner or component.
►

Sign in to add a comment