New issue
Advanced search Search tips

Issue 647509 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Sep 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 647512



Sign in to add a comment

WindowTree::DeleteWindow should unembed if passed the embed root

Project Member Reported by sky@chromium.org, Sep 16 2016

Issue description

Clients currently don't have a way to remove an embed root. Mus should treat a DeleteWindow() call on an embed root as a request to remove the embedding. From the clients perspective this has the effect of deleting the window.
 

Comment 1 by sky@chromium.org, Sep 16 2016

Blocking: 647512

Comment 2 by sky@chromium.org, Sep 16 2016

Owner: sky@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb1b5cd67a3b5459cde2950c037776f88f9776e3

commit bb1b5cd67a3b5459cde2950c037776f88f9776e3
Author: sky <sky@chromium.org>
Date: Sun Sep 18 17:27:23 2016

Makes WindowTree::DeleteWindow() unembed for roots

Currently DeleteWindow() is (mostly) ignored if the client doesn't own
the root. This change allows the client to call delete on a root and
it's treated as unembedded the client from that root.

BUG= 647509 
TEST=covered by tests
R=sadrul@chromium.org

Review-Url: https://codereview.chromium.org/2349003002
Cr-Commit-Position: refs/heads/master@{#419401}

[modify] https://crrev.com/bb1b5cd67a3b5459cde2950c037776f88f9776e3/services/ui/public/interfaces/window_tree.mojom
[modify] https://crrev.com/bb1b5cd67a3b5459cde2950c037776f88f9776e3/services/ui/ws/server_window.cc
[modify] https://crrev.com/bb1b5cd67a3b5459cde2950c037776f88f9776e3/services/ui/ws/server_window.h
[modify] https://crrev.com/bb1b5cd67a3b5459cde2950c037776f88f9776e3/services/ui/ws/server_window_observer.h
[modify] https://crrev.com/bb1b5cd67a3b5459cde2950c037776f88f9776e3/services/ui/ws/window_server.cc
[modify] https://crrev.com/bb1b5cd67a3b5459cde2950c037776f88f9776e3/services/ui/ws/window_server.h
[modify] https://crrev.com/bb1b5cd67a3b5459cde2950c037776f88f9776e3/services/ui/ws/window_tree.cc
[modify] https://crrev.com/bb1b5cd67a3b5459cde2950c037776f88f9776e3/services/ui/ws/window_tree.h
[modify] https://crrev.com/bb1b5cd67a3b5459cde2950c037776f88f9776e3/services/ui/ws/window_tree_client_unittest.cc

Comment 4 by sky@chromium.org, Sep 19 2016

Status: Fixed (was: Started)

Comment 5 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55

Comment 6 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 7 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 8 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 9 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 10 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 12 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment