New issue
Advanced search Search tips

Issue 647500 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug

Blocking:
issue 533189



Sign in to add a comment

On Mac, characteristicvaluechanged is triggered on write response

Reported by emil.len...@gmail.com, Sep 15 2016

Issue description

Chrome Version       : 55.0.2861.0 canary on Mac OS X

What steps will reproduce the problem?
(1) Connect to a BLE device and enable notifications for some characteristic
(2) Send some notification from the peripheral on that characteristic
(3) Write something to that characteristic

What is the expected result?
No notification event is fired after the characteristic has been written

What happens instead?
A notification event is fired when the write response is received containing the last notified value (not the value last written)

Please provide any additional information below. Attach a screenshot if
possible.

I guess it's just to remove the line https://chromium.googlesource.com/chromium/src.git/+/73e0d4d0673f5b84699da8e4b07bd40ef7c83fce/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.mm#309
 

Comment 1 by ortuno@chromium.org, Sep 16 2016

Just to be sure, step two has nothing to do with the bug correct? The problem is that events are being fired for write requests?

Comment 2 by ortuno@chromium.org, Sep 16 2016

Blocking: 533189
Labels: OS-Mac
Status: Available (was: Unconfirmed)
Correct

Comment 4 by jlebel@chromium.org, Sep 21 2016

Owner: jlebel@chromium.org
Status: Started (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0405e3b684cf2cddeadacbe13c035a3eb0bdd80d

commit 0405e3b684cf2cddeadacbe13c035a3eb0bdd80d
Author: jlebel <jlebel@chromium.org>
Date: Wed Oct 05 23:33:40 2016

Bluetooth: mac: When a characteristic is written, a gatt characteristic value changed notification is send.
This notification should not be sent since.

BUG= 647500 

Review-Url: https://codereview.chromium.org/2357993002
Cr-Commit-Position: refs/heads/master@{#423337}

[modify] https://crrev.com/0405e3b684cf2cddeadacbe13c035a3eb0bdd80d/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.mm
[modify] https://crrev.com/0405e3b684cf2cddeadacbe13c035a3eb0bdd80d/device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc

Status: Fixed (was: Started)
Fixed in Chrome 56.0.2886.0 (Official Build) canary (64-bit)



Project Member

Comment 7 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0405e3b684cf2cddeadacbe13c035a3eb0bdd80d

commit 0405e3b684cf2cddeadacbe13c035a3eb0bdd80d
Author: jlebel <jlebel@chromium.org>
Date: Wed Oct 05 23:33:40 2016

Bluetooth: mac: When a characteristic is written, a gatt characteristic value changed notification is send.
This notification should not be sent since.

BUG= 647500 

Review-Url: https://codereview.chromium.org/2357993002
Cr-Commit-Position: refs/heads/master@{#423337}

[modify] https://crrev.com/0405e3b684cf2cddeadacbe13c035a3eb0bdd80d/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.mm
[modify] https://crrev.com/0405e3b684cf2cddeadacbe13c035a3eb0bdd80d/device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc

Comment 8 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840

Sign in to add a comment