Presubmit incorrectly enforces css --vars sorting. |
||
Issue descriptionThe sorted requirement was added to the presubmit at a time when --vars didn't exist. So the impact on --vars wasn't considered. The sorting had two objectives: easier scan-ability of the code (for humans); and identifying duplicate entries (human mistakes). Trying to keep the vars sorted is leading to workarounds. It will be better to change how presubmit works to remove the sorted requirement, hopefully while keeping the duplicate entry feature.
,
Sep 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2cc1577903139bfb611a87973a6aca648ea2675d commit 2cc1577903139bfb611a87973a6aca648ea2675d Author: dbeam <dbeam@chromium.org> Date: Thu Sep 22 19:54:39 2016 web_dev_style: ignore --css-vars from alphabetical ordering requirement R=dschuyler@chromium.org,stevenjb@chromium.org BUG= 647491 NOTRY=true Review-Url: https://codereview.chromium.org/2345703004 Cr-Commit-Position: refs/heads/master@{#420434} [modify] https://crrev.com/2cc1577903139bfb611a87973a6aca648ea2675d/chrome/browser/web_dev_style/css_checker.py [modify] https://crrev.com/2cc1577903139bfb611a87973a6aca648ea2675d/chrome/browser/web_dev_style/css_checker_test.py
,
Sep 22 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by dbeam@chromium.org
, Sep 15 2016Owner: dbeam@chromium.org
Status: Started (was: Untriaged)