New issue
Advanced search Search tips

Issue 647491 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Presubmit incorrectly enforces css --vars sorting.

Project Member Reported by dschuyler@chromium.org, Sep 15 2016

Issue description

The sorted requirement was added to the presubmit at a time when --vars didn't exist. So the impact on --vars wasn't considered. The sorting had 
two objectives: easier scan-ability of the code (for humans); and 
identifying duplicate entries (human mistakes). 

Trying to keep the vars sorted is leading to workarounds. It will be better to change how presubmit works to remove the sorted requirement, hopefully while keeping the duplicate entry feature.

 

Comment 1 by dbeam@chromium.org, Sep 15 2016

Cc: steve...@chromium.org
Owner: dbeam@chromium.org
Status: Started (was: Untriaged)
part 1 (dbeam): ignoring for sort order
https://codereview.chromium.org/2345703004/

part 2 (dschuyler?): checking for duplicate definitions in the same block?
this isn't done yet and is lower priority, IMO

Comment 3 by dbeam@chromium.org, Sep 22 2016

Status: Fixed (was: Started)

Sign in to add a comment