Issue metadata
Sign in to add a comment
|
MD Settings: Search bubbles clipped by card boundary |
||||||||||||||||||||||
Issue description
,
Sep 21 2016
,
Sep 21 2016
I've started investigating this. Will update with any progress.
,
Sep 21 2016
@michaelpg: Commenting out a single line from the original CL seems to fix the issue, but I am not sure if it introduces other problems, see https://codereview.chromium.org/2365453002.
,
Sep 22 2016
#4: as the comment mentions, this causes a sub-page to continue showing out side the bounds of the card when navigating from a sub-page back to the main page
,
Sep 22 2016
I'd suggesting walking up the offsetParent stack and figuring out where the stacking contexts are, see if you can add a position/z-index somewhere to allow the bubble to show outside the card.
,
Sep 22 2016
Here is a different attempt that is promising, https://codereview.chromium.org/2365453002/diff/20001/chrome/browser/resources/settings/settings_page/settings_section.html. This also fixes https://bugs.chromium.org/p/chromium/issues/detail?id=649174, but I think there is a different kind of flashing noticeable for a split of a second.
,
Sep 22 2016
#7: yeah, that flashing is what the position: relative was intended to fix, I think. I've attributed issue 649174 to a Blink commit, so it'll be interesting to see if the bug is in Blink (or if Blink fixed a bug that was hiding a bug in settings).
,
Oct 18 2016
,
Oct 18 2016
,
Nov 2 2016
yo what's the status on this or downstream issues?
,
Nov 3 2016
@dbeam: I have not revisited this, since it still seems blocked on issue 649174 . Per comment #4 there is a single line fix for the clipping at https://codereview.chromium.org/2365453002, but my understanding is that it interferes with issue 649174 .
,
Nov 3 2016
dpapad@: have you tried adding a flex-basis: auto; to address what cbiesinger@ mentioned is an issue?
,
Nov 3 2016
No have not tried this yet. Will do and report back.
,
Nov 3 2016
Tried adding flex-basis: auto; on .card CSS class, did not notice any difference. At this point my suggestion is to go with https://codereview.chromium.org/2365453002, because it fixes two very noticeable bugs, 1) Exiting subpage animation goes to 0 height ( issue 649174 ) 2) Search bubbles clipped by card boundary. (this bug). at the expense of at the expense of introducing a less noticeable bug (briefly flashing card contents when exiting a subpage), which I don't consider a dev blocker, unlike 1 and 2.
,
Nov 3 2016
dpapad@: actually, I just noticed this morning that paper-tooltips (i.e. controlled by indicators) also get clipped :(
,
Nov 3 2016
i think only clipping overflow while expanding/collapsing is theoretically correct (where https://codereview.chromium.org/2365453002 lands us) i understand that the faint flicker is related, but i think it's a bug in blink and it's fairly hard to see. either way, i'm hoping most people wont notice and we can go to dev without that fix. we'll see.
,
Nov 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8c4965f69d6de2d3c4ed9c6cd5b2ccbee1667cad commit 8c4965f69d6de2d3c4ed9c6cd5b2ccbee1667cad Author: dpapad <dpapad@chromium.org> Date: Wed Nov 09 01:47:10 2016 MD Settings: Fix clipping of search bubbles by card boundary. This patch also seems to address the case where a settings card is briefly animated to a 0px height after exiting an animation. BUG= 647487 , 649174 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2365453002 Cr-Commit-Position: refs/heads/master@{#430816} [modify] https://crrev.com/8c4965f69d6de2d3c4ed9c6cd5b2ccbee1667cad/chrome/browser/resources/settings/settings_main/settings_main.html [modify] https://crrev.com/8c4965f69d6de2d3c4ed9c6cd5b2ccbee1667cad/chrome/browser/resources/settings/settings_main/settings_main.js [modify] https://crrev.com/8c4965f69d6de2d3c4ed9c6cd5b2ccbee1667cad/chrome/browser/resources/settings/settings_page/settings_section.html
,
Nov 9 2016
,
Nov 15 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by tbuck...@chromium.org
, Sep 19 2016Labels: Hotlist-MD-Settings-SearchBox
Status: Available (was: Untriaged)