New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 647441 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocked on:
issue 659675
issue 659677
issue 659679
issue 659803

Blocking:
issue 578833



Sign in to add a comment

Implement RemotePlayback.prompt()

Project Member Reported by avayvod@chromium.org, Sep 15 2016

Issue description

The current implementation still uses connect() and doesn't implement many steps of the new algorithm (like steps 3-5, 8-9 and 11-12):

https://w3c.github.io/remote-playback/#prompt-user-for-changing-remote-playback-statee
 
Blocking: 578833
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e1ec531a7d344a79e4a9ab24644c10f7dde475f

commit 0e1ec531a7d344a79e4a9ab24644c10f7dde475f
Author: avayvod <avayvod@chromium.org>
Date: Wed Sep 28 03:21:59 2016

[Blink, RemotePlayback] Added the disableRemotePlayback check to prompt().

BUG= 647441 
TEST=avayvod.github.io/remote-playback/test.html and a layout test

Review-Url: https://codereview.chromium.org/2348703002
Cr-Commit-Position: refs/heads/master@{#421436}

[add] https://crrev.com/0e1ec531a7d344a79e4a9ab24644c10f7dde475f/third_party/WebKit/LayoutTests/media/remoteplayback/disable-remote-playback-prompt-throws.html
[modify] https://crrev.com/0e1ec531a7d344a79e4a9ab24644c10f7dde475f/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp

Cc: ranjitkan@chromium.org
Labels: Needs-Feedback
Could someone please help us with steps to validate the issue if required.

Thanks!
I have a test page at avayvod.github.io/remote-playback/test.html.
The bug is about implementing a part of the Web API, not sure what manual verification is usually done for those.
The full API is still experimental and is planned to be ready to ship in M56.
Labels: -Needs-Feedback
avayvod@, Thank you for the update.
Labels: -M-55 M-56
Blockedon: 659675
Blockedon: 659677
Blockedon: 659679
Blockedon: 659803
Labels: -merge-merged-2840
I don't think anything was merged anywhere.
Labels: -RemotePlaybackAPI RemotePlayback
Status: Fixed (was: Started)

Sign in to add a comment