New issue
Advanced search Search tips

Issue 647438 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Mash needs to support magnifier mode

Project Member Reported by sky@chromium.org, Sep 15 2016

Issue description

See ash/magnifier. This likely needs changes in mus as well.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56ce72b787bcd211e206ec4d49bb06f07590ca3f

commit 56ce72b787bcd211e206ec4d49bb06f07590ca3f
Author: sky <sky@chromium.org>
Date: Mon Feb 27 19:07:06 2017

chromeos: makes more tests run in both mash and ash

BUG= 693114 , 581462 ,647438, 695628 , 695629 , 695632 ,695640, 695686 , 695751 ,695758, 695887 , 696006 , 696028 
TEST=test only changes
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2718763003
Cr-Commit-Position: refs/heads/master@{#453280}

[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/BUILD.gn
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/metrics/desktop_task_switch_metric_recorder_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/metrics/user_metrics_recorder_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/root_window_controller_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/screen_util_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/shelf/shelf_view_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/shell_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/sticky_keys/sticky_keys_overlay_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/system/chromeos/power/tablet_power_button_controller_unittest.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56ce72b787bcd211e206ec4d49bb06f07590ca3f

commit 56ce72b787bcd211e206ec4d49bb06f07590ca3f
Author: sky <sky@chromium.org>
Date: Mon Feb 27 19:07:06 2017

chromeos: makes more tests run in both mash and ash

BUG= 693114 , 581462 ,647438, 695628 , 695629 , 695632 ,695640, 695686 , 695751 ,695758, 695887 , 696006 , 696028 
TEST=test only changes
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2718763003
Cr-Commit-Position: refs/heads/master@{#453280}

[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/BUILD.gn
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/metrics/desktop_task_switch_metric_recorder_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/metrics/user_metrics_recorder_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/root_window_controller_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/screen_util_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/shelf/shelf_view_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/shell_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/sticky_keys/sticky_keys_overlay_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/system/chromeos/power/tablet_power_button_controller_unittest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56ce72b787bcd211e206ec4d49bb06f07590ca3f

commit 56ce72b787bcd211e206ec4d49bb06f07590ca3f
Author: sky <sky@chromium.org>
Date: Mon Feb 27 19:07:06 2017

chromeos: makes more tests run in both mash and ash

BUG= 693114 , 581462 ,647438, 695628 , 695629 , 695632 ,695640, 695686 , 695751 ,695758, 695887 , 696006 , 696028 
TEST=test only changes
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2718763003
Cr-Commit-Position: refs/heads/master@{#453280}

[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/BUILD.gn
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/metrics/desktop_task_switch_metric_recorder_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/metrics/user_metrics_recorder_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/root_window_controller_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/screen_util_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/shelf/shelf_view_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/shell_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/sticky_keys/sticky_keys_overlay_unittest.cc
[modify] https://crrev.com/56ce72b787bcd211e206ec4d49bb06f07590ca3f/ash/system/chromeos/power/tablet_power_button_controller_unittest.cc

Components: Internals>Services>Ash
Labels: -Proj-Mustash-Mash
Labels: -Proj-Mustash-Mus Proj-Mustash
Migrating Proj-Mustash-Mus to components Internals>Services>WindowService and Internals>Services>Ash

Labels: -Pri-3 -Proj-Mustash Proj-Mash-MultiProcess Proj-Mash-SingleProcess Pri-1
Status: Available (was: Untriaged)
It's not clear to me if we need changes for SingleProcessMash.
Labels: -Proj-Mash-SingleProcess
Magnifier seems to work OK with SingleProcessMash.

Sign in to add a comment