New issue
Advanced search Search tips

Issue 647426 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

Get IS_RELEASE_BRANCH from the ge_build_config template.

Project Member Reported by nxia@chromium.org, Sep 15 2016

Issue description

Set IS_RELEASE_BRANCH by parsing the ge_build_config.json file.
 

Comment 1 by nxia@chromium.org, Sep 20 2016

Owner: dgarr...@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/b8c1ddd25653188c07df1e0840ea5246909562e6

commit b8c1ddd25653188c07df1e0840ea5246909562e6
Author: Don Garrett <dgarrett@google.com>
Date: Tue Sep 20 02:30:04 2016

chromeos_config: Use an instance of HWTestList.

HWTestList contains a bunch of class methods for defining HWTests
values. This CL converts those into member variables, and creates an
instance of HWTestList which is passed to the methods which need it.

This has no meaningful effect, but a later change will set values on
the new HWTestList instance which will change the tests generated.

BUG= chromium:647426 
TEST=run_tests

Change-Id: I70d70917a10ed7459d1784fa9b3678c22106018c
Reviewed-on: https://chromium-review.googlesource.com/387268
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/b8c1ddd25653188c07df1e0840ea5246909562e6/cbuildbot/chromeos_config.py

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/2d823fa4b41777297f3708c69e9ea23e6c7ecdbc

commit 2d823fa4b41777297f3708c69e9ea23e6c7ecdbc
Author: Don Garrett <dgarrett@google.com>
Date: Tue Sep 20 02:24:57 2016

chromeos_config: Discover IS_RELEASE_CHANNEL.

IS_RELEASE_CHANNEL was a global variable in chromeos_config that had to
be manually updated whenever a new release branch was created. It will
now automatically discover the correct value based on data sent to use
from GE.

BUG= chromium:647426 
TEST=run_tests

Change-Id: I9c23dc51563c61353b27bb0fec2d31a8d55c16eb
Reviewed-on: https://chromium-review.googlesource.com/387269
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/2d823fa4b41777297f3708c69e9ea23e6c7ecdbc/cbuildbot/config_lib.py
[modify] https://crrev.com/2d823fa4b41777297f3708c69e9ea23e6c7ecdbc/cbuildbot/chromeos_config_unittest.py
[modify] https://crrev.com/2d823fa4b41777297f3708c69e9ea23e6c7ecdbc/cbuildbot/chromeos_config.py

Status: Fixed (was: Started)

Comment 6 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 7 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 8 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 9 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment