Media Remoting: Add seek/CancelInFlightData optimization. |
||||
Issue descriptionIn a recent code review (https://codereview.chromium.org/2310753002), we noted that CancelInFlightData() can't simply auto-ACK (i.e., cancel) all in-flight frames in the CastTransport. It can only cancel frames where no packets have actually hit the network yet. Said another way, it can only cancel frames the receiver has definitely not seen any part of (including kickstarting!). This bug tracks adding the optimization to "peek inside the CastTransport" and cancel frames that have not actually hit the network yet. In addition, we need to be careful about any internal state of the transport implementation that tracks or depends on knowledge of the "latest frame ID."
,
Nov 9 2016
,
Jan 4 2017
,
Mar 15 2017
,
Apr 10 2018
This optimize would reduce seek times for media remoting.
,
Jun 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4020cfd69a6570e34522e3dd52c378a990b15992 commit 4020cfd69a6570e34522e3dd52c378a990b15992 Author: Xiangjun Zhang <xjz@chromium.org> Date: Sat Jun 02 00:11:12 2018 Mirroring Service: Refactoring cast remoting sender. Purely a refactoring of CastRemotingSender. Removed duplicated code with media::cast::FrameSender. No behaviour change. Bug: 734672 , 647423 Change-Id: I574404818da07c3916054beff27ccb89fddeb1d4 Reviewed-on: https://chromium-review.googlesource.com/1073872 Commit-Queue: Xiangjun Zhang <xjz@chromium.org> Reviewed-by: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#563875} [modify] https://crrev.com/4020cfd69a6570e34522e3dd52c378a990b15992/components/mirroring/service/BUILD.gn [add] https://crrev.com/4020cfd69a6570e34522e3dd52c378a990b15992/components/mirroring/service/remoting_sender.cc [add] https://crrev.com/4020cfd69a6570e34522e3dd52c378a990b15992/components/mirroring/service/remoting_sender.h [add] https://crrev.com/4020cfd69a6570e34522e3dd52c378a990b15992/components/mirroring/service/remoting_sender_unittest.cc [modify] https://crrev.com/4020cfd69a6570e34522e3dd52c378a990b15992/media/cast/sender/frame_sender.cc [modify] https://crrev.com/4020cfd69a6570e34522e3dd52c378a990b15992/media/cast/sender/frame_sender.h |
||||
►
Sign in to add a comment |
||||
Comment 1 by mfo...@chromium.org
, Nov 9 2016