New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 647422 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Email to this user bounced
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Integer-overflow in XRect_roundOut

Project Member Reported by ClusterFuzz, Sep 15 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6705463188258816

Fuzzer: miaubiz_svg_fuzzer
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  XRect_roundOut
  SkScan::AntiFillXRect
  aa_square_proc
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_ubsan_chrome&range=398502:398570

Minimized Testcase (1.35 Kb): https://cluster-fuzz.appspot.com/download/AMIfv975mntPulcwCflDst79ZRqxIB9_n25Xq5d6EYU4f4PocVcZWpg4jVLsUacBtcjXP6HjYDRNToNC_sFR_0Ofaou4p8B1hdtOERq0mG2Tj3SYWMdXPuObq-iuCOkL0dqpyAj_ds9uj4Malc35yOa_lE0mjDXGpQ?testcase_id=6705463188258816

Issue manually filed by: mummareddy

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Components: Internals>Skia
Labels: M-54 Te-Logged
Owner: mtklein@chromium.org
Status: Assigned (was: Untriaged)

Author: mtklein
Project: chromium-skia
Changelist: https://chromium.googlesource.com/skia.git/+/343a63d082bda969d7e8a4e09ba850e931185269
Time: Tue Mar 22 18:46:53 2016
The CL last changed line 54 of file SkRecordDraw.cpp, which is stack frame 6.

Suspected Project: chromium-skia
Suspected Component: Internals>Skia

mtklein@, could you please take a look and please help us to find correct owner if it is not related your changes.
Cc: mtklein@chromium.org
Owner: ----
We can definitely rule that CL out.  It's a complete no-op refactor in terms of behavior... it should generate identical binary output.
Labels: Needs-triage
Status: Available (was: Assigned)
Unable to find actual suspect for this issue, so marking it as available and adding Needs-triage label
Cc: bsalomon@chromium.org
Owner: reed@chromium.org
Status: Assigned (was: Available)
SkRecordDraw.cpp file is not accessible, so assigning to owners of //src/third_party/skia/ the file.

reed@, could you please take a look and help us to find right owner for this issue.
Labels: -Needs-triage
Labels: Pri-2
Project Member

Comment 7 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by ClusterFuzz, Mar 18 2017

ClusterFuzz has detected this issue as fixed in range 456626:457730.

Detailed report: https://clusterfuzz.com/testcase?key=6705463188258816

Fuzzer: miaubiz_svg_fuzzer
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  XRect_roundOut
  SkScan::AntiFillXRect
  aa_square_proc
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=398502:398570
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=456626:457730

Reproducer Testcase: https://clusterfuzz.com/download/AMIfv975mntPulcwCflDst79ZRqxIB9_n25Xq5d6EYU4f4PocVcZWpg4jVLsUacBtcjXP6HjYDRNToNC_sFR_0Ofaou4p8B1hdtOERq0mG2Tj3SYWMdXPuObq-iuCOkL0dqpyAj_ds9uj4Malc35yOa_lE0mjDXGpQ?testcase_id=6705463188258816


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Mar 18 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6705463188258816 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment