New issue
Advanced search Search tips

Issue 647413 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Fix and reenable smoothness.tough_ad_cases on Android Perf bot

Project Member Reported by robert...@chromium.org, Sep 15 2016

Issue description

smoothness.tough_ad_cases failing on 3 builders

Type: build-failure

Builders failed on: 
- Android Galaxy S5 Perf (2): 
  https://build.chromium.org/p/chromium.perf/builders/Android%20Galaxy%20S5%20Perf%20%282%29
- Android Nexus5X Perf (2): 
  https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5X%20Perf%20%282%29
- Android Nexus6 Perf (2): 
  https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus6%20Perf%20%282%29



 
Cc: skyos...@chromium.org
This test is very flaky! CC'ing test owner.

View generated profiler files online at https://console.developers.google.com/m/cloudstorage/b/chrome-telemetry-output/o/profiler-file-id_9-2016-09-15_19-32-5051687.png for page http://localhost:8000/clip-paths-CILZhLqO_-27bxB4GNgEKAEyCC46kMLBXnMT.swiffy72.html
[  PASSED  ] 8 tests.
[  FAILED  ] 3 tests, listed below:
[  FAILED  ]  http://localhost:8000/CNP2xe_LmqPEKBCsAhj6ASgBMggnyMqth81h8Q.swiffy72.html
[  FAILED  ]  http://localhost:8000/clip-paths-CICAgMDO7Ye9-gEQ2AUYWigBMgjZxDii6aoK9w.swiffy72.html
[  FAILED  ]  http://localhost:8000/clip-paths-CILZhLqO_-27bxB4GNgEKAEyCC46kMLBXnMT.swiffy72.html

3 FAILED TESTS


Traceback (most recent call last):
  File "/b/rr/tmp1_I1pv/w/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py", line 86, in _RunStoryAndProcessErrorIfNeeded
    state.RunStory(results)
  File "/b/rr/tmp1_I1pv/w/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/b/rr/tmp1_I1pv/w/src/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 301, in RunStory
    self._current_page.Run(self)
  File "/b/rr/tmp1_I1pv/w/src/third_party/catapult/telemetry/telemetry/page/__init__.py", line 95, in Run
    shared_state.page_test.RunNavigateSteps(self, current_tab)
  File "/b/rr/tmp1_I1pv/w/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/rr/tmp1_I1pv/w/src/third_party/catapult/telemetry/telemetry/page/legacy_page_test.py", line 195, in RunNavigateSteps
    page.RunNavigateSteps(action_runner)
  File "/b/rr/tmp1_I1pv/w/src/tools/perf/page_sets/tough_ad_cases.py", line 29, in RunNavigateSteps
    action_runner.EvaluateJavaScript(viewport_js)
  File "/b/rr/tmp1_I1pv/w/src/third_party/catapult/telemetry/telemetry/internal/actions/action_runner.py", line 200, in EvaluateJavaScript
    return self._tab.EvaluateJavaScript(expression)
  File "/b/rr/tmp1_I1pv/w/src/third_party/catapult/telemetry/telemetry/internal/browser/web_contents.py", line 187, in EvaluateJavaScript
    expr, context_id=None, timeout=timeout)
  File "/b/rr/tmp1_I1pv/w/src/third_party/catapult/telemetry/telemetry/internal/browser/web_contents.py", line 215, in EvaluateJavaScriptInContext
    expr, context_id=context_id, timeout=timeout)
  File "/b/rr/tmp1_I1pv/w/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/rr/tmp1_I1pv/w/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 34, in inner
    return func(inspector_backend, *args, **kwargs)
  File "/b/rr/tmp1_I1pv/w/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 208, in EvaluateJavaScript
    return self._runtime.Evaluate(expr, context_id, timeout)
  File "/b/rr/tmp1_I1pv/w/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_runtime.py", line 53, in Evaluate
    raise exceptions.EvaluateException(text)
EvaluateException: Uncaught
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Sep 17 2016


===== BISECT JOB RESULTS =====
Status: completed


===== TESTED REVISIONS =====
Revision         Exit Code  Std Dev  N   Good?
chromium@418484  1          N/A      20  good
chromium@419184  1          N/A      20  bad

Bisect job ran on: winx64_zen_perf_bisect
Bug ID: 647413

Test Command: src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --also-run-disabled-tests smoothness.tough_ad_cases
Test Metric: frame_times/frame_times
Relative Change: 0.00%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64_zen_perf_bisect/builds/481
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9001332150575417120


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5823797800730624

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Owner: skyos...@chromium.org
Sami, I'm going to go ahead and disable this test on Android for now to make the bots stable again. Once you're able to make this stable, feel free to reenable it on the bots.
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f155c9037677e839724a4624b7eff5a4d0facd5

commit 2f155c9037677e839724a4624b7eff5a4d0facd5
Author: charliea <charliea@chromium.org>
Date: Tue Sep 20 14:59:55 2016

Disable smoothness.tough_ad_cases on Android

This benchmark is failing on lots of Android bots.

TBR=skyostil@chromium.org
BUG= 647413 

Review-Url: https://codereview.chromium.org/2351803003
Cr-Commit-Position: refs/heads/master@{#419760}

[modify] https://crrev.com/2f155c9037677e839724a4624b7eff5a4d0facd5/tools/perf/benchmarks/smoothness.py

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c320e4b3fdb478bcac243cade43f115abb768b4a

commit c320e4b3fdb478bcac243cade43f115abb768b4a
Author: skyostil <skyostil@chromium.org>
Date: Fri Sep 30 11:18:23 2016

perf: Speculative fix for Swiffy WebGL ad pages

Sometimes we try to set up the viewport on the page before the page has
fully loaded. Wait for the page to settle before doing this.

BUG= 647413 

Review-Url: https://codereview.chromium.org/2373983005
Cr-Commit-Position: refs/heads/master@{#422081}

[modify] https://crrev.com/c320e4b3fdb478bcac243cade43f115abb768b4a/tools/perf/page_sets/tough_ad_cases.py

Comment 7 by zh...@chromium.org, Oct 3 2016

Labels: -Pri-1 Pri-2
Summary: Fix and reenable smoothness.tough_ad_cases on Android Perf bot (was: smoothness.tough_ad_cases failing on 3 builders)
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e86c7afce17c0a263c19406eb3bb68bbc70b6b71

commit e86c7afce17c0a263c19406eb3bb68bbc70b6b71
Author: skyostil <skyostil@chromium.org>
Date: Tue Oct 04 11:30:01 2016

perf: Re-enable smoothness.tough_ad_cases on Android

These benchmarks were failing for the same underlying reason as
smoothness.tough_webgl_ad_cases, which was fixed by
https://codereview.chromium.org/2373983005.

BUG= 647413 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Review-Url: https://codereview.chromium.org/2386093002
Cr-Commit-Position: refs/heads/master@{#422754}

[modify] https://crrev.com/e86c7afce17c0a263c19406eb3bb68bbc70b6b71/tools/perf/benchmarks/smoothness.py

Status: Fixed (was: Available)

Sign in to add a comment