The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1eb7caa4fa0a3b0f0cb5ecb106d15b03aeefa202

commit 1eb7caa4fa0a3b0f0cb5ecb106d15b03aeefa202
Author: sky <sky@chromium.org>
Date: Fri Sep 16 00:02:46 2016

Adds bug ids to some NOTIMPLEMENTEDs

For better tracking.

BUG=647433, 647412 , 647416 , 647409 , 647421 , 647417 
TEST=none

Review-Url: https://codereview.chromium.org/2345613003
Cr-Commit-Position: refs/heads/master@{#419044}

[modify] https://crrev.com/1eb7caa4fa0a3b0f0cb5ecb106d15b03aeefa202/ash/mus/new_window_delegate_mus.cc
[modify] https://crrev.com/1eb7caa4fa0a3b0f0cb5ecb106d15b03aeefa202/ash/mus/shell_delegate_mus.cc

 Issue 650698  has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9da5671dace9092f33d0c65a05162f9da5360d53

commit 9da5671dace9092f33d0c65a05162f9da5360d53
Author: jamescook <jamescook@chromium.org>
Date: Wed Sep 28 00:34:50 2016

mustash: Connect ash system tray "show settings" items to chrome over mojo

* Wire everything from SystemTrayDelegateMus -> ash::mojom::SystemTrayClient -> SystemTrayCommon
* Rename ChangeProxySettings to ShowProxySettings for consistency with other methods
* Eliminate SystemTrayDelegate::ShowSupervisedUserInfo - it has been unimplemented for 3 years
* Removed unused SystemTrayDelegate::ChangeProfilePicture and associated URL and UMA metric

While doing this I found a few items that will need to be refactored in chrome
before they can be wired up. I left TODOs for them rather than skipping them
because it will save me some work later.

BUG= 647412 
TEST=ash_unittests, manual testing of system tray menu in chrome --mash

Review-Url: https://codereview.chromium.org/2373863002
Cr-Commit-Position: refs/heads/master@{#421397}

[modify] https://crrev.com/9da5671dace9092f33d0c65a05162f9da5360d53/ash/common/system/chromeos/network/network_state_list_detailed_view.cc
[modify] https://crrev.com/9da5671dace9092f33d0c65a05162f9da5360d53/ash/common/system/chromeos/supervised/tray_supervised_user.cc
[modify] https://crrev.com/9da5671dace9092f33d0c65a05162f9da5360d53/ash/common/system/tray/system_tray_delegate.cc
[modify] https://crrev.com/9da5671dace9092f33d0c65a05162f9da5360d53/ash/common/system/tray/system_tray_delegate.h
[modify] https://crrev.com/9da5671dace9092f33d0c65a05162f9da5360d53/ash/mus/system_tray_delegate_mus.cc
[modify] https://crrev.com/9da5671dace9092f33d0c65a05162f9da5360d53/ash/mus/system_tray_delegate_mus.h
[modify] https://crrev.com/9da5671dace9092f33d0c65a05162f9da5360d53/ash/public/interfaces/system_tray.mojom
[modify] https://crrev.com/9da5671dace9092f33d0c65a05162f9da5360d53/chrome/browser/ui/ash/system_tray_client.cc
[modify] https://crrev.com/9da5671dace9092f33d0c65a05162f9da5360d53/chrome/browser/ui/ash/system_tray_client.h
[modify] https://crrev.com/9da5671dace9092f33d0c65a05162f9da5360d53/chrome/browser/ui/ash/system_tray_common.cc
[modify] https://crrev.com/9da5671dace9092f33d0c65a05162f9da5360d53/chrome/browser/ui/ash/system_tray_common.h
[modify] https://crrev.com/9da5671dace9092f33d0c65a05162f9da5360d53/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/9da5671dace9092f33d0c65a05162f9da5360d53/chrome/browser/ui/ash/system_tray_delegate_chromeos.h
[modify] https://crrev.com/9da5671dace9092f33d0c65a05162f9da5360d53/chrome/common/url_constants.cc
[modify] https://crrev.com/9da5671dace9092f33d0c65a05162f9da5360d53/chrome/common/url_constants.h
[modify] https://crrev.com/9da5671dace9092f33d0c65a05162f9da5360d53/tools/metrics/actions/actions.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40496aad11135e1b863823467e62c4bd956128ae

commit 40496aad11135e1b863823467e62c4bd956128ae
Author: jamescook <jamescook@chromium.org>
Date: Thu Sep 29 18:38:47 2016

mustash: Show networking items in ash system tray

* Initialize chromeos::NetworkHandler during startup
* Include //ui/chromeos strings and assets in the mash target
* Add VPNDelegateMus to SystemTrayDelegateMus because the system tray expects
a non-null VPN delegate during construction
* Add a StubNetworkingConfigDelegate to SystemTrayDelegateMus. This is just
a stub impl because I think the functionality will be rolled into an ash
network information cache in the future.

TODO: Sort out which pieces of NetworkHandler state are controlled by ash vs
browser

BUG= 647412 ,644355
TEST=manual, chrome --mash shows networking items

Review-Url: https://codereview.chromium.org/2378193002
Cr-Commit-Position: refs/heads/master@{#421881}

[modify] https://crrev.com/40496aad11135e1b863823467e62c4bd956128ae/ash/common/system/networking_config_delegate.h
[modify] https://crrev.com/40496aad11135e1b863823467e62c4bd956128ae/ash/mus/BUILD.gn
[modify] https://crrev.com/40496aad11135e1b863823467e62c4bd956128ae/ash/mus/shell_delegate_mus.cc
[modify] https://crrev.com/40496aad11135e1b863823467e62c4bd956128ae/ash/mus/system_tray_delegate_mus.cc
[modify] https://crrev.com/40496aad11135e1b863823467e62c4bd956128ae/ash/mus/system_tray_delegate_mus.h
[add] https://crrev.com/40496aad11135e1b863823467e62c4bd956128ae/ash/mus/vpn_delegate_mus.cc
[add] https://crrev.com/40496aad11135e1b863823467e62c4bd956128ae/ash/mus/vpn_delegate_mus.h
[modify] https://crrev.com/40496aad11135e1b863823467e62c4bd956128ae/ash/mus/window_manager_application.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2de27ad565eae8ca5e3c61cc055ecb34e4e1b3f

commit d2de27ad565eae8ca5e3c61cc055ecb34e4e1b3f
Author: jamescook <jamescook@chromium.org>
Date: Thu Sep 29 20:31:08 2016

Support SystemTrayDelegate::ShowPowerSettings() in mustash

* Wire through SystemTrayDelegateMus -> mojom::SystemTrayClient -> SystemTrayCommon
* To avoid ash dependencies in SystemTrayCommon, check for a battery in the //ash
code, which has access to ash::PowerStatus
* Remove the check for the --enable-power-overlay switch, since this code is only
triggered from DualRoleNotification in ash, which only occurs on a real device

BUG=644348, 647412 
TEST=manual, change the code to call ShowPowerSettings when clicking on the
tray date and observe that power settings opens

Review-Url: https://codereview.chromium.org/2377703003
Cr-Commit-Position: refs/heads/master@{#421923}

[modify] https://crrev.com/d2de27ad565eae8ca5e3c61cc055ecb34e4e1b3f/ash/mus/system_tray_delegate_mus.cc
[modify] https://crrev.com/d2de27ad565eae8ca5e3c61cc055ecb34e4e1b3f/ash/public/interfaces/system_tray.mojom
[modify] https://crrev.com/d2de27ad565eae8ca5e3c61cc055ecb34e4e1b3f/chrome/browser/ui/ash/system_tray_client.cc
[modify] https://crrev.com/d2de27ad565eae8ca5e3c61cc055ecb34e4e1b3f/chrome/browser/ui/ash/system_tray_client.h
[modify] https://crrev.com/d2de27ad565eae8ca5e3c61cc055ecb34e4e1b3f/chrome/browser/ui/ash/system_tray_common.cc
[modify] https://crrev.com/d2de27ad565eae8ca5e3c61cc055ecb34e4e1b3f/chrome/browser/ui/ash/system_tray_common.h
[modify] https://crrev.com/d2de27ad565eae8ca5e3c61cc055ecb34e4e1b3f/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a6b869d3921b816777679003d1df24f6c7b84fa

commit 2a6b869d3921b816777679003d1df24f6c7b84fa
Author: jamescook <jamescook@chromium.org>
Date: Tue Oct 04 02:41:29 2016

Use mojo SystemTray interfaces for both mash and classic ash

The goal is to stop having to maintain separate SystemTrayDelegateMus and
SystemTrayDelegateChromeos implementations and eliminate the indirection
introduced by SystemTrayCommon.

* Always create the SystemTrayClient object in chrome, whether running ash
in-process or not
* Always allow code in //ash to bind to mojom::SystemTrayClient, even when ash
runs in-process
* Introduce WmShell::IsRunningInMash so ash can tell which mode its in
* Handle connecting to "exe:chrome" vs. "exe:content_browser" based on the
process mode
* Introduces SystemTrayController in ash, which wraps mojom::SystemTrayClient
* Peel two methods off the SystemTrayDelegate interface and changes them
to call into SystemTrayController and route over mojo
* Remove mojo usage from SystemTrayDelegateMus. Eventually it should go away
completely.

To keep this CL small it breaks a few system tray features when running under
mash (e.g. opening the general settings). This will get fixed in the next CL.

TODO: Remove SystemTrayCommon and move its functionality into SystemTrayClient
TODO: For methods like SystemTrayDelegate::ShowSettings, migrate callers to
use ash::SystemTrayController and always route over mojo.

BUG= 647412 
TEST=manual, clicking on system tray date opens date settings, changing time
from 12 to 24 hour works, in both classic ash and mash

Review-Url: https://codereview.chromium.org/2381753002
Cr-Commit-Position: refs/heads/master@{#422676}

[modify] https://crrev.com/2a6b869d3921b816777679003d1df24f6c7b84fa/ash/BUILD.gn
[modify] https://crrev.com/2a6b869d3921b816777679003d1df24f6c7b84fa/ash/DEPS
[modify] https://crrev.com/2a6b869d3921b816777679003d1df24f6c7b84fa/ash/aura/wm_shell_aura.cc
[modify] https://crrev.com/2a6b869d3921b816777679003d1df24f6c7b84fa/ash/aura/wm_shell_aura.h
[add] https://crrev.com/2a6b869d3921b816777679003d1df24f6c7b84fa/ash/common/mojo_interface_factory.cc
[add] https://crrev.com/2a6b869d3921b816777679003d1df24f6c7b84fa/ash/common/mojo_interface_factory.h
[modify] https://crrev.com/2a6b869d3921b816777679003d1df24f6c7b84fa/ash/common/shell_delegate.h
[modify] https://crrev.com/2a6b869d3921b816777679003d1df24f6c7b84fa/ash/common/system/date/date_view.cc
[modify] https://crrev.com/2a6b869d3921b816777679003d1df24f6c7b84fa/ash/common/system/tray/system_tray.cc
[add] https://crrev.com/2a6b869d3921b816777679003d1df24f6c7b84fa/ash/common/system/tray/system_tray_controller.cc
[add] https://crrev.com/2a6b869d3921b816777679003d1df24f6c7b84fa/ash/common/system/tray/system_tray_controller.h
[modify] https://crrev.com/2a6b869d3921b816777679003d1df24f6c7b84fa/ash/common/system/tray/system_tray_delegate.cc
[modify] https://crrev.com/2a6b869d3921b816777679003d1df24f6c7b84fa/ash/common/system/tray/system_tray_delegate.h
[modify] https://crrev.com/2a6b869d3921b816777679003d1df24f6c7b84fa/ash/common/wm_shell.cc
[modify] https://crrev.com/2a6b869d3921b816777679003d1df24f6c7b84fa/ash/common/wm_shell.h
[modify] https://crrev.com/2a6b869d3921b816777679003d1df24f6c7b84fa/ash/mus/bridge/wm_shell_mus.cc
[modify] https://crrev.com/2a6b869d3921b816777679003d1df24f6c7b84fa/ash/mus/bridge/wm_shell_mus.h
[modify] https://crrev.com/2a6b869d3921b816777679003d1df24f6c7b84fa/ash/mus/shell_delegate_mus.cc
[modify] https://crrev.com/2a6b869d3921b816777679003d1df24f6c7b84fa/ash/mus/shell_delegate_mus.h
[modify] https://crrev.com/2a6b869d3921b816777679003d1df24f6c7b84fa/ash/mus/system_tray_delegate_mus.cc
[modify] https://crrev.com/2a6b869d3921b816777679003d1df24f6c7b84fa/ash/mus/system_tray_delegate_mus.h
[modify] https://crrev.com/2a6b869d3921b816777679003d1df24f6c7b84fa/ash/mus/window_manager_application.cc
[modify] https://crrev.com/2a6b869d3921b816777679003d1df24f6c7b84fa/ash/mus/window_manager_application.h
[modify] https://crrev.com/2a6b869d3921b816777679003d1df24f6c7b84fa/ash/shell/shell_delegate_impl.cc
[modify] https://crrev.com/2a6b869d3921b816777679003d1df24f6c7b84fa/ash/shell/shell_delegate_impl.h
[modify] https://crrev.com/2a6b869d3921b816777679003d1df24f6c7b84fa/ash/test/test_shell_delegate.cc
[modify] https://crrev.com/2a6b869d3921b816777679003d1df24f6c7b84fa/ash/test/test_shell_delegate.h
[add] https://crrev.com/2a6b869d3921b816777679003d1df24f6c7b84fa/chrome/app/mojo/OWNERS
[modify] https://crrev.com/2a6b869d3921b816777679003d1df24f6c7b84fa/chrome/app/mojo/chrome_manifest.json
[modify] https://crrev.com/2a6b869d3921b816777679003d1df24f6c7b84fa/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/2a6b869d3921b816777679003d1df24f6c7b84fa/chrome/browser/chrome_content_browser_manifest_overlay.json
[modify] https://crrev.com/2a6b869d3921b816777679003d1df24f6c7b84fa/chrome/browser/chromeos/chrome_interface_factory.cc
[modify] https://crrev.com/2a6b869d3921b816777679003d1df24f6c7b84fa/chrome/browser/chromeos/chrome_interface_factory.h
[modify] https://crrev.com/2a6b869d3921b816777679003d1df24f6c7b84fa/chrome/browser/chromeos/policy/device_system_use_24hour_clock_browsertest.cc
[modify] https://crrev.com/2a6b869d3921b816777679003d1df24f6c7b84fa/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/2a6b869d3921b816777679003d1df24f6c7b84fa/chrome/browser/ui/ash/chrome_shell_delegate.h
[modify] https://crrev.com/2a6b869d3921b816777679003d1df24f6c7b84fa/chrome/browser/ui/ash/system_tray_client.cc
[modify] https://crrev.com/2a6b869d3921b816777679003d1df24f6c7b84fa/chrome/browser/ui/ash/system_tray_client.h
[modify] https://crrev.com/2a6b869d3921b816777679003d1df24f6c7b84fa/chrome/browser/ui/ash/system_tray_common.h
[modify] https://crrev.com/2a6b869d3921b816777679003d1df24f6c7b84fa/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/2a6b869d3921b816777679003d1df24f6c7b84fa/chrome/browser/ui/ash/system_tray_delegate_chromeos.h
[modify] https://crrev.com/2a6b869d3921b816777679003d1df24f6c7b84fa/chrome/browser/ui/ash/system_tray_delegate_chromeos_browsertest_chromeos.cc
[modify] https://crrev.com/2a6b869d3921b816777679003d1df24f6c7b84fa/chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc
[modify] https://crrev.com/2a6b869d3921b816777679003d1df24f6c7b84fa/content/public/app/mojo/content_browser_manifest.json

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4dd7585b13a7fc40276b36efd33e85177aa45ebb

commit 4dd7585b13a7fc40276b36efd33e85177aa45ebb
Author: jamescook <jamescook@chromium.org>
Date: Tue Oct 04 18:04:58 2016

chromeos: Refactor system tray "show settings" commands to use mojo

Change the pattern of delegation to chrome to use mojom::SystemTrayClient.
This is more consistent with how we want to handle ash delegates going
forward. It eliminates a couple layers of indirection.

* Add wrapper methods to SystemTrayController in ash
* Remove Show* methods from SystemTrayDelegate in ash
* Delete SystemTrayCommon in chrome, move code to SystemTrayClient

Also delete unused tray_display.cc, left over from another cleanup CL
https://codereview.chromium.org/2217713002

BUG= 647412 
TEST=existing browser_tests, manually verifying system tray help and
settings buttons open web UI in chrome

Review-Url: https://codereview.chromium.org/2395523002
Cr-Commit-Position: refs/heads/master@{#422857}

[modify] https://crrev.com/4dd7585b13a7fc40276b36efd33e85177aa45ebb/ash/common/system/chromeos/ime_menu/ime_menu_tray.cc
[modify] https://crrev.com/4dd7585b13a7fc40276b36efd33e85177aa45ebb/ash/common/system/chromeos/network/network_state_list_detailed_view.cc
[modify] https://crrev.com/4dd7585b13a7fc40276b36efd33e85177aa45ebb/ash/common/system/chromeos/palette/palette_tray.cc
[modify] https://crrev.com/4dd7585b13a7fc40276b36efd33e85177aa45ebb/ash/common/system/chromeos/power/dual_role_notification.cc
[modify] https://crrev.com/4dd7585b13a7fc40276b36efd33e85177aa45ebb/ash/common/system/chromeos/settings/tray_settings.cc
[modify] https://crrev.com/4dd7585b13a7fc40276b36efd33e85177aa45ebb/ash/common/system/chromeos/tray_tracing.cc
[modify] https://crrev.com/4dd7585b13a7fc40276b36efd33e85177aa45ebb/ash/common/system/date/date_default_view.cc
[modify] https://crrev.com/4dd7585b13a7fc40276b36efd33e85177aa45ebb/ash/common/system/ime/tray_ime_chromeos.cc
[modify] https://crrev.com/4dd7585b13a7fc40276b36efd33e85177aa45ebb/ash/common/system/tray/system_tray_controller.cc
[modify] https://crrev.com/4dd7585b13a7fc40276b36efd33e85177aa45ebb/ash/common/system/tray/system_tray_controller.h
[modify] https://crrev.com/4dd7585b13a7fc40276b36efd33e85177aa45ebb/ash/common/system/tray/system_tray_delegate.cc
[modify] https://crrev.com/4dd7585b13a7fc40276b36efd33e85177aa45ebb/ash/common/system/tray/system_tray_delegate.h
[modify] https://crrev.com/4dd7585b13a7fc40276b36efd33e85177aa45ebb/ash/common/system/tray_accessibility.cc
[modify] https://crrev.com/4dd7585b13a7fc40276b36efd33e85177aa45ebb/ash/common/system/user/user_card_view.cc
[modify] https://crrev.com/4dd7585b13a7fc40276b36efd33e85177aa45ebb/ash/system/chromeos/screen_layout_observer.cc
[delete] https://crrev.com/cc6bd5c938f5d4dfa33ed1bbe962a2effc12d597/ash/system/chromeos/tray_display.cc
[modify] https://crrev.com/4dd7585b13a7fc40276b36efd33e85177aa45ebb/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/4dd7585b13a7fc40276b36efd33e85177aa45ebb/chrome/browser/ui/ash/system_tray_client.cc
[modify] https://crrev.com/4dd7585b13a7fc40276b36efd33e85177aa45ebb/chrome/browser/ui/ash/system_tray_client.h
[delete] https://crrev.com/cc6bd5c938f5d4dfa33ed1bbe962a2effc12d597/chrome/browser/ui/ash/system_tray_common.cc
[delete] https://crrev.com/cc6bd5c938f5d4dfa33ed1bbe962a2effc12d597/chrome/browser/ui/ash/system_tray_common.h
[modify] https://crrev.com/4dd7585b13a7fc40276b36efd33e85177aa45ebb/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/4dd7585b13a7fc40276b36efd33e85177aa45ebb/chrome/browser/ui/ash/system_tray_delegate_chromeos.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c17dff06e0421bf73c533d4b3a626ed39585f4da

commit c17dff06e0421bf73c533d4b3a626ed39585f4da
Author: jamescook <jamescook@chromium.org>
Date: Wed Oct 05 23:58:23 2016

chromeos: Don't explicitly set system tray visibility during initialization

This allows SystemTrayDelegate::GetTrayVisibilityOnStartup() to be removed,
so we don't have to port it to mustash.

The visibility is controlled explicitly via chrome's login WizardController
and implicitly by login status changes.

BUG= 647412 
TEST=ash_unittests, chrome browser_tests

Review-Url: https://codereview.chromium.org/2389403003
Cr-Commit-Position: refs/heads/master@{#423344}

[modify] https://crrev.com/c17dff06e0421bf73c533d4b3a626ed39585f4da/ash/common/system/tray/default_system_tray_delegate.cc
[modify] https://crrev.com/c17dff06e0421bf73c533d4b3a626ed39585f4da/ash/common/system/tray/default_system_tray_delegate.h
[modify] https://crrev.com/c17dff06e0421bf73c533d4b3a626ed39585f4da/ash/common/system/tray/system_tray.cc
[modify] https://crrev.com/c17dff06e0421bf73c533d4b3a626ed39585f4da/ash/common/system/tray/system_tray_delegate.cc
[modify] https://crrev.com/c17dff06e0421bf73c533d4b3a626ed39585f4da/ash/common/system/tray/system_tray_delegate.h
[modify] https://crrev.com/c17dff06e0421bf73c533d4b3a626ed39585f4da/ash/shelf/shelf_widget_unittest.cc
[modify] https://crrev.com/c17dff06e0421bf73c533d4b3a626ed39585f4da/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/c17dff06e0421bf73c533d4b3a626ed39585f4da/chrome/browser/ui/ash/system_tray_delegate_chromeos.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9b36ee098ef29022e8e24c2f6faab21dcde5ec5

commit b9b36ee098ef29022e8e24c2f6faab21dcde5ec5
Author: jamescook <jamescook@chromium.org>
Date: Thu Oct 06 18:36:28 2016

chromeos: Refactor system tray ShowNetworkSettingsForGuid for mash

* Add to ash::mojom::SystemTrayClient interface
* Move implementation in chrome browser into SystemTrayClient
* Rename to ShowNetworkSettings with |network_id| because the parameter
|guid| isn't always a GUID.

This unfortunately has to check IsRunningInMash to access the session
state delegate. xiyuan@ is working on a system to replace that delegate,
but for now this is the simplest way.

BUG= 647412 
TEST=browser_tests, manually open network settings from system tray, both
via the Settings button and by clicking on the connected network

Review-Url: https://codereview.chromium.org/2396863004
Cr-Commit-Position: refs/heads/master@{#423600}

[modify] https://crrev.com/b9b36ee098ef29022e8e24c2f6faab21dcde5ec5/ash/common/system/chromeos/network/network_state_list_detailed_view.cc
[modify] https://crrev.com/b9b36ee098ef29022e8e24c2f6faab21dcde5ec5/ash/common/system/tray/system_tray_controller.cc
[modify] https://crrev.com/b9b36ee098ef29022e8e24c2f6faab21dcde5ec5/ash/common/system/tray/system_tray_controller.h
[modify] https://crrev.com/b9b36ee098ef29022e8e24c2f6faab21dcde5ec5/ash/common/system/tray/system_tray_delegate.cc
[modify] https://crrev.com/b9b36ee098ef29022e8e24c2f6faab21dcde5ec5/ash/common/system/tray/system_tray_delegate.h
[modify] https://crrev.com/b9b36ee098ef29022e8e24c2f6faab21dcde5ec5/ash/public/interfaces/system_tray.mojom
[modify] https://crrev.com/b9b36ee098ef29022e8e24c2f6faab21dcde5ec5/chrome/browser/ui/ash/network_connect_delegate_chromeos.cc
[modify] https://crrev.com/b9b36ee098ef29022e8e24c2f6faab21dcde5ec5/chrome/browser/ui/ash/system_tray_client.cc
[modify] https://crrev.com/b9b36ee098ef29022e8e24c2f6faab21dcde5ec5/chrome/browser/ui/ash/system_tray_client.h
[modify] https://crrev.com/b9b36ee098ef29022e8e24c2f6faab21dcde5ec5/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/b9b36ee098ef29022e8e24c2f6faab21dcde5ec5/chrome/browser/ui/ash/system_tray_delegate_chromeos.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f60d6ea452282d53ef12de076c0a5436bae3ddb7

commit f60d6ea452282d53ef12de076c0a5436bae3ddb7
Author: jamescook <jamescook@chromium.org>
Date: Tue Oct 11 21:37:37 2016

ash: Remove broken display notification suppression when settings is open

On Chrome OS we used to have code that suppressed showing a display change
notification (e.g. resolution changed) when the display settings UI was
visible. This broke when settings moved from being shown in a tab to being
shown in a window. We always show the notifications, and have been doing so
for about 2 years.

I spoke with PM tbuckley@ and he's OK with always showing the notifications
I've deleted the code that was trying to suppress them, effectively doing a
manual revert of http://crrev.com/208299

This simplifies ash::SystemTrayDelegate and removes one method I would have
to port to mojo for mustash.

BUG= 246271 , 647412 
TEST=ash_unittests, change display rotation and see that a notification
always appears

Review-Url: https://codereview.chromium.org/2400553002
Cr-Commit-Position: refs/heads/master@{#424553}

[modify] https://crrev.com/f60d6ea452282d53ef12de076c0a5436bae3ddb7/ash/common/system/tray/default_system_tray_delegate.cc
[modify] https://crrev.com/f60d6ea452282d53ef12de076c0a5436bae3ddb7/ash/common/system/tray/default_system_tray_delegate.h
[modify] https://crrev.com/f60d6ea452282d53ef12de076c0a5436bae3ddb7/ash/common/system/tray/system_tray_delegate.cc
[modify] https://crrev.com/f60d6ea452282d53ef12de076c0a5436bae3ddb7/ash/common/system/tray/system_tray_delegate.h
[modify] https://crrev.com/f60d6ea452282d53ef12de076c0a5436bae3ddb7/ash/common/test/test_system_tray_delegate.cc
[modify] https://crrev.com/f60d6ea452282d53ef12de076c0a5436bae3ddb7/ash/common/test/test_system_tray_delegate.h
[modify] https://crrev.com/f60d6ea452282d53ef12de076c0a5436bae3ddb7/ash/content/display/screen_orientation_controller_chromeos_unittest.cc
[modify] https://crrev.com/f60d6ea452282d53ef12de076c0a5436bae3ddb7/ash/display/mirror_window_controller_unittest.cc
[modify] https://crrev.com/f60d6ea452282d53ef12de076c0a5436bae3ddb7/ash/system/chromeos/screen_layout_observer.cc
[modify] https://crrev.com/f60d6ea452282d53ef12de076c0a5436bae3ddb7/ash/system/chromeos/screen_layout_observer.h
[modify] https://crrev.com/f60d6ea452282d53ef12de076c0a5436bae3ddb7/ash/system/chromeos/screen_layout_observer_unittest.cc
[modify] https://crrev.com/f60d6ea452282d53ef12de076c0a5436bae3ddb7/ash/system/web_notification/web_notification_tray_unittest.cc
[modify] https://crrev.com/f60d6ea452282d53ef12de076c0a5436bae3ddb7/ash/test/ash_test_helper.cc
[modify] https://crrev.com/f60d6ea452282d53ef12de076c0a5436bae3ddb7/chrome/browser/ui/ash/system_tray_client.cc
[modify] https://crrev.com/f60d6ea452282d53ef12de076c0a5436bae3ddb7/chrome/browser/ui/ash/system_tray_client.h
[modify] https://crrev.com/f60d6ea452282d53ef12de076c0a5436bae3ddb7/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/f60d6ea452282d53ef12de076c0a5436bae3ddb7/chrome/browser/ui/ash/system_tray_delegate_chromeos.h
[modify] https://crrev.com/f60d6ea452282d53ef12de076c0a5436bae3ddb7/chrome/browser/ui/ash/system_tray_delegate_chromeos_browsertest_chromeos.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/919e4b5c88a56d9c251b4680a7663397f6b43071

commit 919e4b5c88a56d9c251b4680a7663397f6b43071
Author: jamescook <jamescook@chromium.org>
Date: Mon Oct 17 23:36:34 2016

cros: Move system tray delegate widget container code to SystemTrayClient

I need this for a follow-up CL to place the Wi-Fi connect/password dialog in
the correct window container for mash.

Also collapse two very similar copies of code to compute the container id and
use the SessionManagerClient directly to get the lock screen state, rather
than tracking it via notifications.

BUG= 647412 
TEST=none

Review-Url: https://codereview.chromium.org/2427823002
Cr-Commit-Position: refs/heads/master@{#425815}

[modify] https://crrev.com/919e4b5c88a56d9c251b4680a7663397f6b43071/chrome/browser/ui/ash/network_connect_delegate_chromeos.cc
[modify] https://crrev.com/919e4b5c88a56d9c251b4680a7663397f6b43071/chrome/browser/ui/ash/system_tray_client.cc
[modify] https://crrev.com/919e4b5c88a56d9c251b4680a7663397f6b43071/chrome/browser/ui/ash/system_tray_client.h
[modify] https://crrev.com/919e4b5c88a56d9c251b4680a7663397f6b43071/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/919e4b5c88a56d9c251b4680a7663397f6b43071/chrome/browser/ui/ash/system_tray_delegate_chromeos.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8800b8237af34e0b519727164c892eb78baee4a6

commit 8800b8237af34e0b519727164c892eb78baee4a6
Author: jamescook <jamescook@chromium.org>
Date: Wed Oct 19 12:46:27 2016

mash: Use ash shell window container ids instead of ash::mojom::Container

I need to use additional window containers in a subsequent CL. Rather than
continue to maintain a mapping of kShellWindowId_Foo to ash::mojom::Container,
just use the ash container ids natively.

* Add kInitialContainerId_Property to window_manager.mojom, which is where we
set initial bounds and initial display.
* Remove container.mojom and associated utility functions.
* Replace usage of Container::LOGIN_WINDOW with LockScreenContainer, which is
where the windows end up.
* Ditto for Container::OVERLAY.
* Move ash/common/shell_window_ids.h to ash/public/cpp/

BUG= 647412 
TEST=compiles, chrome --mash --login-manager shows login dialogs correctly
TBR=reveman@chromium.org for exo

Review-Url: https://chromiumcodereview.appspot.com/2430593002
Cr-Commit-Position: refs/heads/master@{#426161}

[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/BUILD.gn
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/accelerators/accelerator_controller_delegate_aura.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/accelerators/accelerator_filter_unittest.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/app_list/app_list_presenter_delegate.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/app_list/app_list_presenter_delegate_unittest.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/aura/wm_window_aura.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/autoclick/autoclick_controller.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/autoclick/mus/BUILD.gn
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/autoclick/mus/autoclick_application.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/BUILD.gn
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/accelerators/exit_warning_handler.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/drag_drop/drag_image_view.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/frame/default_header_painter_unittest.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/metrics/pointer_metrics_recorder_unittest.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/shelf/overflow_bubble_view.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/shelf/shelf_tooltip_manager.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/shelf/shelf_window_watcher.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/shelf/shelf_window_watcher_unittest.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/shelf/wm_shelf.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/system/chromeos/ime_menu/ime_menu_tray.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/system/chromeos/network/network_state_list_detailed_view.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/system/chromeos/palette/palette_tray.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/system/chromeos/session/logout_confirmation_dialog.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/system/status_area_widget.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/system/status_area_widget_delegate.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/system/toast/toast_overlay.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/system/tray/system_tray.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/system/tray/system_tray_unittest.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/system/tray/tray_background_view.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/system/tray/tray_event_filter.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/system/user/user_view.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/system/web_notification/ash_popup_alignment_delegate.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/system/web_notification/web_notification_tray.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/test/BUILD.gn
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/test/ash_test.h
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/wallpaper/wallpaper_controller.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/wallpaper/wallpaper_controller_unittest.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/wm/always_on_top_controller.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/wm/container_finder.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/wm/container_finder_unittest.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/wm/default_state.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/wm/dock/docked_window_layout_manager.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/wm/dock/docked_window_resizer.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/wm/focus_rules.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/wm/fullscreen_window_finder.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/wm/maximize_mode/maximize_mode_window_manager.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/wm/maximize_mode/maximize_mode_window_state.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/wm/maximize_mode/workspace_backdrop_delegate.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/wm/mru_window_tracker.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/wm/mru_window_tracker_unittest.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/wm/overview/window_grid.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/wm/overview/window_selector.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/wm/overview/window_selector_item.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/wm/panels/panel_layout_manager.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/wm/panels/panel_window_resizer.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/wm/screen_dimmer.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/wm/switchable_windows.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/wm/system_modal_container_layout_manager.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/wm/window_cycle_controller.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/wm/window_cycle_list.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/wm/wm_snap_to_pixel_layout_manager.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/wm/workspace/multi_window_resize_controller.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/wm/workspace/phantom_window_controller.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/wm/workspace/workspace_layout_manager.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/wm/workspace/workspace_layout_manager_unittest.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/wm/workspace/workspace_window_resizer.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/wm/workspace_controller.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/wm_root_window_controller.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/common/wm_shell.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/display/cursor_window_controller.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/display/display_animator_chromeos.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/display/screen_position_controller.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/display/screen_position_controller_unittest.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/display/shared_display_edge_indicator.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/drag_drop/drag_drop_tracker.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/drag_drop/drag_drop_tracker_unittest.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/extended_desktop_unittest.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/first_run/desktop_cleaner.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/first_run/first_run_helper_impl.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/first_run/first_run_helper_unittest.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/laser/laser_pointer_view.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/metrics/user_metrics_recorder.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/mus/BUILD.gn
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/mus/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/mus/bridge/wm_root_window_controller_mus.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/mus/bridge/wm_shell_mus.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/mus/bridge/wm_window_mus.h
[delete] https://crrev.com/5a8525eac645446fa791220bcf48afdb9a2a8b12/ash/mus/container_ids.cc
[delete] https://crrev.com/5a8525eac645446fa791220bcf48afdb9a2a8b12/ash/mus/container_ids.h
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/mus/disconnected_app_handler.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/mus/property_util.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/mus/property_util.h
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/mus/root_window_controller.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/mus/root_window_controller.h
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/mus/window_manager.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/public/cpp/BUILD.gn
[rename] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/public/cpp/shell_window_ids.cc
[rename] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/public/cpp/shell_window_ids.h
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/public/interfaces/BUILD.gn
[delete] https://crrev.com/5a8525eac645446fa791220bcf48afdb9a2a8b12/ash/public/interfaces/container.mojom
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/root_window_controller.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/root_window_controller_unittest.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/shelf/shelf_view_unittest.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/shell.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/shell/lock_view.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/shell/shell_delegate_impl.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/shell/window_type_launcher.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/shell/window_watcher.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/shell_unittest.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/sticky_keys/sticky_keys_overlay.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/system/web_notification/web_notification_tray_unittest.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/test/BUILD.gn
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/test/ash_test_base.h
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/test/test_shell_delegate.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/touch/touch_observer_hud.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/touch_hud/mus/BUILD.gn
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/touch_hud/mus/touch_hud_application.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/utility/screenshot_controller.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/wm/always_on_top_controller_unittest.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/wm/ash_focus_rules.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/wm/ash_focus_rules_unittest.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/wm/dock/docked_window_layout_manager_unittest.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/wm/dock/docked_window_resizer_unittest.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/wm/drag_window_controller.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/wm/drag_window_resizer_unittest.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/wm/event_client_impl.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/wm/lock_layout_manager_unittest.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/wm/lock_state_controller.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/wm/panels/panel_layout_manager_unittest.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/wm/panels/panel_window_resizer_unittest.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/wm/power_button_controller.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/wm/root_window_layout_manager_unittest.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/wm/screen_pinning_controller.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/wm/session_state_animator.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/wm/session_state_animator_impl.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/wm/session_state_animator_impl_unittest.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/wm/stacking_controller_unittest.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/wm/system_modal_container_layout_manager_unittest.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/wm/toplevel_window_event_handler_unittest.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/wm/video_detector.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/wm/window_animations_unittest.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/wm/window_cycle_controller_unittest.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/wm/window_manager_unittest.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/wm/workspace/workspace_layout_manager_keyboard_unittest.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/wm/workspace/workspace_layout_manager_unittest.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/wm/workspace/workspace_window_resizer_unittest.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/ash/wm/workspace_controller_unittest.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/chrome/browser/chromeos/accessibility/chromevox_panel.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/chrome/browser/chromeos/display/overscan_calibrator.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/chrome/browser/chromeos/input_method/mode_indicator_controller.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/chrome/browser/chromeos/login/ui/lock_window.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/chrome/browser/chromeos/login/ui/login_display_host_impl.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/chrome/browser/chromeos/ui/idle_app_name_notification_view.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/chrome/browser/chromeos/ui/kiosk_external_update_notification.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/chrome/browser/media/webrtc/desktop_media_list_ash.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/chrome/browser/ui/ash/chrome_keyboard_ui.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/chrome/browser/ui/ash/system_tray_client.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/chrome/browser/ui/views/tabs/window_finder_ash.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/components/exo/BUILD.gn
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/components/exo/display.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/components/exo/display_unittest.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/components/exo/pointer.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/components/exo/pointer_unittest.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/components/exo/shell_surface.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/components/exo/shell_surface.h
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/components/exo/shell_surface_unittest.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/components/exo/touch_unittest.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/components/exo/wayland/BUILD.gn
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/components/exo/wayland/server.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/mash/DEPS
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/mash/login/BUILD.gn
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/mash/login/login.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/mash/screenlock/BUILD.gn
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/mash/screenlock/screenlock.cc
[modify] https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6/services/ui/public/interfaces/window_manager.mojom

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a3d9e2aeb2beee0db8288d57ff3f473b1841f0e

commit 3a3d9e2aeb2beee0db8288d57ff3f473b1841f0e
Author: jamescook <jamescook@chromium.org>
Date: Mon Oct 24 18:45:38 2016

mash: Migrate ShowSetTimeDialog from SystemTrayDelegate to mojo

This is part of the mustash refactoring of ash.

Migrate to the existing SystemTrayClient mojo interface.

BUG= 647412 
TEST=show time settings via system tray at the login screen

Review-Url: https://codereview.chromium.org/2438023004
Cr-Commit-Position: refs/heads/master@{#427104}

[modify] https://crrev.com/3a3d9e2aeb2beee0db8288d57ff3f473b1841f0e/ash/common/system/date/date_view.cc
[modify] https://crrev.com/3a3d9e2aeb2beee0db8288d57ff3f473b1841f0e/ash/common/system/tray/system_tray_controller.cc
[modify] https://crrev.com/3a3d9e2aeb2beee0db8288d57ff3f473b1841f0e/ash/common/system/tray/system_tray_controller.h
[modify] https://crrev.com/3a3d9e2aeb2beee0db8288d57ff3f473b1841f0e/ash/common/system/tray/system_tray_delegate.cc
[modify] https://crrev.com/3a3d9e2aeb2beee0db8288d57ff3f473b1841f0e/ash/common/system/tray/system_tray_delegate.h
[modify] https://crrev.com/3a3d9e2aeb2beee0db8288d57ff3f473b1841f0e/ash/public/interfaces/system_tray.mojom
[modify] https://crrev.com/3a3d9e2aeb2beee0db8288d57ff3f473b1841f0e/chrome/browser/ui/ash/system_tray_client.cc
[modify] https://crrev.com/3a3d9e2aeb2beee0db8288d57ff3f473b1841f0e/chrome/browser/ui/ash/system_tray_client.h
[modify] https://crrev.com/3a3d9e2aeb2beee0db8288d57ff3f473b1841f0e/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/3a3d9e2aeb2beee0db8288d57ff3f473b1841f0e/chrome/browser/ui/ash/system_tray_delegate_chromeos.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb628c9a68535cd0c7925beae32fada248f9bfff

commit cb628c9a68535cd0c7925beae32fada248f9bfff
Author: jamescook <jamescook@chromium.org>
Date: Wed Oct 26 16:09:18 2016

chromeos: Move ownership of system tray width from chrome to ash

The system tray menu width is customized per locale. Ash should own this
information, not chrome. Move the string that sets the width from
chrome/app/resources/locale_settings.grd to ash/common/strings/ash_strings.grd.

This eliminates the method ash::SystemTrayDelegate::GetSystemTrayMenuWidth()
method so I don't have to refactor it as part of mustash.

BUG= 647412 
TEST=Run chrome with --lang=de, see system menu get wider than in English

Review-Url: https://codereview.chromium.org/2448373002
Cr-Commit-Position: refs/heads/master@{#427703}

[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/ash_strings.grd
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/strings/ash_strings_am.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/strings/ash_strings_ar.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/strings/ash_strings_bg.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/strings/ash_strings_bn.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/strings/ash_strings_ca.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/strings/ash_strings_cs.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/strings/ash_strings_da.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/strings/ash_strings_de.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/strings/ash_strings_el.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/strings/ash_strings_es-419.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/strings/ash_strings_es.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/strings/ash_strings_et.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/strings/ash_strings_fa.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/strings/ash_strings_fi.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/strings/ash_strings_fil.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/strings/ash_strings_fr.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/strings/ash_strings_gu.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/strings/ash_strings_hi.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/strings/ash_strings_hr.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/strings/ash_strings_hu.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/strings/ash_strings_id.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/strings/ash_strings_it.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/strings/ash_strings_iw.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/strings/ash_strings_ja.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/strings/ash_strings_kn.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/strings/ash_strings_ko.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/strings/ash_strings_lt.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/strings/ash_strings_lv.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/strings/ash_strings_ml.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/strings/ash_strings_mr.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/strings/ash_strings_ms.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/strings/ash_strings_nl.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/strings/ash_strings_no.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/strings/ash_strings_pl.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/strings/ash_strings_pt-BR.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/strings/ash_strings_pt-PT.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/strings/ash_strings_ro.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/strings/ash_strings_ru.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/strings/ash_strings_sk.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/strings/ash_strings_sl.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/strings/ash_strings_sr.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/strings/ash_strings_sv.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/strings/ash_strings_sw.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/strings/ash_strings_ta.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/strings/ash_strings_te.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/strings/ash_strings_th.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/strings/ash_strings_tr.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/strings/ash_strings_uk.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/strings/ash_strings_vi.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/strings/ash_strings_zh-CN.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/strings/ash_strings_zh-TW.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/system/tray/default_system_tray_delegate.cc
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/system/tray/default_system_tray_delegate.h
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/system/tray/system_tray.cc
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/system/tray/system_tray_delegate.cc
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/ash/common/system/tray/system_tray_delegate.h
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings.grd
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_am.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_ar.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_bg.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_bn.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_ca.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_cs.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_da.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_de.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_el.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_es-419.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_es.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_et.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_fa.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_fake-bidi.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_fi.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_fil.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_fr.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_gu.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_he.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_hi.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_hr.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_hu.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_id.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_it.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_ja.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_kn.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_ko.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_lt.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_lv.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_ml.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_mr.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_ms.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_nb.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_nl.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_pl.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_pt-BR.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_pt-PT.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_ro.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_ru.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_sk.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_sl.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_sr.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_sv.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_sw.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_ta.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_te.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_th.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_tr.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_uk.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_vi.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_zh-CN.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/app/resources/locale_settings_zh-TW.xtb
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff/chrome/browser/ui/ash/system_tray_delegate_chromeos.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f58a16098b5f14112db1314c6751a8d8715a933

commit 4f58a16098b5f14112db1314c6751a8d8715a933
Author: jamescook <jamescook@chromium.org>
Date: Wed Oct 26 21:59:16 2016

chromeos: Make enterprise help dialog work in mash, part 1

Under mash code in chrome cannot directly access the ash aura window hierarchy.
Instead it must pass an ash window container id when a new window is being
opened.

This eliminates the last use of GetNativeWindow in SystemTrayDelegateChromeos.

Also clean up some include-what-you-use violations.

TODO: Convert system tray enterprise delegate methods to a mojo interface.

BUG= 647412 
TEST=chrome browser_tests. Also, on enterprise enrolled device at the lock
screen click on system tray "This device is managed by..." item and verify
that the help dialog appears on top of the login pods.

Review-Url: https://codereview.chromium.org/2455513003
Cr-Commit-Position: refs/heads/master@{#427835}

[modify] https://crrev.com/4f58a16098b5f14112db1314c6751a8d8715a933/chrome/browser/chromeos/login/help_app_launcher.cc
[modify] https://crrev.com/4f58a16098b5f14112db1314c6751a8d8715a933/chrome/browser/chromeos/login/help_app_launcher.h
[modify] https://crrev.com/4f58a16098b5f14112db1314c6751a8d8715a933/chrome/browser/chromeos/login/ui/login_web_dialog.cc
[modify] https://crrev.com/4f58a16098b5f14112db1314c6751a8d8715a933/chrome/browser/chromeos/login/ui/login_web_dialog.h
[modify] https://crrev.com/4f58a16098b5f14112db1314c6751a8d8715a933/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/4f58a16098b5f14112db1314c6751a8d8715a933/chrome/browser/ui/ash/system_tray_delegate_chromeos.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c17dff06e0421bf73c533d4b3a626ed39585f4da

commit c17dff06e0421bf73c533d4b3a626ed39585f4da
Author: jamescook <jamescook@chromium.org>
Date: Wed Oct 05 23:58:23 2016

chromeos: Don't explicitly set system tray visibility during initialization

This allows SystemTrayDelegate::GetTrayVisibilityOnStartup() to be removed,
so we don't have to port it to mustash.

The visibility is controlled explicitly via chrome's login WizardController
and implicitly by login status changes.

BUG= 647412 
TEST=ash_unittests, chrome browser_tests

Review-Url: https://codereview.chromium.org/2389403003
Cr-Commit-Position: refs/heads/master@{#423344}

[modify] https://crrev.com/c17dff06e0421bf73c533d4b3a626ed39585f4da/ash/common/system/tray/default_system_tray_delegate.cc
[modify] https://crrev.com/c17dff06e0421bf73c533d4b3a626ed39585f4da/ash/common/system/tray/default_system_tray_delegate.h
[modify] https://crrev.com/c17dff06e0421bf73c533d4b3a626ed39585f4da/ash/common/system/tray/system_tray.cc
[modify] https://crrev.com/c17dff06e0421bf73c533d4b3a626ed39585f4da/ash/common/system/tray/system_tray_delegate.cc
[modify] https://crrev.com/c17dff06e0421bf73c533d4b3a626ed39585f4da/ash/common/system/tray/system_tray_delegate.h
[modify] https://crrev.com/c17dff06e0421bf73c533d4b3a626ed39585f4da/ash/shelf/shelf_widget_unittest.cc
[modify] https://crrev.com/c17dff06e0421bf73c533d4b3a626ed39585f4da/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/c17dff06e0421bf73c533d4b3a626ed39585f4da/chrome/browser/ui/ash/system_tray_delegate_chromeos.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9b36ee098ef29022e8e24c2f6faab21dcde5ec5

commit b9b36ee098ef29022e8e24c2f6faab21dcde5ec5
Author: jamescook <jamescook@chromium.org>
Date: Thu Oct 06 18:36:28 2016

chromeos: Refactor system tray ShowNetworkSettingsForGuid for mash

* Add to ash::mojom::SystemTrayClient interface
* Move implementation in chrome browser into SystemTrayClient
* Rename to ShowNetworkSettings with |network_id| because the parameter
|guid| isn't always a GUID.

This unfortunately has to check IsRunningInMash to access the session
state delegate. xiyuan@ is working on a system to replace that delegate,
but for now this is the simplest way.

BUG= 647412 
TEST=browser_tests, manually open network settings from system tray, both
via the Settings button and by clicking on the connected network

Review-Url: https://codereview.chromium.org/2396863004
Cr-Commit-Position: refs/heads/master@{#423600}

[modify] https://crrev.com/b9b36ee098ef29022e8e24c2f6faab21dcde5ec5/ash/common/system/chromeos/network/network_state_list_detailed_view.cc
[modify] https://crrev.com/b9b36ee098ef29022e8e24c2f6faab21dcde5ec5/ash/common/system/tray/system_tray_controller.cc
[modify] https://crrev.com/b9b36ee098ef29022e8e24c2f6faab21dcde5ec5/ash/common/system/tray/system_tray_controller.h
[modify] https://crrev.com/b9b36ee098ef29022e8e24c2f6faab21dcde5ec5/ash/common/system/tray/system_tray_delegate.cc
[modify] https://crrev.com/b9b36ee098ef29022e8e24c2f6faab21dcde5ec5/ash/common/system/tray/system_tray_delegate.h
[modify] https://crrev.com/b9b36ee098ef29022e8e24c2f6faab21dcde5ec5/ash/public/interfaces/system_tray.mojom
[modify] https://crrev.com/b9b36ee098ef29022e8e24c2f6faab21dcde5ec5/chrome/browser/ui/ash/network_connect_delegate_chromeos.cc
[modify] https://crrev.com/b9b36ee098ef29022e8e24c2f6faab21dcde5ec5/chrome/browser/ui/ash/system_tray_client.cc
[modify] https://crrev.com/b9b36ee098ef29022e8e24c2f6faab21dcde5ec5/chrome/browser/ui/ash/system_tray_client.h
[modify] https://crrev.com/b9b36ee098ef29022e8e24c2f6faab21dcde5ec5/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/b9b36ee098ef29022e8e24c2f6faab21dcde5ec5/chrome/browser/ui/ash/system_tray_delegate_chromeos.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/239c1372ce403786415a6a9825b11c2a859d729e

commit 239c1372ce403786415a6a9825b11c2a859d729e
Author: jamescook <jamescook@chromium.org>
Date: Thu Nov 03 15:52:51 2016

Revert of chromeos: Move ownership of system tray width from chrome to ash (patchset #3 id:40001 of https://codereview.chromium.org/2448373002/ )

Reason for revert:
This is breaking one of the translation console tools, see http://crbug.com/660912

We'll need to introduce a new file ash_locale_settings.grd (similar to ui/strings/app_locale_settings.grd) that the translation console tools can skip.

Original issue's description:
> chromeos: Move ownership of system tray width from chrome to ash
>
> The system tray menu width is customized per locale. Ash should own this
> information, not chrome. Move the string that sets the width from
> chrome/app/resources/locale_settings.grd to ash/common/strings/ash_strings.grd.
>
> This eliminates the method ash::SystemTrayDelegate::GetSystemTrayMenuWidth()
> method so I don't have to refactor it as part of mustash.
>
> BUG= 647412 
> TEST=Run chrome with --lang=de, see system menu get wider than in English
>
> Committed: https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff
> Cr-Commit-Position: refs/heads/master@{#427703}

TBR=sky@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 647412 

Review-Url: https://codereview.chromium.org/2468113008
Cr-Commit-Position: refs/heads/master@{#429600}

[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/ash_strings.grd
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/strings/ash_strings_am.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/strings/ash_strings_ar.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/strings/ash_strings_bg.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/strings/ash_strings_bn.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/strings/ash_strings_ca.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/strings/ash_strings_cs.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/strings/ash_strings_da.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/strings/ash_strings_de.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/strings/ash_strings_el.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/strings/ash_strings_es-419.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/strings/ash_strings_es.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/strings/ash_strings_et.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/strings/ash_strings_fa.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/strings/ash_strings_fi.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/strings/ash_strings_fil.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/strings/ash_strings_fr.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/strings/ash_strings_gu.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/strings/ash_strings_hi.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/strings/ash_strings_hr.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/strings/ash_strings_hu.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/strings/ash_strings_id.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/strings/ash_strings_it.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/strings/ash_strings_iw.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/strings/ash_strings_ja.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/strings/ash_strings_kn.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/strings/ash_strings_ko.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/strings/ash_strings_lt.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/strings/ash_strings_lv.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/strings/ash_strings_ml.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/strings/ash_strings_mr.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/strings/ash_strings_ms.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/strings/ash_strings_nl.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/strings/ash_strings_no.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/strings/ash_strings_pl.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/strings/ash_strings_pt-BR.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/strings/ash_strings_pt-PT.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/strings/ash_strings_ro.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/strings/ash_strings_ru.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/strings/ash_strings_sk.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/strings/ash_strings_sl.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/strings/ash_strings_sr.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/strings/ash_strings_sv.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/strings/ash_strings_sw.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/strings/ash_strings_ta.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/strings/ash_strings_te.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/strings/ash_strings_th.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/strings/ash_strings_tr.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/strings/ash_strings_uk.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/strings/ash_strings_vi.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/strings/ash_strings_zh-CN.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/strings/ash_strings_zh-TW.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/system/tray/default_system_tray_delegate.cc
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/system/tray/default_system_tray_delegate.h
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/system/tray/system_tray.cc
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/system/tray/system_tray_delegate.cc
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/ash/common/system/tray/system_tray_delegate.h
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings.grd
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_am.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_ar.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_bg.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_bn.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_ca.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_cs.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_da.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_de.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_el.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_es-419.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_es.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_et.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_fa.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_fake-bidi.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_fi.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_fil.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_fr.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_gu.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_he.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_hi.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_hr.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_hu.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_id.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_it.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_ja.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_kn.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_ko.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_lt.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_lv.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_ml.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_mr.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_ms.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_nb.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_nl.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_pl.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_pt-BR.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_pt-PT.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_ro.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_ru.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_sk.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_sl.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_sr.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_sv.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_sw.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_ta.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_te.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_th.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_tr.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_uk.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_vi.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_zh-CN.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/app/resources/locale_settings_zh-TW.xtb
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e/chrome/browser/ui/ash/system_tray_delegate_chromeos.h

[Automated comment] removing mislabelled merge-merged-2840

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04570b6023aeada35ead88f6488618be307793d1

commit 04570b6023aeada35ead88f6488618be307793d1
Author: jamescook <jamescook@chromium.org>
Date: Thu Nov 10 19:51:59 2016

chromeos: Move SystemTrayDelegate::RequestShutdown to WmShell

For mustash the chrome browser process cannot call directly into ash. The
implementation of this method in chrome's SystemTrayDelegateChromeos just
turns around and calls into ash::LockStateController.

Moving the method allows ash to process these requests internally. The mus
implementation is still NOTIMPLEMENTED because we don't have mus support
for LockStateController and its animations.

After removing another unused method this results in SystemTrayDelegateChromeos
having no ash::Shell references. (It still uses ash::WmShell, though.)

This is part 1 of moving shutdown handling out of chrome into ash.

BUG=644348,  647412 
TEST=Shutdown from system tray still works in classic ash

Review-Url: https://codereview.chromium.org/2491403003
Cr-Commit-Position: refs/heads/master@{#431323}

[modify] https://crrev.com/04570b6023aeada35ead88f6488618be307793d1/ash/aura/wm_shell_aura.cc
[modify] https://crrev.com/04570b6023aeada35ead88f6488618be307793d1/ash/aura/wm_shell_aura.h
[modify] https://crrev.com/04570b6023aeada35ead88f6488618be307793d1/ash/common/system/date/date_default_view.cc
[modify] https://crrev.com/04570b6023aeada35ead88f6488618be307793d1/ash/common/system/tiles/tiles_default_view.cc
[modify] https://crrev.com/04570b6023aeada35ead88f6488618be307793d1/ash/common/system/tray/system_tray_delegate.cc
[modify] https://crrev.com/04570b6023aeada35ead88f6488618be307793d1/ash/common/system/tray/system_tray_delegate.h
[modify] https://crrev.com/04570b6023aeada35ead88f6488618be307793d1/ash/common/wm_shell.h
[modify] https://crrev.com/04570b6023aeada35ead88f6488618be307793d1/ash/mus/bridge/wm_shell_mus.cc
[modify] https://crrev.com/04570b6023aeada35ead88f6488618be307793d1/ash/mus/bridge/wm_shell_mus.h
[modify] https://crrev.com/04570b6023aeada35ead88f6488618be307793d1/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/04570b6023aeada35ead88f6488618be307793d1/chrome/browser/ui/ash/system_tray_delegate_chromeos.h
[modify] https://crrev.com/04570b6023aeada35ead88f6488618be307793d1/chrome/browser/ui/ash/system_tray_delegate_chromeos_browsertest_chromeos.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8fb49c827b29e822a0d45dd6aa9c77ae71aef16e

commit 8fb49c827b29e822a0d45dd6aa9c77ae71aef16e
Author: jamescook <jamescook@chromium.org>
Date: Fri Nov 11 19:04:36 2016

chromeos: Make system tray audio item observe CrasAudioHandler directly

For mustash the chrome browser process will not be able to directly access
code in ash (e.g. WmShell). This CL reduces chrome's dependency on ash
in SystemTrayDelegateChromeos by having the ash TrayAudio class observe
CrasAudioHandler directly.

This also allows one extra layer of observers (ash::AudioObserver) to be
deleted.

WmRootWindowController now exposes SystemTray because ARC++ needs to show
the volume popup sometimes. That has to happen on all monitors, so TrayAudio
needs to be able to iterate through all SystemTrays.

BUG= 661247 , 647412 
TEST=added to ash_unittests, also modified the code to trigger the volume
popup manually and tested at the login screen with an external display, also
tested on device with ARC++ and Netflix app

Review-Url: https://codereview.chromium.org/2489723005
Cr-Commit-Position: refs/heads/master@{#431608}

[modify] https://crrev.com/8fb49c827b29e822a0d45dd6aa9c77ae71aef16e/ash/BUILD.gn
[modify] https://crrev.com/8fb49c827b29e822a0d45dd6aa9c77ae71aef16e/ash/common/BUILD.gn
[delete] https://crrev.com/62fa72cbd02ff4e279efe12145dd4b1a3d221821/ash/common/system/chromeos/audio/audio_observer.h
[modify] https://crrev.com/8fb49c827b29e822a0d45dd6aa9c77ae71aef16e/ash/common/system/chromeos/audio/tray_audio.cc
[modify] https://crrev.com/8fb49c827b29e822a0d45dd6aa9c77ae71aef16e/ash/common/system/chromeos/audio/tray_audio.h
[add] https://crrev.com/8fb49c827b29e822a0d45dd6aa9c77ae71aef16e/ash/common/system/chromeos/audio/tray_audio_unittest.cc
[modify] https://crrev.com/8fb49c827b29e822a0d45dd6aa9c77ae71aef16e/ash/common/system/tray/system_tray_notifier.cc
[modify] https://crrev.com/8fb49c827b29e822a0d45dd6aa9c77ae71aef16e/ash/common/system/tray/system_tray_notifier.h
[modify] https://crrev.com/8fb49c827b29e822a0d45dd6aa9c77ae71aef16e/ash/common/wm_root_window_controller.cc
[modify] https://crrev.com/8fb49c827b29e822a0d45dd6aa9c77ae71aef16e/ash/common/wm_root_window_controller.h
[modify] https://crrev.com/8fb49c827b29e822a0d45dd6aa9c77ae71aef16e/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/8fb49c827b29e822a0d45dd6aa9c77ae71aef16e/chrome/browser/ui/ash/system_tray_delegate_chromeos.h
[modify] https://crrev.com/8fb49c827b29e822a0d45dd6aa9c77ae71aef16e/components/arc/audio/arc_audio_bridge.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9f152f1d2e35a35a726a3891c00a764de144b39

commit d9f152f1d2e35a35a726a3891c00a764de144b39
Author: jamescook <jamescook@chromium.org>
Date: Tue Nov 15 00:53:08 2016

chromeos: Move device shutdown handling out of chrome into ash

Historically device shutdown was handled in chrome because it needed to check
a device "reboot on shutdown" policy during the shutdown process. Under mustash
it is possible to quit the chrome browser and leave ash running, but the old
code required launching chrome in order to shut down.

Moving the code into ash also reduces ash/chrome dependencies and simplifies
the SystemTrayDelegate code I'm trying to refactor.

* The system tray shutdown button computes its "shutdown" vs "reboot" each time
the menu is opened. It no longer changes its tooltip if the policy changed while
the menu was open. The old behavior seemed unnecessary, and doing it this way
avoids a set of policy observers in ash.
* Chrome observes the shutdown policy via ShutdownPolicyHandler. It sends the
initial value to ash via the ash::mojom::ShutdownController mojo interface.
Subsequent policy updates are sent over the same interface.

This partially reverts the ShutdownClient implementation introduced in
https://codereview.chromium.org/2471643002

BUG= 647412 , 628792 
TEST=ash_unittests, chrome unit_tests and browser_tests (ShutdownPolicy*) and
manual testing on device

Review-Url: https://codereview.chromium.org/2497123002
Cr-Commit-Position: refs/heads/master@{#432035}

[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/ash/BUILD.gn
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/ash/common/mojo_interface_factory.cc
[add] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/ash/common/shutdown_controller.cc
[add] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/ash/common/shutdown_controller.h
[delete] https://crrev.com/fd707bac822a15eb606878c7610a62cb53d0f368/ash/common/system/chromeos/shutdown_policy_observer.h
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/ash/common/system/date/date_default_view.cc
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/ash/common/system/date/date_default_view.h
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/ash/common/system/tiles/tiles_default_view.cc
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/ash/common/system/tiles/tiles_default_view.h
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/ash/common/system/tiles/tray_tiles.cc
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/ash/common/system/tiles/tray_tiles.h
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/ash/common/system/tray/system_tray_delegate.cc
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/ash/common/system/tray/system_tray_delegate.h
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/ash/common/wm_shell.cc
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/ash/common/wm_shell.h
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/ash/mus/manifest.json
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/ash/public/interfaces/shutdown.mojom
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/ash/shell.cc
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/ash/test/BUILD.gn
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/ash/test/lock_state_controller_test_api.cc
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/ash/test/lock_state_controller_test_api.h
[delete] https://crrev.com/fd707bac822a15eb606878c7610a62cb53d0f368/ash/test/test_shutdown_client.cc
[delete] https://crrev.com/fd707bac822a15eb606878c7610a62cb53d0f368/ash/test/test_shutdown_client.h
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/ash/wm/lock_state_controller.cc
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/ash/wm/lock_state_controller.h
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/ash/wm/lock_state_controller_unittest.cc
[delete] https://crrev.com/fd707bac822a15eb606878c7610a62cb53d0f368/ash/wm/shutdown_client_proxy.cc
[delete] https://crrev.com/fd707bac822a15eb606878c7610a62cb53d0f368/ash/wm/shutdown_client_proxy.h
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/chrome/app/mash/chrome_mash_content_browser_manifest_overlay.json
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/chrome/browser/chrome_content_browser_manifest_overlay.json
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/chrome/browser/chromeos/chrome_browser_main_chromeos.h
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/chrome/browser/chromeos/chrome_interface_factory.cc
[delete] https://crrev.com/fd707bac822a15eb606878c7610a62cb53d0f368/chrome/browser/chromeos/power/shutdown_client_impl.cc
[delete] https://crrev.com/fd707bac822a15eb606878c7610a62cb53d0f368/chrome/browser/chromeos/power/shutdown_client_impl.h
[add] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/chrome/browser/chromeos/settings/shutdown_policy_forwarder.cc
[add] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/chrome/browser/chromeos/settings/shutdown_policy_forwarder.h
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/chrome/browser/chromeos/settings/shutdown_policy_handler.cc
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/chrome/browser/chromeos/settings/shutdown_policy_handler.h
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/chrome/browser/chromeos/settings/shutdown_policy_handler_unittest.cc
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/chrome/browser/chromeos/shutdown_policy_browsertest.cc
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/chrome/browser/ui/ash/system_tray_delegate_chromeos.h
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/chrome/browser/ui/webui/chromeos/login/oobe_ui.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d43d5cad3f5a3533da527401200271a4f9524e5

commit 1d43d5cad3f5a3533da527401200271a4f9524e5
Author: jamescook <jamescook@chromium.org>
Date: Tue Nov 15 23:55:08 2016

chromeos: Migrate SignOut and RequestRestartForUpdate to mojo interface

Under mustash the ash shell runs in a different process than chrome browser.
This migrates 2 methods from the in-process synchronous SystemTrayDelegate
to the mojo SystemTrayClient interface.

The implementations of these methods do a moderate amount of work inside
Chrome, so they did not seem like good candidates to try to implement inside
of ash itself. Ideally they methods would live in a user or login service,
but we don't have that yet either.

BUG= 647412 
TEST=existing ash_unittests and chrome unit_tests

Review-Url: https://codereview.chromium.org/2505783002
Cr-Commit-Position: refs/heads/master@{#432295}

[modify] https://crrev.com/1d43d5cad3f5a3533da527401200271a4f9524e5/ash/common/system/chromeos/session/logout_button_tray.cc
[modify] https://crrev.com/1d43d5cad3f5a3533da527401200271a4f9524e5/ash/common/system/tray/system_tray_controller.cc
[modify] https://crrev.com/1d43d5cad3f5a3533da527401200271a4f9524e5/ash/common/system/tray/system_tray_controller.h
[modify] https://crrev.com/1d43d5cad3f5a3533da527401200271a4f9524e5/ash/common/system/tray/system_tray_delegate.cc
[modify] https://crrev.com/1d43d5cad3f5a3533da527401200271a4f9524e5/ash/common/system/tray/system_tray_delegate.h
[modify] https://crrev.com/1d43d5cad3f5a3533da527401200271a4f9524e5/ash/common/system/update/tray_update.cc
[modify] https://crrev.com/1d43d5cad3f5a3533da527401200271a4f9524e5/ash/common/system/user/user_view.cc
[modify] https://crrev.com/1d43d5cad3f5a3533da527401200271a4f9524e5/ash/common/test/test_system_tray_delegate.cc
[modify] https://crrev.com/1d43d5cad3f5a3533da527401200271a4f9524e5/ash/common/test/test_system_tray_delegate.h
[modify] https://crrev.com/1d43d5cad3f5a3533da527401200271a4f9524e5/ash/common/wm_shell.cc
[modify] https://crrev.com/1d43d5cad3f5a3533da527401200271a4f9524e5/ash/public/interfaces/system_tray.mojom
[modify] https://crrev.com/1d43d5cad3f5a3533da527401200271a4f9524e5/chrome/browser/ui/ash/system_tray_client.cc
[modify] https://crrev.com/1d43d5cad3f5a3533da527401200271a4f9524e5/chrome/browser/ui/ash/system_tray_client.h
[modify] https://crrev.com/1d43d5cad3f5a3533da527401200271a4f9524e5/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/1d43d5cad3f5a3533da527401200271a4f9524e5/chrome/browser/ui/ash/system_tray_delegate_chromeos.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9dac09552e919158ba3654c64155dc0903bb8ace

commit 9dac09552e919158ba3654c64155dc0903bb8ace
Author: yutak <yutak@chromium.org>
Date: Tue Dec 13 05:37:48 2016

Revert of ash: Use system tray mojo interface to show system update tray icon (patchset #6 id:100001 of https://codereview.chromium.org/2558043006/ )

Reason for revert:
Broke compile on Google Chrome ChromeOS:

https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/26896

../../chrome/browser/component_updater/pepper_flash_component_installer.cc:94:3: error: no type named 'SystemTrayClient' in namespace 'chromeos'; did you mean simply 'SystemTrayClient'?
  chromeos::SystemTrayClient* tray = chromeos::SystemTrayClient::Get();
  ^~~~~~~~~~~~~~~~~~~~~~~~~~
  SystemTrayClient
../../chrome/browser/ui/ash/system_tray_client.h:27:7: note: 'SystemTrayClient' declared here
class SystemTrayClient : public ash::mojom::SystemTrayClient,
      ^
../../chrome/browser/component_updater/pepper_flash_component_installer.cc:94:38: error: no member named 'SystemTrayClient' in namespace 'chromeos'; did you mean simply 'SystemTrayClient'?
  chromeos::SystemTrayClient* tray = chromeos::SystemTrayClient::Get();
                                     ^~~~~~~~~~~~~~~~~~~~~~~~~~
                                     SystemTrayClient
../../chrome/browser/ui/ash/system_tray_client.h:27:7: note: 'SystemTrayClient' declared here
class SystemTrayClient : public ash::mojom::SystemTrayClient,
      ^
2 errors generated.

Original issue's description:
> ash: Use system tray mojo interface to show system update tray icon
>
> Change the flow so that Chrome explicitly asks ash to show the icon
> rather than having ash ask Chrome whether there is an update available.
>
> * Add ShowUpdateIcon to system_tray.mojom
> * Introduce update.mojom
> * Migrate ash to using ash::mojom::UpdateSeverity internally
> * Migrate update methods from SystemTrayDelegate to SystemTrayClient
> * Add a new SystemTrayClientTest and move existing Flash test there
>
> Also add docs for SystemTrayItem (used by TrayUpdate) since tray view
> vs. default view vs. detailed view always confuses me.
>
> BUG= 647412 
> TEST=chrome browser_tests, ash_unittests
>
> Committed: https://crrev.com/196ee3b66b3700733cecb8472d63d872d99e3783
> Cr-Commit-Position: refs/heads/master@{#438051}

TBR=msw@chromium.org,kerrnel@chromium.org,tsepez@chromium.org,waffles@chromium.org,sky@chromium.org,jamescook@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 647412 

Review-Url: https://codereview.chromium.org/2568413002
Cr-Commit-Position: refs/heads/master@{#438064}

[modify] https://crrev.com/9dac09552e919158ba3654c64155dc0903bb8ace/ash/BUILD.gn
[modify] https://crrev.com/9dac09552e919158ba3654c64155dc0903bb8ace/ash/common/system/tray/default_system_tray_delegate.cc
[modify] https://crrev.com/9dac09552e919158ba3654c64155dc0903bb8ace/ash/common/system/tray/default_system_tray_delegate.h
[modify] https://crrev.com/9dac09552e919158ba3654c64155dc0903bb8ace/ash/common/system/tray/system_tray.cc
[modify] https://crrev.com/9dac09552e919158ba3654c64155dc0903bb8ace/ash/common/system/tray/system_tray.h
[modify] https://crrev.com/9dac09552e919158ba3654c64155dc0903bb8ace/ash/common/system/tray/system_tray_controller.cc
[modify] https://crrev.com/9dac09552e919158ba3654c64155dc0903bb8ace/ash/common/system/tray/system_tray_controller.h
[modify] https://crrev.com/9dac09552e919158ba3654c64155dc0903bb8ace/ash/common/system/tray/system_tray_delegate.cc
[modify] https://crrev.com/9dac09552e919158ba3654c64155dc0903bb8ace/ash/common/system/tray/system_tray_delegate.h
[modify] https://crrev.com/9dac09552e919158ba3654c64155dc0903bb8ace/ash/common/system/tray/system_tray_item.h
[modify] https://crrev.com/9dac09552e919158ba3654c64155dc0903bb8ace/ash/common/system/tray/system_tray_notifier.cc
[modify] https://crrev.com/9dac09552e919158ba3654c64155dc0903bb8ace/ash/common/system/tray/system_tray_notifier.h
[modify] https://crrev.com/9dac09552e919158ba3654c64155dc0903bb8ace/ash/common/system/tray/tray_image_item.h
[modify] https://crrev.com/9dac09552e919158ba3654c64155dc0903bb8ace/ash/common/system/update/tray_update.cc
[modify] https://crrev.com/9dac09552e919158ba3654c64155dc0903bb8ace/ash/common/system/update/tray_update.h
[modify] https://crrev.com/9dac09552e919158ba3654c64155dc0903bb8ace/ash/common/system/update/tray_update_unittest.cc
[add] https://crrev.com/9dac09552e919158ba3654c64155dc0903bb8ace/ash/common/system/update/update_observer.h
[modify] https://crrev.com/9dac09552e919158ba3654c64155dc0903bb8ace/ash/common/test/test_system_tray_delegate.cc
[modify] https://crrev.com/9dac09552e919158ba3654c64155dc0903bb8ace/ash/common/test/test_system_tray_delegate.h
[modify] https://crrev.com/9dac09552e919158ba3654c64155dc0903bb8ace/ash/public/interfaces/BUILD.gn
[modify] https://crrev.com/9dac09552e919158ba3654c64155dc0903bb8ace/ash/public/interfaces/system_tray.mojom
[delete] https://crrev.com/82298e59225ddfab0402b77c265624acb29632a4/ash/public/interfaces/update.mojom
[modify] https://crrev.com/9dac09552e919158ba3654c64155dc0903bb8ace/chrome/browser/component_updater/pepper_flash_component_installer.cc
[modify] https://crrev.com/9dac09552e919158ba3654c64155dc0903bb8ace/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/9dac09552e919158ba3654c64155dc0903bb8ace/chrome/browser/ui/ash/system_tray_client.cc
[modify] https://crrev.com/9dac09552e919158ba3654c64155dc0903bb8ace/chrome/browser/ui/ash/system_tray_client.h
[delete] https://crrev.com/82298e59225ddfab0402b77c265624acb29632a4/chrome/browser/ui/ash/system_tray_client_browsertest.cc
[modify] https://crrev.com/9dac09552e919158ba3654c64155dc0903bb8ace/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/9dac09552e919158ba3654c64155dc0903bb8ace/chrome/browser/ui/ash/system_tray_delegate_chromeos.h
[modify] https://crrev.com/9dac09552e919158ba3654c64155dc0903bb8ace/chrome/browser/ui/ash/system_tray_delegate_chromeos_browsertest_chromeos.cc
[add] https://crrev.com/9dac09552e919158ba3654c64155dc0903bb8ace/chrome/browser/ui/ash/system_tray_delegate_utils.cc
[add] https://crrev.com/9dac09552e919158ba3654c64155dc0903bb8ace/chrome/browser/ui/ash/system_tray_delegate_utils.h
[modify] https://crrev.com/9dac09552e919158ba3654c64155dc0903bb8ace/chrome/browser/upgrade_detector.h
[modify] https://crrev.com/9dac09552e919158ba3654c64155dc0903bb8ace/chrome/test/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8054778c11c1a356d7588fa7d96b1964b68acc40

commit 8054778c11c1a356d7588fa7d96b1964b68acc40
Author: jamescook <jamescook@chromium.org>
Date: Tue Dec 13 18:35:29 2016

Reland: ash: Use system tray mojo interface to show system update tray icon

crrev.com/2558043006 was reverted for compile failure in the official build.
I made a namespace mistake in a component updater file that is only compiled in
official builds.

Original description:
Change the flow so that Chrome explicitly asks ash to show the icon
rather than having ash ask Chrome whether there is an update available.

* Add ShowUpdateIcon to system_tray.mojom
* Introduce update.mojom
* Migrate ash to using ash::mojom::UpdateSeverity internally
* Migrate update methods from SystemTrayDelegate to SystemTrayClient
* Add a new SystemTrayClientTest and move existing Flash test there

Also add docs for SystemTrayItem (used by TrayUpdate) since tray view
vs. default view vs. detailed view always confuses me.

BUG= 647412 
TEST=chrome browser_tests, ash_unittests
TBR=msw@chromium.org

Review-Url: https://codereview.chromium.org/2570033004
Cr-Commit-Position: refs/heads/master@{#438233}

[modify] https://crrev.com/8054778c11c1a356d7588fa7d96b1964b68acc40/ash/BUILD.gn
[modify] https://crrev.com/8054778c11c1a356d7588fa7d96b1964b68acc40/ash/common/system/tray/default_system_tray_delegate.cc
[modify] https://crrev.com/8054778c11c1a356d7588fa7d96b1964b68acc40/ash/common/system/tray/default_system_tray_delegate.h
[modify] https://crrev.com/8054778c11c1a356d7588fa7d96b1964b68acc40/ash/common/system/tray/system_tray.cc
[modify] https://crrev.com/8054778c11c1a356d7588fa7d96b1964b68acc40/ash/common/system/tray/system_tray.h
[modify] https://crrev.com/8054778c11c1a356d7588fa7d96b1964b68acc40/ash/common/system/tray/system_tray_controller.cc
[modify] https://crrev.com/8054778c11c1a356d7588fa7d96b1964b68acc40/ash/common/system/tray/system_tray_controller.h
[modify] https://crrev.com/8054778c11c1a356d7588fa7d96b1964b68acc40/ash/common/system/tray/system_tray_delegate.cc
[modify] https://crrev.com/8054778c11c1a356d7588fa7d96b1964b68acc40/ash/common/system/tray/system_tray_delegate.h
[modify] https://crrev.com/8054778c11c1a356d7588fa7d96b1964b68acc40/ash/common/system/tray/system_tray_item.h
[modify] https://crrev.com/8054778c11c1a356d7588fa7d96b1964b68acc40/ash/common/system/tray/system_tray_notifier.cc
[modify] https://crrev.com/8054778c11c1a356d7588fa7d96b1964b68acc40/ash/common/system/tray/system_tray_notifier.h
[modify] https://crrev.com/8054778c11c1a356d7588fa7d96b1964b68acc40/ash/common/system/tray/tray_image_item.h
[modify] https://crrev.com/8054778c11c1a356d7588fa7d96b1964b68acc40/ash/common/system/update/tray_update.cc
[modify] https://crrev.com/8054778c11c1a356d7588fa7d96b1964b68acc40/ash/common/system/update/tray_update.h
[modify] https://crrev.com/8054778c11c1a356d7588fa7d96b1964b68acc40/ash/common/system/update/tray_update_unittest.cc
[delete] https://crrev.com/212e4d886c91da74f296758d62c7d6a5ef87fae1/ash/common/system/update/update_observer.h
[modify] https://crrev.com/8054778c11c1a356d7588fa7d96b1964b68acc40/ash/common/test/test_system_tray_delegate.cc
[modify] https://crrev.com/8054778c11c1a356d7588fa7d96b1964b68acc40/ash/common/test/test_system_tray_delegate.h
[modify] https://crrev.com/8054778c11c1a356d7588fa7d96b1964b68acc40/ash/public/interfaces/BUILD.gn
[modify] https://crrev.com/8054778c11c1a356d7588fa7d96b1964b68acc40/ash/public/interfaces/system_tray.mojom
[add] https://crrev.com/8054778c11c1a356d7588fa7d96b1964b68acc40/ash/public/interfaces/update.mojom
[modify] https://crrev.com/8054778c11c1a356d7588fa7d96b1964b68acc40/chrome/browser/component_updater/pepper_flash_component_installer.cc
[modify] https://crrev.com/8054778c11c1a356d7588fa7d96b1964b68acc40/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/8054778c11c1a356d7588fa7d96b1964b68acc40/chrome/browser/ui/ash/system_tray_client.cc
[modify] https://crrev.com/8054778c11c1a356d7588fa7d96b1964b68acc40/chrome/browser/ui/ash/system_tray_client.h
[add] https://crrev.com/8054778c11c1a356d7588fa7d96b1964b68acc40/chrome/browser/ui/ash/system_tray_client_browsertest.cc
[modify] https://crrev.com/8054778c11c1a356d7588fa7d96b1964b68acc40/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/8054778c11c1a356d7588fa7d96b1964b68acc40/chrome/browser/ui/ash/system_tray_delegate_chromeos.h
[modify] https://crrev.com/8054778c11c1a356d7588fa7d96b1964b68acc40/chrome/browser/ui/ash/system_tray_delegate_chromeos_browsertest_chromeos.cc
[delete] https://crrev.com/212e4d886c91da74f296758d62c7d6a5ef87fae1/chrome/browser/ui/ash/system_tray_delegate_utils.cc
[delete] https://crrev.com/212e4d886c91da74f296758d62c7d6a5ef87fae1/chrome/browser/ui/ash/system_tray_delegate_utils.h
[modify] https://crrev.com/8054778c11c1a356d7588fa7d96b1964b68acc40/chrome/browser/upgrade_detector.h
[modify] https://crrev.com/8054778c11c1a356d7588fa7d96b1964b68acc40/chrome/test/BUILD.gn

On hold while working on crash reporting.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ea8cc012d4771fb1f418d5f9a266285e9c286f9

commit 0ea8cc012d4771fb1f418d5f9a266285e9c286f9
Author: jamescook <jamescook@chromium.org>
Date: Thu May 18 20:45:59 2017

chromeos: Remove ash::SystemTrayDelegate::CreateTrayRotationLock

This exists for mash. It was added before ash::Shell::GetAshConfig existed.
It doesn't need to be on the ash-to-chrome delegate.

BUG= 647412 
TEST=ash_unittests, manual test of chrome --mus and --mash by entering
touch-view mode with Ctrl-Alt-Shift-T

Review-Url: https://codereview.chromium.org/2888983003
Cr-Commit-Position: refs/heads/master@{#472921}

[modify] https://crrev.com/0ea8cc012d4771fb1f418d5f9a266285e9c286f9/ash/system/tray/system_tray.cc
[modify] https://crrev.com/0ea8cc012d4771fb1f418d5f9a266285e9c286f9/ash/system/tray/system_tray_delegate.cc
[modify] https://crrev.com/0ea8cc012d4771fb1f418d5f9a266285e9c286f9/ash/system/tray/system_tray_delegate.h
[modify] https://crrev.com/0ea8cc012d4771fb1f418d5f9a266285e9c286f9/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/0ea8cc012d4771fb1f418d5f9a266285e9c286f9/chrome/browser/ui/ash/system_tray_delegate_chromeos.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1c01285ae7dcacf0badfab7d7f469e849a1c9cd

commit a1c01285ae7dcacf0badfab7d7f469e849a1c9cd
Author: James Cook <jamescook@chromium.org>
Date: Mon Jul 10 19:01:53 2017

chromeos: Make multi-profile add user dialog work with mash

For go/mustash we have to use mojo interfaces to communicate between
the ash process and chrome browser. Add a mojo method to show the
dialog.

Migrate code from SystemTrayDelegateChromeOS (deprecated and doesn't
exist in mash) and ChromeShellClient (also doesn't exist in mash)
into SessionControllerClient.

This helps consolidate more session-related code into
SessionControllerClient and reduce the size of SystemTrayDelegate.

TBR=oshima@chromium.org

Bug:  647412 
Test: existing ash and chrome tests
Change-Id: I1f65f43a4fe668095325ad20c8dc0c201f706321
Reviewed-on: https://chromium-review.googlesource.com/557935
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485334}
[modify] https://crrev.com/a1c01285ae7dcacf0badfab7d7f469e849a1c9cd/ash/mus/shell_delegate_mus.cc
[modify] https://crrev.com/a1c01285ae7dcacf0badfab7d7f469e849a1c9cd/ash/public/interfaces/session_controller.mojom
[modify] https://crrev.com/a1c01285ae7dcacf0badfab7d7f469e849a1c9cd/ash/session/session_controller.cc
[modify] https://crrev.com/a1c01285ae7dcacf0badfab7d7f469e849a1c9cd/ash/session/session_controller.h
[modify] https://crrev.com/a1c01285ae7dcacf0badfab7d7f469e849a1c9cd/ash/system/tray/system_tray_delegate.cc
[modify] https://crrev.com/a1c01285ae7dcacf0badfab7d7f469e849a1c9cd/ash/system/tray/system_tray_delegate.h
[modify] https://crrev.com/a1c01285ae7dcacf0badfab7d7f469e849a1c9cd/ash/system/user/user_view.cc
[modify] https://crrev.com/a1c01285ae7dcacf0badfab7d7f469e849a1c9cd/ash/test/test_session_controller_client.cc
[modify] https://crrev.com/a1c01285ae7dcacf0badfab7d7f469e849a1c9cd/ash/test/test_session_controller_client.h
[modify] https://crrev.com/a1c01285ae7dcacf0badfab7d7f469e849a1c9cd/chrome/browser/chromeos/profiles/avatar_menu_actions_chromeos.cc
[modify] https://crrev.com/a1c01285ae7dcacf0badfab7d7f469e849a1c9cd/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/a1c01285ae7dcacf0badfab7d7f469e849a1c9cd/chrome/browser/ui/ash/session_controller_client.cc
[modify] https://crrev.com/a1c01285ae7dcacf0badfab7d7f469e849a1c9cd/chrome/browser/ui/ash/session_controller_client.h
[modify] https://crrev.com/a1c01285ae7dcacf0badfab7d7f469e849a1c9cd/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/a1c01285ae7dcacf0badfab7d7f469e849a1c9cd/chrome/browser/ui/ash/system_tray_delegate_chromeos.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b50959e262f758c29763a713e840f18d609ac65b

commit b50959e262f758c29763a713e840f18d609ac65b
Author: James Cook <jamescook@chromium.org>
Date: Thu Aug 10 20:24:38 2017

cros: Refactor public session last window closed dialog for mash

For mustash we can't access ash code directly from chrome. Instead of
having SystemTrayDelegateChromeOS monitor for browser and app windows
closing, have ash watch for the default window containers becoming
empty. This has the same effect from the user's perspective (the users
closes all visible windows and a dialog appears) but is more suited to
a world where ARC++ and mojo apps might open windows.

Bug:  278247 ,  647412 
Test: existing browser_tests, also added to ash_unittests
Change-Id: Ic941eded4cde16a73976d6be7e1ad39bcbe8c214
Reviewed-on: https://chromium-review.googlesource.com/608577
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493509}
[modify] https://crrev.com/b50959e262f758c29763a713e840f18d609ac65b/ash/BUILD.gn
[modify] https://crrev.com/b50959e262f758c29763a713e840f18d609ac65b/ash/shell.cc
[delete] https://crrev.com/fb087f7e088a3fdc47c8fcfbd8f4ad37c20b53d8/ash/system/session/last_window_closed_observer.h
[modify] https://crrev.com/b50959e262f758c29763a713e840f18d609ac65b/ash/system/session/logout_confirmation_controller.cc
[modify] https://crrev.com/b50959e262f758c29763a713e840f18d609ac65b/ash/system/session/logout_confirmation_controller.h
[modify] https://crrev.com/b50959e262f758c29763a713e840f18d609ac65b/ash/system/session/logout_confirmation_controller_unittest.cc
[modify] https://crrev.com/b50959e262f758c29763a713e840f18d609ac65b/ash/system/tray/system_tray_delegate.cc
[modify] https://crrev.com/b50959e262f758c29763a713e840f18d609ac65b/ash/system/tray/system_tray_delegate.h
[modify] https://crrev.com/b50959e262f758c29763a713e840f18d609ac65b/ash/system/tray/system_tray_notifier.cc
[modify] https://crrev.com/b50959e262f758c29763a713e840f18d609ac65b/ash/system/tray/system_tray_notifier.h
[modify] https://crrev.com/b50959e262f758c29763a713e840f18d609ac65b/ash/test/ash_test_base.h
[modify] https://crrev.com/b50959e262f758c29763a713e840f18d609ac65b/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/b50959e262f758c29763a713e840f18d609ac65b/chrome/browser/ui/ash/system_tray_delegate_chromeos.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc97f0a9755699124c5f8d0886ac275c6276827c

commit fc97f0a9755699124c5f8d0886ac275c6276827c
Author: James Cook <jamescook@chromium.org>
Date: Wed Aug 16 20:05:35 2017

cros: Move accessibility prefs code out of SystemTrayDelegate

For go/mustash code in ash and code in chrome run in different processes,
so ash cannot use SystemTrayDelegate to call back into chrome.

Move the code that monitors prefs into AccessibilityManager, where other
prefs are monitored. AccessibilityManager is already doing the profile
switch monitoring for login and multiprofile, so this reduces code
duplication and consolidates all the prefs code in one place.

Bug:  647412 , 755631
Test: existing browser_tests
Change-Id: Id71a601f5ffe741a6a4bc19c8d901cb47f749a4e
Reviewed-on: https://chromium-review.googlesource.com/615680
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494914}
[modify] https://crrev.com/fc97f0a9755699124c5f8d0886ac275c6276827c/ash/system/accessibility_observer.h
[modify] https://crrev.com/fc97f0a9755699124c5f8d0886ac275c6276827c/ash/system/tray/system_tray_delegate.cc
[modify] https://crrev.com/fc97f0a9755699124c5f8d0886ac275c6276827c/ash/system/tray/system_tray_delegate.h
[modify] https://crrev.com/fc97f0a9755699124c5f8d0886ac275c6276827c/ash/system/tray/system_tray_notifier.h
[modify] https://crrev.com/fc97f0a9755699124c5f8d0886ac275c6276827c/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/fc97f0a9755699124c5f8d0886ac275c6276827c/chrome/browser/chromeos/accessibility/accessibility_manager.h
[modify] https://crrev.com/fc97f0a9755699124c5f8d0886ac275c6276827c/chrome/browser/chromeos/accessibility/accessibility_manager_browsertest.cc
[modify] https://crrev.com/fc97f0a9755699124c5f8d0886ac275c6276827c/chrome/browser/chromeos/system/tray_accessibility_browsertest.cc
[modify] https://crrev.com/fc97f0a9755699124c5f8d0886ac275c6276827c/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc
[modify] https://crrev.com/fc97f0a9755699124c5f8d0886ac275c6276827c/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/fc97f0a9755699124c5f8d0886ac275c6276827c/chrome/browser/ui/ash/system_tray_delegate_chromeos.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d5b29ff7965b351bd5761d68200fe381bb48a7e

commit 8d5b29ff7965b351bd5761d68200fe381bb48a7e
Author: James Cook <jamescook@chromium.org>
Date: Wed Aug 16 21:19:06 2017

cros: Eliminate SystemTrayDelegate

For go/mustash we're eliminating in-process ash-to-chrome delegates.
This kills SystemTrayDelegate and moves its one remaining method (for
construction of another delegate) to ShellDelegate.

Bug:  647412 
Test: ash_unittests, browser_tests
Change-Id: I44f16ed8181cb6e3c3db5cd290d4bc7a03f301d0
Reviewed-on: https://chromium-review.googlesource.com/616172
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494952}
[modify] https://crrev.com/8d5b29ff7965b351bd5761d68200fe381bb48a7e/ash/BUILD.gn
[modify] https://crrev.com/8d5b29ff7965b351bd5761d68200fe381bb48a7e/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/8d5b29ff7965b351bd5761d68200fe381bb48a7e/ash/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/8d5b29ff7965b351bd5761d68200fe381bb48a7e/ash/accelerators/accelerator_interactive_uitest_chromeos.cc
[modify] https://crrev.com/8d5b29ff7965b351bd5761d68200fe381bb48a7e/ash/magnifier/magnification_controller.cc
[modify] https://crrev.com/8d5b29ff7965b351bd5761d68200fe381bb48a7e/ash/mus/BUILD.gn
[modify] https://crrev.com/8d5b29ff7965b351bd5761d68200fe381bb48a7e/ash/mus/bridge/shell_port_mash.cc
[modify] https://crrev.com/8d5b29ff7965b351bd5761d68200fe381bb48a7e/ash/mus/shell_delegate_mus.cc
[modify] https://crrev.com/8d5b29ff7965b351bd5761d68200fe381bb48a7e/ash/mus/shell_delegate_mus.h
[delete] https://crrev.com/0d2c6b7e1e958b407d93b527c3eb30b997e5e7df/ash/mus/system_tray_delegate_mus.cc
[delete] https://crrev.com/0d2c6b7e1e958b407d93b527c3eb30b997e5e7df/ash/mus/system_tray_delegate_mus.h
[modify] https://crrev.com/8d5b29ff7965b351bd5761d68200fe381bb48a7e/ash/root_window_controller.cc
[modify] https://crrev.com/8d5b29ff7965b351bd5761d68200fe381bb48a7e/ash/shell.cc
[modify] https://crrev.com/8d5b29ff7965b351bd5761d68200fe381bb48a7e/ash/shell.h
[modify] https://crrev.com/8d5b29ff7965b351bd5761d68200fe381bb48a7e/ash/shell/shell_delegate_impl.cc
[modify] https://crrev.com/8d5b29ff7965b351bd5761d68200fe381bb48a7e/ash/shell/shell_delegate_impl.h
[modify] https://crrev.com/8d5b29ff7965b351bd5761d68200fe381bb48a7e/ash/shell_delegate.h
[modify] https://crrev.com/8d5b29ff7965b351bd5761d68200fe381bb48a7e/ash/system/bluetooth/tray_bluetooth_helper_unittest.cc
[modify] https://crrev.com/8d5b29ff7965b351bd5761d68200fe381bb48a7e/ash/system/brightness/tray_brightness_unittest.cc
[modify] https://crrev.com/8d5b29ff7965b351bd5761d68200fe381bb48a7e/ash/system/cast/tray_cast_test_api.cc
[modify] https://crrev.com/8d5b29ff7965b351bd5761d68200fe381bb48a7e/ash/system/keyboard_brightness/tray_keyboard_brightness_unittest.cc
[modify] https://crrev.com/8d5b29ff7965b351bd5761d68200fe381bb48a7e/ash/system/network/network_list.cc
[modify] https://crrev.com/8d5b29ff7965b351bd5761d68200fe381bb48a7e/ash/system/network/tray_network.cc
[modify] https://crrev.com/8d5b29ff7965b351bd5761d68200fe381bb48a7e/ash/system/network/tray_vpn.cc
[modify] https://crrev.com/8d5b29ff7965b351bd5761d68200fe381bb48a7e/ash/system/power/tray_power.cc
[modify] https://crrev.com/8d5b29ff7965b351bd5761d68200fe381bb48a7e/ash/system/rotation/tray_rotation_lock_unittest.cc
[modify] https://crrev.com/8d5b29ff7965b351bd5761d68200fe381bb48a7e/ash/system/status_area_widget.cc
[modify] https://crrev.com/8d5b29ff7965b351bd5761d68200fe381bb48a7e/ash/system/tray/system_tray.cc
[modify] https://crrev.com/8d5b29ff7965b351bd5761d68200fe381bb48a7e/ash/system/tray/system_tray.h
[modify] https://crrev.com/8d5b29ff7965b351bd5761d68200fe381bb48a7e/ash/system/tray/system_tray_bubble.cc
[modify] https://crrev.com/8d5b29ff7965b351bd5761d68200fe381bb48a7e/ash/system/tray/system_tray_controller.h
[delete] https://crrev.com/0d2c6b7e1e958b407d93b527c3eb30b997e5e7df/ash/system/tray/system_tray_delegate.cc
[delete] https://crrev.com/0d2c6b7e1e958b407d93b527c3eb30b997e5e7df/ash/system/tray/system_tray_delegate.h
[modify] https://crrev.com/8d5b29ff7965b351bd5761d68200fe381bb48a7e/ash/system/tray/system_tray_item.cc
[modify] https://crrev.com/8d5b29ff7965b351bd5761d68200fe381bb48a7e/ash/system/tray_caps_lock.cc
[modify] https://crrev.com/8d5b29ff7965b351bd5761d68200fe381bb48a7e/ash/system/update/tray_update.cc
[modify] https://crrev.com/8d5b29ff7965b351bd5761d68200fe381bb48a7e/ash/system/web_notification/web_notification_tray.cc
[modify] https://crrev.com/8d5b29ff7965b351bd5761d68200fe381bb48a7e/ash/test_shell_delegate.cc
[modify] https://crrev.com/8d5b29ff7965b351bd5761d68200fe381bb48a7e/ash/test_shell_delegate.h
[modify] https://crrev.com/8d5b29ff7965b351bd5761d68200fe381bb48a7e/ash/wm/system_gesture_event_filter_unittest.cc
[modify] https://crrev.com/8d5b29ff7965b351bd5761d68200fe381bb48a7e/ash/wm/tablet_mode/tablet_mode_controller_unittest.cc
[modify] https://crrev.com/8d5b29ff7965b351bd5761d68200fe381bb48a7e/chrome/browser/chromeos/first_run/drive_first_run_controller.cc
[modify] https://crrev.com/8d5b29ff7965b351bd5761d68200fe381bb48a7e/chrome/browser/chromeos/first_run/drive_first_run_controller.h
[modify] https://crrev.com/8d5b29ff7965b351bd5761d68200fe381bb48a7e/chrome/browser/chromeos/system/system_clock.h
[modify] https://crrev.com/8d5b29ff7965b351bd5761d68200fe381bb48a7e/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/8d5b29ff7965b351bd5761d68200fe381bb48a7e/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/8d5b29ff7965b351bd5761d68200fe381bb48a7e/chrome/browser/ui/ash/chrome_shell_delegate.h
[modify] https://crrev.com/8d5b29ff7965b351bd5761d68200fe381bb48a7e/chrome/browser/ui/ash/system_tray_client.cc
[delete] https://crrev.com/0d2c6b7e1e958b407d93b527c3eb30b997e5e7df/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[delete] https://crrev.com/0d2c6b7e1e958b407d93b527c3eb30b997e5e7df/chrome/browser/ui/ash/system_tray_delegate_chromeos.h
[modify] https://crrev.com/8d5b29ff7965b351bd5761d68200fe381bb48a7e/chrome/browser/ui/ash/system_tray_tray_cast_browsertest_media_router_chromeos.cc

Done!