New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 647411 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 689198



Sign in to add a comment

Allow Material Design OOBE for all devices

Project Member Reported by drcrash@chromium.org, Sep 15 2016

Issue description

As of now, devices showing the HID screen have the MD OOBE disabled.
 
Owner: drcrash@chromium.org
Status: Assigned (was: Untriaged)
https://codereview.chromium.org/2600983003/ has landed, so https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/wizard_controller.cc?rcl=0&l=342 should probably be removed.

Could you verify that is can be removed (and remove it if it is not needed anymore)?
Labels: -Pri-3 Pri-1
Cc: zalcorn@chromium.org gkihumba@chromium.org
Labels: ReleaseBlock-Beta M-59 OS-Chrome
Owner: alemate@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/333e43abd4855a0ae2912fb1e517e0813bd00005

commit 333e43abd4855a0ae2912fb1e517e0813bd00005
Author: alemate <alemate@chromium.org>
Date: Wed Apr 26 11:57:49 2017

Chrome OS: turn on MD-OOBE for CfM devices.

BUG= 647411 

Review-Url: https://codereview.chromium.org/2843723004
Cr-Commit-Position: refs/heads/master@{#467302}

[modify] https://crrev.com/333e43abd4855a0ae2912fb1e517e0813bd00005/chrome/browser/chromeos/login/wizard_controller.cc

Comment 5 by gkihumba@google.com, Apr 26 2017

Please request merge to M59
Labels: Merge-Request-59
Cc: harpreet@chromium.org
+harpreet FYI
Status: Fixed (was: Assigned)
Project Member

Comment 9 by sheriffbot@chromium.org, Apr 27 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
BTW: Please note that I didn't actually enable it for "ALL" devices.
Shark requisition / Remora pairing configurations are still disabled.
I don';t have a good way to test that, sorry. Someone in MTV must.
Labels: -Merge-Approved-59 merge-merged-3071

Comment 14 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
Blocking: 689198
Cc: r...@chromium.org michae...@chromium.org
Status: Assigned (was: Archived)
We are still setting prefs::kOobeMdMode to false for Remora and Shark:
https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/wizard_controller.cc?type=cs&q=prefs::kOobeMdMode&sq=package:chromium&g=0&l=362

We need to test this and remove that before we can eliminate prefs::kOobeMdMode and the associated pre-MD UI (e.g. oobe_screen_network).

+rkc@, +michaelpg@

Components: UI>Shell>StartScreen
CL for testing this:
https://chromium-review.googlesource.com/c/chromium/src/+/1077099

Unfortunately I do not have easy access to a shark/ramora setup.

Steven, I also do not have a way to test this. You should probably consult xiaoyinh@, who might know the details.
Project Member

Comment 19 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbe7877a218e836d3cebc29fd96a7b1e780da5b4

commit fbe7877a218e836d3cebc29fd96a7b1e780da5b4
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Fri Jun 01 16:21:36 2018

Elim OobeMdModeEnabled and newOobeUI

We need to transition to the MD UI on all devices so that we can
deprecate code that is no longer regularly used or tested.

Bug:  647411 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I422d1d1b35b5147cec417d95af7026dc9f47581b
Reviewed-on: https://chromium-review.googlesource.com/1077099
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563667}
[modify] https://crrev.com/fbe7877a218e836d3cebc29fd96a7b1e780da5b4/chrome/browser/chromeos/login/eula_browsertest.cc
[modify] https://crrev.com/fbe7877a218e836d3cebc29fd96a7b1e780da5b4/chrome/browser/chromeos/login/startup_utils.cc
[modify] https://crrev.com/fbe7877a218e836d3cebc29fd96a7b1e780da5b4/chrome/browser/chromeos/login/wizard_controller.cc
[modify] https://crrev.com/fbe7877a218e836d3cebc29fd96a7b1e780da5b4/chrome/browser/chromeos/login/wizard_controller.h
[modify] https://crrev.com/fbe7877a218e836d3cebc29fd96a7b1e780da5b4/chrome/browser/resources/chromeos/login/oobe.js
[modify] https://crrev.com/fbe7877a218e836d3cebc29fd96a7b1e780da5b4/chrome/browser/resources/chromeos/login/oobe_screen_eula.js
[modify] https://crrev.com/fbe7877a218e836d3cebc29fd96a7b1e780da5b4/chrome/browser/resources/chromeos/login/oobe_screen_hid_detection.js
[modify] https://crrev.com/fbe7877a218e836d3cebc29fd96a7b1e780da5b4/chrome/browser/resources/chromeos/login/oobe_screen_network.js
[modify] https://crrev.com/fbe7877a218e836d3cebc29fd96a7b1e780da5b4/chrome/browser/resources/chromeos/login/oobe_screen_reset.js
[modify] https://crrev.com/fbe7877a218e836d3cebc29fd96a7b1e780da5b4/chrome/browser/resources/chromeos/login/oobe_screen_update.js
[modify] https://crrev.com/fbe7877a218e836d3cebc29fd96a7b1e780da5b4/chrome/browser/resources/chromeos/login/screen_arc_terms_of_service.js
[modify] https://crrev.com/fbe7877a218e836d3cebc29fd96a7b1e780da5b4/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
[modify] https://crrev.com/fbe7877a218e836d3cebc29fd96a7b1e780da5b4/chrome/browser/ui/webui/chromeos/login/oobe_ui.h
[modify] https://crrev.com/fbe7877a218e836d3cebc29fd96a7b1e780da5b4/chrome/common/pref_names.cc
[modify] https://crrev.com/fbe7877a218e836d3cebc29fd96a7b1e780da5b4/chrome/common/pref_names.h

Project Member

Comment 20 by bugdroid1@chromium.org, Jun 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93244d98f79d6f2f7056f2715f73f91c93b5387d

commit 93244d98f79d6f2f7056f2715f73f91c93b5387d
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Tue Jun 05 17:49:26 2018

OOBE: Eliminate non MD update and hid screens

Bug:  647411 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4a0519bd64bec46d131ea52cafe00634a8576065
Reviewed-on: https://chromium-review.googlesource.com/1079962
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564566}
[modify] https://crrev.com/93244d98f79d6f2f7056f2715f73f91c93b5387d/chrome/browser/resources/chromeos/login/login_non_lock_shared.html
[modify] https://crrev.com/93244d98f79d6f2f7056f2715f73f91c93b5387d/chrome/browser/resources/chromeos/login/oobe.js
[delete] https://crrev.com/c6537828864fa2214ddaaf5be6f7a62d7db47e8a/chrome/browser/resources/chromeos/login/oobe_screen_hid_detection.css
[modify] https://crrev.com/93244d98f79d6f2f7056f2715f73f91c93b5387d/chrome/browser/resources/chromeos/login/oobe_screen_hid_detection.html
[modify] https://crrev.com/93244d98f79d6f2f7056f2715f73f91c93b5387d/chrome/browser/resources/chromeos/login/oobe_screen_hid_detection.js
[delete] https://crrev.com/c6537828864fa2214ddaaf5be6f7a62d7db47e8a/chrome/browser/resources/chromeos/login/oobe_screen_update.css
[modify] https://crrev.com/93244d98f79d6f2f7056f2715f73f91c93b5387d/chrome/browser/resources/chromeos/login/oobe_screen_update.html
[modify] https://crrev.com/93244d98f79d6f2f7056f2715f73f91c93b5387d/chrome/browser/resources/chromeos/login/oobe_screen_update.js

Project Member

Comment 21 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91ce1dc2fde3a219dbd4ff8d65add6e404c16627

commit 91ce1dc2fde3a219dbd4ff8d65add6e404c16627
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Wed Jun 06 00:28:21 2018

OOBE: Eliminate non MD eula UI

This CL removes kChromeUITermsOemURL (chrome://chrome://terms/oem)
which is unused in the MD UI and non functional.

This CL also disables:
WebviewClientCertsLoginTest.ClientCertRequestedInOtherWebView
(See comment for details).

Bug:  647411 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4bae3abfadd6261fd37a449dcda4a1f37ba4850a
Reviewed-on: https://chromium-review.googlesource.com/1080174
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564734}
[modify] https://crrev.com/91ce1dc2fde3a219dbd4ff8d65add6e404c16627/chrome/app/chromium_strings.grd
[modify] https://crrev.com/91ce1dc2fde3a219dbd4ff8d65add6e404c16627/chrome/app/google_chrome_strings.grd
[modify] https://crrev.com/91ce1dc2fde3a219dbd4ff8d65add6e404c16627/chrome/app/resources/locale_settings.grd
[modify] https://crrev.com/91ce1dc2fde3a219dbd4ff8d65add6e404c16627/chrome/browser/chromeos/login/screens/core_oobe_view.h
[modify] https://crrev.com/91ce1dc2fde3a219dbd4ff8d65add6e404c16627/chrome/browser/chromeos/login/webview_login_browsertest.cc
[modify] https://crrev.com/91ce1dc2fde3a219dbd4ff8d65add6e404c16627/chrome/browser/resources/chromeos/login/lock.js
[modify] https://crrev.com/91ce1dc2fde3a219dbd4ff8d65add6e404c16627/chrome/browser/resources/chromeos/login/login.js
[modify] https://crrev.com/91ce1dc2fde3a219dbd4ff8d65add6e404c16627/chrome/browser/resources/chromeos/login/login_non_lock_shared.html
[modify] https://crrev.com/91ce1dc2fde3a219dbd4ff8d65add6e404c16627/chrome/browser/resources/chromeos/login/md_lock.js
[modify] https://crrev.com/91ce1dc2fde3a219dbd4ff8d65add6e404c16627/chrome/browser/resources/chromeos/login/md_login.js
[modify] https://crrev.com/91ce1dc2fde3a219dbd4ff8d65add6e404c16627/chrome/browser/resources/chromeos/login/oobe.js
[delete] https://crrev.com/3042bcb4d0d8474ca7aaf6ab856b4d464f4468da/chrome/browser/resources/chromeos/login/oobe_screen_eula.css
[modify] https://crrev.com/91ce1dc2fde3a219dbd4ff8d65add6e404c16627/chrome/browser/resources/chromeos/login/oobe_screen_eula.html
[modify] https://crrev.com/91ce1dc2fde3a219dbd4ff8d65add6e404c16627/chrome/browser/resources/chromeos/login/oobe_screen_eula.js
[modify] https://crrev.com/91ce1dc2fde3a219dbd4ff8d65add6e404c16627/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc
[modify] https://crrev.com/91ce1dc2fde3a219dbd4ff8d65add6e404c16627/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.h
[modify] https://crrev.com/91ce1dc2fde3a219dbd4ff8d65add6e404c16627/chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc
[modify] https://crrev.com/91ce1dc2fde3a219dbd4ff8d65add6e404c16627/chrome/browser/ui/webui/chromeos/login/eula_screen_handler.h
[modify] https://crrev.com/91ce1dc2fde3a219dbd4ff8d65add6e404c16627/chrome/common/webui_url_constants.cc
[modify] https://crrev.com/91ce1dc2fde3a219dbd4ff8d65add6e404c16627/chrome/common/webui_url_constants.h

Project Member

Comment 22 by bugdroid1@chromium.org, Jun 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d59785a30e660c5ac65bd8bcfe4bf8874c4534b0

commit d59785a30e660c5ac65bd8bcfe4bf8874c4534b0
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Thu Jun 07 21:02:44 2018

Fix CONSOLE errors in reset_browsertest.cc

This eliminates some console logging that should not be in production,
and fixes a potential bug in the reset screen that generates a
CONSOLE error in ResetTest but does not cause the test to fail.

Bug:  647411 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I54e8d9d6c93a3e6aeed42381f8658d182bd1c965
Reviewed-on: https://chromium-review.googlesource.com/1087210
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565402}
[modify] https://crrev.com/d59785a30e660c5ac65bd8bcfe4bf8874c4534b0/chrome/browser/resources/chromeos/login/oobe_reset_confirmation_overlay.js
[modify] https://crrev.com/d59785a30e660c5ac65bd8bcfe4bf8874c4534b0/chrome/browser/resources/chromeos/login/oobe_screen_reset.js

Project Member

Comment 23 by bugdroid1@chromium.org, Jun 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/467b2b0daf708a166550306e805e37b01a0e8f76

commit 467b2b0daf708a166550306e805e37b01a0e8f76
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Mon Jun 11 19:07:53 2018

OOBE: Eliminate non MD reset screen

Bug:  647411 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic4fc3938481eeeb5f7f86beeacf7fdf5035b45d7
Reviewed-on: https://chromium-review.googlesource.com/1079954
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566093}
[modify] https://crrev.com/467b2b0daf708a166550306e805e37b01a0e8f76/chrome/browser/chromeos/login/reset_browsertest.cc
[modify] https://crrev.com/467b2b0daf708a166550306e805e37b01a0e8f76/chrome/browser/resources/chromeos/login/login_non_lock_shared.html
[modify] https://crrev.com/467b2b0daf708a166550306e805e37b01a0e8f76/chrome/browser/resources/chromeos/login/login_non_lock_shared.js
[modify] https://crrev.com/467b2b0daf708a166550306e805e37b01a0e8f76/chrome/browser/resources/chromeos/login/oobe_screen_reset.css
[modify] https://crrev.com/467b2b0daf708a166550306e805e37b01a0e8f76/chrome/browser/resources/chromeos/login/oobe_screen_reset.html
[modify] https://crrev.com/467b2b0daf708a166550306e805e37b01a0e8f76/chrome/browser/resources/chromeos/login/oobe_screen_reset.js
[delete] https://crrev.com/157c2912e26328795e6ecd673fd1d78ac30c38aa/chrome/browser/resources/chromeos/login/oobe_screen_reset_confirmation_overlay.css
[modify] https://crrev.com/467b2b0daf708a166550306e805e37b01a0e8f76/chrome/browser/resources/chromeos/login/oobe_screen_reset_confirmation_overlay.html
[delete] https://crrev.com/157c2912e26328795e6ecd673fd1d78ac30c38aa/chrome/browser/resources/chromeos/login/oobe_screen_reset_confirmation_overlay.js

Project Member

Comment 24 by bugdroid1@chromium.org, Jun 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31bc272336635c6486b9226b448aaf2f6bc4d7f2

commit 31bc272336635c6486b9226b448aaf2f6bc4d7f2
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Sat Jun 16 00:00:55 2018

OOBE: Eliminate setMDMode and md-mode

Also eliminates references to progress-dots which were removed
with the old UI.

Bug:  647411 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ie7bc4ec3c5b506c637dbffa103e74ac8f133742d
Reviewed-on: https://chromium-review.googlesource.com/1080227
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567833}
[modify] https://crrev.com/31bc272336635c6486b9226b448aaf2f6bc4d7f2/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
[modify] https://crrev.com/31bc272336635c6486b9226b448aaf2f6bc4d7f2/chrome/browser/resources/chromeos/login/md_screen_container.html
[modify] https://crrev.com/31bc272336635c6486b9226b448aaf2f6bc4d7f2/chrome/browser/resources/chromeos/login/oobe.js
[modify] https://crrev.com/31bc272336635c6486b9226b448aaf2f6bc4d7f2/chrome/browser/resources/chromeos/login/oobe_popup_overlay.css
[modify] https://crrev.com/31bc272336635c6486b9226b448aaf2f6bc4d7f2/chrome/browser/resources/chromeos/login/oobe_screen_eula.js
[modify] https://crrev.com/31bc272336635c6486b9226b448aaf2f6bc4d7f2/chrome/browser/resources/chromeos/login/oobe_screen_hid_detection.js
[modify] https://crrev.com/31bc272336635c6486b9226b448aaf2f6bc4d7f2/chrome/browser/resources/chromeos/login/oobe_screen_network.js
[modify] https://crrev.com/31bc272336635c6486b9226b448aaf2f6bc4d7f2/chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.js
[modify] https://crrev.com/31bc272336635c6486b9226b448aaf2f6bc4d7f2/chrome/browser/resources/chromeos/login/oobe_screen_reset.js
[modify] https://crrev.com/31bc272336635c6486b9226b448aaf2f6bc4d7f2/chrome/browser/resources/chromeos/login/oobe_screen_update.js
[modify] https://crrev.com/31bc272336635c6486b9226b448aaf2f6bc4d7f2/chrome/browser/resources/chromeos/login/screen_confirm_password.js
[modify] https://crrev.com/31bc272336635c6486b9226b448aaf2f6bc4d7f2/chrome/browser/resources/chromeos/login/screen_container.html
[modify] https://crrev.com/31bc272336635c6486b9226b448aaf2f6bc4d7f2/chrome/browser/resources/chromeos/login/screen_device_disabled.js
[modify] https://crrev.com/31bc272336635c6486b9226b448aaf2f6bc4d7f2/chrome/browser/resources/chromeos/login/screen_encryption_migration.js
[modify] https://crrev.com/31bc272336635c6486b9226b448aaf2f6bc4d7f2/chrome/browser/resources/chromeos/login/screen_error_message.js
[modify] https://crrev.com/31bc272336635c6486b9226b448aaf2f6bc4d7f2/chrome/browser/resources/chromeos/login/screen_fatal_error.js
[modify] https://crrev.com/31bc272336635c6486b9226b448aaf2f6bc4d7f2/chrome/browser/resources/chromeos/login/screen_gaia_signin.js
[modify] https://crrev.com/31bc272336635c6486b9226b448aaf2f6bc4d7f2/ui/login/display_manager.js
[modify] https://crrev.com/31bc272336635c6486b9226b448aaf2f6bc4d7f2/ui/login/md_screen_container.css
[modify] https://crrev.com/31bc272336635c6486b9226b448aaf2f6bc4d7f2/ui/login/screen_container.css

Status: Fixed (was: Assigned)
I actually think that we've fixed this long time ago.

The last several CLs should probably be attached to the issue 728805.

Sign in to add a comment