New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 647409 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 665179



Sign in to add a comment

Need MediaDelegate implementation for mash

Project Member Reported by sky@chromium.org, Sep 15 2016

Issue description

Most likely hosted by chrome in the short term.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 16 2016

Blockedon: 665179
Blocking: 665179
Blockedon: -665179
Components: Internals>MUS
Owner: e...@chromium.org
Status: Assigned (was: Untriaged)
erg, are you working on this now?

Project Member

Comment 6 by bugdroid1@chromium.org, Dec 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a2d7f260d8725344218710b439396c36b8a0f03

commit 6a2d7f260d8725344218710b439396c36b8a0f03
Author: erg <erg@chromium.org>
Date: Tue Dec 13 03:54:27 2016

mash: Mojoify the MediaDelegate interface.

Instead of a MediaDelegate returned by the ShellDelegate, we now have a
MediaController on the ash side, which receives a MediaClient from the
chrome side at startup.

This also makes minor changes to the interface to send information with
a notification instead of having ash try to read the information back
after notification.

BUG= 647409 

Review-Url: https://codereview.chromium.org/2563643003
Cr-Commit-Position: refs/heads/master@{#438046}

[modify] https://crrev.com/6a2d7f260d8725344218710b439396c36b8a0f03/ash/BUILD.gn
[modify] https://crrev.com/6a2d7f260d8725344218710b439396c36b8a0f03/ash/common/accelerators/accelerator_controller.cc
[add] https://crrev.com/6a2d7f260d8725344218710b439396c36b8a0f03/ash/common/media_controller.cc
[add] https://crrev.com/6a2d7f260d8725344218710b439396c36b8a0f03/ash/common/media_controller.h
[delete] https://crrev.com/6ea15211ce9bda01f3ef0a014d30997b5fe06769/ash/common/media_delegate.h
[modify] https://crrev.com/6a2d7f260d8725344218710b439396c36b8a0f03/ash/common/mojo_interface_factory.cc
[modify] https://crrev.com/6a2d7f260d8725344218710b439396c36b8a0f03/ash/common/shell_delegate.h
[delete] https://crrev.com/6ea15211ce9bda01f3ef0a014d30997b5fe06769/ash/common/system/chromeos/media_security/media_capture_observer.h
[modify] https://crrev.com/6a2d7f260d8725344218710b439396c36b8a0f03/ash/common/system/chromeos/media_security/multi_profile_media_tray_item.cc
[modify] https://crrev.com/6a2d7f260d8725344218710b439396c36b8a0f03/ash/common/system/chromeos/media_security/multi_profile_media_tray_item_unittest.cc
[modify] https://crrev.com/6a2d7f260d8725344218710b439396c36b8a0f03/ash/common/system/tray/system_tray_notifier.cc
[modify] https://crrev.com/6a2d7f260d8725344218710b439396c36b8a0f03/ash/common/system/tray/system_tray_notifier.h
[modify] https://crrev.com/6a2d7f260d8725344218710b439396c36b8a0f03/ash/common/system/user/user_card_view.cc
[modify] https://crrev.com/6a2d7f260d8725344218710b439396c36b8a0f03/ash/common/system/user/user_card_view.h
[modify] https://crrev.com/6a2d7f260d8725344218710b439396c36b8a0f03/ash/common/wm_shell.cc
[modify] https://crrev.com/6a2d7f260d8725344218710b439396c36b8a0f03/ash/common/wm_shell.h
[modify] https://crrev.com/6a2d7f260d8725344218710b439396c36b8a0f03/ash/mus/manifest.json
[modify] https://crrev.com/6a2d7f260d8725344218710b439396c36b8a0f03/ash/mus/shell_delegate_mus.cc
[modify] https://crrev.com/6a2d7f260d8725344218710b439396c36b8a0f03/ash/mus/shell_delegate_mus.h
[modify] https://crrev.com/6a2d7f260d8725344218710b439396c36b8a0f03/ash/public/interfaces/BUILD.gn
[add] https://crrev.com/6a2d7f260d8725344218710b439396c36b8a0f03/ash/public/interfaces/media.mojom
[modify] https://crrev.com/6a2d7f260d8725344218710b439396c36b8a0f03/ash/shell/shell_delegate_impl.cc
[modify] https://crrev.com/6a2d7f260d8725344218710b439396c36b8a0f03/ash/shell/shell_delegate_impl.h
[modify] https://crrev.com/6a2d7f260d8725344218710b439396c36b8a0f03/ash/test/test_shell_delegate.cc
[modify] https://crrev.com/6a2d7f260d8725344218710b439396c36b8a0f03/ash/test/test_shell_delegate.h
[modify] https://crrev.com/6a2d7f260d8725344218710b439396c36b8a0f03/chrome/browser/chrome_content_browser_manifest_overlay.json
[modify] https://crrev.com/6a2d7f260d8725344218710b439396c36b8a0f03/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/6a2d7f260d8725344218710b439396c36b8a0f03/chrome/browser/ui/ash/chrome_new_window_client.cc
[modify] https://crrev.com/6a2d7f260d8725344218710b439396c36b8a0f03/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/6a2d7f260d8725344218710b439396c36b8a0f03/chrome/browser/ui/ash/chrome_shell_delegate.h
[add] https://crrev.com/6a2d7f260d8725344218710b439396c36b8a0f03/chrome/browser/ui/ash/media_client.cc
[add] https://crrev.com/6a2d7f260d8725344218710b439396c36b8a0f03/chrome/browser/ui/ash/media_client.h
[delete] https://crrev.com/6ea15211ce9bda01f3ef0a014d30997b5fe06769/chrome/browser/ui/ash/media_delegate_chromeos.cc
[delete] https://crrev.com/6ea15211ce9bda01f3ef0a014d30997b5fe06769/chrome/browser/ui/ash/media_delegate_chromeos.h
[modify] https://crrev.com/6a2d7f260d8725344218710b439396c36b8a0f03/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc
[modify] https://crrev.com/6a2d7f260d8725344218710b439396c36b8a0f03/chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc
[modify] https://crrev.com/6a2d7f260d8725344218710b439396c36b8a0f03/chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.h

Comment 7 by e...@chromium.org, Dec 13 2016

Status: Fixed (was: Assigned)

Comment 8 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 9 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 10 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 12 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)
Components: -Internals>MUS Internals>Services>WindowService

Sign in to add a comment