New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 647398 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocking:
issue 640312



Sign in to add a comment

Javascript fails when adding "toplevel" to long user story (~30s)

Project Member Reported by charliea@chromium.org, Sep 15 2016

Issue description

The reason for this is that "toplevel" just contains too much data: for this 30s trace, it collects about 300MB. When we go to gunzip the Chrome trace from inside of Javascript, we exceed the max v8 string length, giving this stack trace:

Stack trace: 

"""
INFO:root:Trace (TraceDataPart("cpuSnapshots")) of size 25539 bytes saved.
INFO:root:Trace (TraceDataPart("tabIds")) of size 40 bytes saved.
INFO:root:Trace (TraceDataPart("telemetry")) of size 22057 bytes saved.
INFO:root:Trace (TraceDataPart("traceEvents")) of size 330205233 bytes saved.
[ RUN      ] /tmp/tmp7WE6SW.html
TraceImportError: Invalid string length
"""

Long term, we need a better way to specify what trace events we want to collect for a given benchmark. In the short-term, we need to do something in Python to make this trace smaller. It needs to be in Python because:

- If we make the change in Chrome, then the change won't affect the reference build, and we won't be able to calculate the CPU time metric for the ref build.
- We can't even gunzip the trace in Javascript, meaning that the trace is already too big to deal with by the time it reaches the Javascript code.

As suggested in the instrumentation weekly meeting, I plan to do some very simple stripping of MessageLoop::RunTask metadata in the Telemetry code. This should be effective because MessageLoop::RunTask accounts for some high percentage (60%?) of events collected in "toplevel".
 
Blocking: 640312
Here's the CL where the problem is surfacing: https://codereview.chromium.org/2338433002/

Comment 3 Deleted

Status: WontFix (was: Assigned)
Closing this in favor of a more thorough solution here: https://github.com/catapult-project/catapult/issues/3071

Sign in to add a comment