New issue
Advanced search Search tips

Issue 647392 link

Starred by 1 user
Status: Fixed
Owner:
lukasza@chromium.org
Closed: Sep 2016
Cc:
creis@chromium.org
dcheng@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

unique name of a main frame is not needed anywhere - it can stay null/empty

Project Member Reported by lukasza@chromium.org, Sep 15 2016 
1. Navigation history doesn't look at unique name of a main frame.
2. Layout tests rarely look at unique name of a main frame.

Therefore, we can keep unique name of a main frame set to null/empty and save a little bit of memory + simplify code.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5140a41c48c0932e9a2db3f969ce43393ae0dbef

commit 5140a41c48c0932e9a2db3f969ce43393ae0dbef
Author: lukasza <lukasza@chromium.org>
Date: Thu Sep 15 21:12:30 2016

Main frame's unique name can always be null.

This simplifies the code a little bit + avoids consuming memory for what
is ultimately an unused value.

BUG= 647392 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2329523003
Cr-Commit-Position: refs/heads/master@{#418976}

[modify] https://crrev.com/5140a41c48c0932e9a2db3f969ce43393ae0dbef/content/browser/frame_host/frame_tree_node.cc
[modify] https://crrev.com/5140a41c48c0932e9a2db3f969ce43393ae0dbef/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/5140a41c48c0932e9a2db3f969ce43393ae0dbef/third_party/WebKit/LayoutTests/http/tests/navigation/new-window-sandboxed-iframe-expected.txt
[modify] https://crrev.com/5140a41c48c0932e9a2db3f969ce43393ae0dbef/third_party/WebKit/Source/core/page/FrameTree.cpp

Comment 2 by lukasza@chromium.org, Sep 30 2016

Status: Fixed (was: Started)
►

Sign in to add a comment