New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 647390 link

Starred by 1 user
Status: Fixed
Owner:
ehmaldonado@chromium.org
Closed: Oct 2016
Cc:
█ sakal@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature

Blocked on:
issue webrtc:6437


Sign in to add a comment

Add android_junit_tests test to Linux bots

Project Member Reported by kjellander@chromium.org, Sep 15 2016 
The android_junit_tests test that was added in https://bugs.chromium.org/p/webrtc/issues/detail?id=6365 needs to be added to our Linux desktop bots (notice: not on Android, since it's a Robolectric test).

The test to run is the script that's located in out/{Debug,Release}/bin/run_android_junit_tests 
That takes care of launching it properly.

sakal@ knows all about the test if you need to ask questions.

Comment 1 by ehmaldonado@chromium.org, Sep 16 2016 

sakal@ Why was exactly this reverted? What bots did it break?

Comment 2 by sakal@chromium.org, Sep 16 2016 

It will be relanded soon. It broke chromium.fyi bots followed by webrtc bots because of an error in my reland.

Current reland CL is here: https://codereview.webrtc.org/2348663003/

Comment 3 by kjellander@chromium.org, Sep 18 2016 

The test target is relanded now, and I'm merging a few more tests into the same target in https://codereview.webrtc.org/2347403002/

However, I realize this target only exists if target_os="android", so the test needs to run on the Android bots. I suggest running it at the Android Builder bots, not the Tester ones (since they're slower). Either one would work, but the former are faster and latter will run on unnecessary duplicated configs (since the test won't run on the actual devices connected to them anyway).
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/4bb04985c49aaf8bd38bfffa5ac7f98751f5daf4

commit 4bb04985c49aaf8bd38bfffa5ac7f98751f5daf4
Author: kjellander <kjellander@webrtc.org>
Date: Mon Sep 19 15:53:23 2016

Merge AppRTCDemoJUnitTest into android_junit_tests target

With the small number of tests these targets contain, it
makes more sense to gather them into android_junit_tests
instead, which was created to be a high-level target containing
all the junit tests.

BUG= chromium:647390 
NOTRY=True

Review-Url: https://codereview.webrtc.org/2347403002
Cr-Commit-Position: refs/heads/master@{#14292}

[modify] https://crrev.com/4bb04985c49aaf8bd38bfffa5ac7f98751f5daf4/webrtc/BUILD.gn
[modify] https://crrev.com/4bb04985c49aaf8bd38bfffa5ac7f98751f5daf4/webrtc/examples/BUILD.gn
[modify] https://crrev.com/4bb04985c49aaf8bd38bfffa5ac7f98751f5daf4/webrtc/examples/androidjunit/README
[modify] https://crrev.com/4bb04985c49aaf8bd38bfffa5ac7f98751f5daf4/webrtc/webrtc_examples.gyp
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 28 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/597c27e7cd712b9a07dd091a44f22af5b957c54a

commit 597c27e7cd712b9a07dd091a44f22af5b957c54a
Author: ehmaldonado <ehmaldonado@chromium.org>
Date: Wed Sep 28 07:11:42 2016

WebRTC: Add android_junit_tests.

BUG= 647390 

Review-Url: https://codereview.chromium.org/2354363006

[modify] https://crrev.com/597c27e7cd712b9a07dd091a44f22af5b957c54a/scripts/slave/recipe_modules/webrtc/api.py
[modify] https://crrev.com/597c27e7cd712b9a07dd091a44f22af5b957c54a/scripts/slave/recipe_modules/webrtc/builders.py
[modify] https://crrev.com/597c27e7cd712b9a07dd091a44f22af5b957c54a/scripts/slave/recipe_modules/webrtc/steps.py
[modify] https://crrev.com/597c27e7cd712b9a07dd091a44f22af5b957c54a/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_builder.json
[modify] https://crrev.com/597c27e7cd712b9a07dd091a44f22af5b957c54a/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_builder__dbg_.json
[modify] https://crrev.com/597c27e7cd712b9a07dd091a44f22af5b957c54a/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_builder_forced.json
[modify] https://crrev.com/597c27e7cd712b9a07dd091a44f22af5b957c54a/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64_builder.json
[modify] https://crrev.com/597c27e7cd712b9a07dd091a44f22af5b957c54a/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64_builder__dbg_.json
[modify] https://crrev.com/597c27e7cd712b9a07dd091a44f22af5b957c54a/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_release__swarming_.json
[modify] https://crrev.com/597c27e7cd712b9a07dd091a44f22af5b957c54a/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_swarming.json
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 28 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/22636ece1d2c8507ca8dbebd6b434b0fe9ba6ef1

commit 22636ece1d2c8507ca8dbebd6b434b0fe9ba6ef1
Author: ehmaldonado <ehmaldonado@chromium.org>
Date: Wed Sep 28 07:35:36 2016

Revert of WebRTC: Add android_junit_tests. (patchset #8 id:200001 of https://codereview.chromium.org/2354363006/ )

Reason for revert:
Breaks buildbots
https://build.chromium.org/p/client.webrtc/builders/Android32%20Builder%20%28dbg%29/builds/8704

Original issue's description:
> WebRTC: Add android_junit_tests.
>
> BUG= 647390 
>
> Committed: https://chromium.googlesource.com/chromium/tools/build/+/597c27e7cd712b9a07dd091a44f22af5b957c54a

TBR=kjellander@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 647390 

Review-Url: https://codereview.chromium.org/2373283002

[modify] https://crrev.com/22636ece1d2c8507ca8dbebd6b434b0fe9ba6ef1/scripts/slave/recipe_modules/webrtc/api.py
[modify] https://crrev.com/22636ece1d2c8507ca8dbebd6b434b0fe9ba6ef1/scripts/slave/recipe_modules/webrtc/builders.py
[modify] https://crrev.com/22636ece1d2c8507ca8dbebd6b434b0fe9ba6ef1/scripts/slave/recipe_modules/webrtc/steps.py
[modify] https://crrev.com/22636ece1d2c8507ca8dbebd6b434b0fe9ba6ef1/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_builder.json
[modify] https://crrev.com/22636ece1d2c8507ca8dbebd6b434b0fe9ba6ef1/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_builder__dbg_.json
[modify] https://crrev.com/22636ece1d2c8507ca8dbebd6b434b0fe9ba6ef1/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_builder_forced.json
[modify] https://crrev.com/22636ece1d2c8507ca8dbebd6b434b0fe9ba6ef1/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64_builder.json
[modify] https://crrev.com/22636ece1d2c8507ca8dbebd6b434b0fe9ba6ef1/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64_builder__dbg_.json
[modify] https://crrev.com/22636ece1d2c8507ca8dbebd6b434b0fe9ba6ef1/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_release__swarming_.json
[modify] https://crrev.com/22636ece1d2c8507ca8dbebd6b434b0fe9ba6ef1/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_swarming.json
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 28 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/28508e6acd5c6c52569aed5c3fda06f20dfafbe4

commit 28508e6acd5c6c52569aed5c3fda06f20dfafbe4
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Sep 28 07:14:11 2016
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 28 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/c739f3ebf29a54df9af63e37ba6ac2b82d074c5c

commit c739f3ebf29a54df9af63e37ba6ac2b82d074c5c
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Sep 28 07:44:50 2016
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 28 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/2a05b25ad962ff3126beadeaa150b9e571cca676

commit 2a05b25ad962ff3126beadeaa150b9e571cca676
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Sep 28 09:34:08 2016
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 28 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/721ba2cac4a5b76803d9488a831a2bd44867ed81

commit 721ba2cac4a5b76803d9488a831a2bd44867ed81
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Sep 28 07:40:06 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/597c27e7cd712b9a07dd091a44f22af5b957c54a WebRTC: Add android_junit_tests. (ehmaldonado@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= 647390 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2373293002
Cr-Commit-Position: refs/heads/master@{#421468}

[modify] https://crrev.com/721ba2cac4a5b76803d9488a831a2bd44867ed81/infra/config/recipes.cfg
Project Member

Comment 11 by bugdroid1@chromium.org, Sep 28 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0bea2b77bf301cd3728fbc56930491d719ef0c8

commit b0bea2b77bf301cd3728fbc56930491d719ef0c8
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Sep 28 08:01:24 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/22636ece1d2c8507ca8dbebd6b434b0fe9ba6ef1 Revert of WebRTC: Add android_junit_tests. (patchset #8 id:200001 of https://codereview.chromium.org/2354363006/ ) (ehmaldonado@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= 647390 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2375883002
Cr-Commit-Position: refs/heads/master@{#421472}

[modify] https://crrev.com/b0bea2b77bf301cd3728fbc56930491d719ef0c8/infra/config/recipes.cfg
Project Member

Comment 12 by bugdroid1@chromium.org, Sep 28 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1b92cec0c441d82ee885b0870fc8a38f3af0644

commit c1b92cec0c441d82ee885b0870fc8a38f3af0644
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Sep 28 09:40:11 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/567475a8f817b58253b6e305bf5eb5c980f04bc6 WebRTC: Add android_junit_tests to FYI bots. (ehmaldonado@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= 647390 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2377993002
Cr-Commit-Position: refs/heads/master@{#421486}

[modify] https://crrev.com/c1b92cec0c441d82ee885b0870fc8a38f3af0644/infra/config/recipes.cfg

Comment 13 by ehmaldonado@webrtc.org, Sep 28 2016

Blockedon: webrtc:6437
Project Member

Comment 14 by bugdroid1@chromium.org, Sep 28 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/f100cada231af0b1a0c70845f8d8c06fd9726086

commit f100cada231af0b1a0c70845f8d8c06fd9726086
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Sep 28 18:35:17 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/ba86a553518c0321687aff9497624d84f6a17be0 WebRTC: Update tests after renaming AppRTCDemo -> AppRTCMobile. (kjellander@chromium.org)
  https://crrev.com/597c27e7cd712b9a07dd091a44f22af5b957c54a WebRTC: Add android_junit_tests. (ehmaldonado@chromium.org)
  https://crrev.com/22636ece1d2c8507ca8dbebd6b434b0fe9ba6ef1 Revert of WebRTC: Add android_junit_tests. (patchset #8 id:200001 of https://codereview.chromium.org/2354363006/ ) (ehmaldonado@chromium.org)
  https://crrev.com/567475a8f817b58253b6e305bf5eb5c980f04bc6 WebRTC: Add android_junit_tests to FYI bots. (ehmaldonado@chromium.org)
  https://crrev.com/3ca6e8a40b853337432916ce446b00e72b145381 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/3574740929abd37c45db1d2f8a2c3799bdfe77c5 Add CC_LIST and --cc to Gerrit issues via API to be similar to CCs in Rietveld (rmistry@google.com)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= 647390 , chromium:649660 , webrtc:6359 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2377953004

[modify] https://crrev.com/f100cada231af0b1a0c70845f8d8c06fd9726086/infra/config/recipes.cfg

Comment 15 by ehmaldonado@chromium.org, Oct 24 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment