New issue
Advanced search Search tips

Issue 647379 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

arc: Arc app window is shown in case started when secondary profile is active.

Project Member Reported by khmel@chromium.org, Sep 15 2016

Issue description

Inner bug: b/31500778
 

Comment 1 by khmel@chromium.org, Sep 15 2016

Owner: khmel@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4d9c53e0ca156489f3a9b970925594786bab1c0

commit a4d9c53e0ca156489f3a9b970925594786bab1c0
Author: khmel <khmel@chromium.org>
Date: Mon Sep 19 17:49:04 2016

arc: Prevent showing Arc app window for secondary user profile.

Arc has a limitation to be visible for primary profile only. However,
there are situations when Arc task can be started while the secondary
profile is shown. Before this led to case when Arc window was shown,
which is unexpected. This CL fixes this issue and prevents showing Arc
window for non-primary profiles.

Test=Manually on the device. Start Arc app in deferred mode and switch
     to the secondary profile fast. Arc app is started but window is not
     shown. Switch back to primary profile and window is automatically
     restored there.
BUG=b/31500778
BUG= 647379 

Review-Url: https://codereview.chromium.org/2345043002
Cr-Commit-Position: refs/heads/master@{#419497}

[modify] https://crrev.com/a4d9c53e0ca156489f3a9b970925594786bab1c0/chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.cc
[modify] https://crrev.com/a4d9c53e0ca156489f3a9b970925594786bab1c0/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 21 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38d6e1d0045bbaed50e7730b0c1c25842e41c395

commit 38d6e1d0045bbaed50e7730b0c1c25842e41c395
Author: khmel <khmel@chromium.org>
Date: Wed Sep 21 20:33:20 2016

[Merge-M54] arc: Prevent showing Arc app window for secondary user profile.

Arc has a limitation to be visible for primary profile only. However,
there are situations when Arc task can be started while the secondary
profile is shown. Before this led to case when Arc window was shown,
which is unexpected. This CL fixes this issue and prevents showing Arc
window for non-primary profiles.

Test=Manually on the device. Start Arc app in deferred mode and switch
     to the secondary profile fast. Arc app is started but window is not
     shown. Switch back to primary profile and window is automatically
     restored there.
BUG=b/31500778
BUG= 647379 
BUG= 644751 

TBR=reviewer@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2345043002
Cr-Commit-Position: refs/heads/master@{#419497}
(cherry picked from commit a4d9c53e0ca156489f3a9b970925594786bab1c0)

Review-Url: https://codereview.chromium.org/2361573002
Cr-Commit-Position: refs/branch-heads/2840@{#474}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/38d6e1d0045bbaed50e7730b0c1c25842e41c395/chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.cc
[modify] https://crrev.com/38d6e1d0045bbaed50e7730b0c1c25842e41c395/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc

Comment 4 by khmel@chromium.org, Sep 21 2016

It was merged as part of 644751

Comment 5 by khmel@chromium.org, Sep 21 2016

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38d6e1d0045bbaed50e7730b0c1c25842e41c395

commit 38d6e1d0045bbaed50e7730b0c1c25842e41c395
Author: khmel <khmel@chromium.org>
Date: Wed Sep 21 20:33:20 2016

[Merge-M54] arc: Prevent showing Arc app window for secondary user profile.

Arc has a limitation to be visible for primary profile only. However,
there are situations when Arc task can be started while the secondary
profile is shown. Before this led to case when Arc window was shown,
which is unexpected. This CL fixes this issue and prevents showing Arc
window for non-primary profiles.

Test=Manually on the device. Start Arc app in deferred mode and switch
     to the secondary profile fast. Arc app is started but window is not
     shown. Switch back to primary profile and window is automatically
     restored there.
BUG=b/31500778
BUG= 647379 
BUG= 644751 

TBR=reviewer@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2345043002
Cr-Commit-Position: refs/heads/master@{#419497}
(cherry picked from commit a4d9c53e0ca156489f3a9b970925594786bab1c0)

Review-Url: https://codereview.chromium.org/2361573002
Cr-Commit-Position: refs/branch-heads/2840@{#474}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/38d6e1d0045bbaed50e7730b0c1c25842e41c395/chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.cc
[modify] https://crrev.com/38d6e1d0045bbaed50e7730b0c1c25842e41c395/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc

Sign in to add a comment