New issue
Advanced search Search tips

Issue 647376 link

Starred by 2 users

Issue metadata

Status: Archived
Owner: ----
Closed: Nov 22
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Fix views::Label to not call the virtual GetWidget() during construction

Project Member Reported by bruthig@chromium.org, Sep 15 2016

Issue description

I noticed that while constructing a views::Label it is calling the virtual GetWidget() function during construction.  I am not aware of any negative consequences of this but AFAIK this pattern is not desired.

I believe the saving grace here is that View::GetNativeTheme() falls back to returning other NativeTheme instances when GetWidget() returns null.

The call path is:

View::GetWidget()
View::GetNativeTheme()
Label::Init(const base::string16&, const gfx::FontList&)
Label::Label(const base::string16&, const gfx::FontList&)

 
Archiving old bugs that haven't been actively assigned in over a year.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!

Labels: Hotlist-DesktopUIChecked
Status: Archived (was: Untriaged)

Sign in to add a comment