Issue metadata
Sign in to add a comment
|
Fix and reenable media.android.tough_video_cases on Android Nexus5 Perf (2) |
||||||||||||||||||||||
Issue descriptionmedia.android.tough_video_cases failing on chromium.perf/Android Nexus5 Perf (2) Type: build-failure Builders failed on: - Android Nexus5 Perf (2): https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5%20Perf%20%282%29 417296 - 418858 Traceback (most recent call last): RunBenchmark at /b/rr/tmpJk4vSA/w/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py:327 benchmark.ShouldTearDownStateAfterEachStorySetRun()) Run at /b/rr/tmpJk4vSA/w/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py:227 _RunStoryAndProcessErrorIfNeeded(story, results, state, test) _RunStoryAndProcessErrorIfNeeded at /b/rr/tmpJk4vSA/w/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py:86 state.RunStory(results) traced_function at /b/rr/tmpJk4vSA/w/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py:52 return func(*args, **kwargs) RunStory at /b/rr/tmpJk4vSA/w/src/third_party/catapult/telemetry/telemetry/page/shared_page_state.py:303 self._current_page, self._current_tab, results) traced_function at /b/rr/tmpJk4vSA/w/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py:52 return func(*args, **kwargs) ValidateAndMeasurePage at /b/rr/tmpJk4vSA/w/src/tools/perf/measurements/media.py:64 self._cpu_metric.AddResults(tab, results, trace_name=trace_name) AddResults at /b/rr/tmpJk4vSA/w/src/tools/perf/metrics/cpu.py:46 cpu_stats = _SubtractCpuStats(self._stop_cpu, self._start_cpu) _SubtractCpuStats at /b/rr/tmpJk4vSA/w/src/tools/perf/metrics/cpu.py:95 'Expected total_time > 0, was: %d' % total_time) AssertionError: Expected total_time > 0, was: 4252017650 cc'ing starodub@ who last edited the line where the assertion is made.
,
Sep 19 2016
,
Oct 3 2016
Ping. This seems to be flaky instead of failure.
,
Oct 3 2016
i'll try to repro locally.
,
Oct 3 2016
FYI, this is also failing on Android Nexus5X Perf (2) https://uberchromegw.corp.google.com/i/chromium.perf/builders/Android%20Nexus5X%20Perf%20%282%29?numbuilds=200
,
Oct 7 2016
Any update?
,
Oct 7 2016
unfortunately, no. i've had two RBS bugs assigned. this hasn't gotten to the top of the list yet.
,
Oct 7 2016
This test failure seems to be more persistent on Nexus 5X. Disable CL is up https://codereview.chromium.org/2402083002/
,
Oct 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2e25012591cd2017522b66fc871466aa3e59ff5e commit 2e25012591cd2017522b66fc871466aa3e59ff5e Author: zhenw <zhenw@chromium.org> Date: Sat Oct 08 04:28:35 2016 Disable media.android.tough_video_cases on Android Nexus5X Perf TBR=nednguyen@google.com BUG= chromium:647372 Review-Url: https://codereview.chromium.org/2402083002 Cr-Commit-Position: refs/heads/master@{#424063} [modify] https://crrev.com/2e25012591cd2017522b66fc871466aa3e59ff5e/tools/perf/benchmarks/media.py
,
Oct 8 2016
,
Oct 18 2016
+ Thomas
,
Nov 21 2016
,
Nov 21 2016
Issue 658871 has been merged into this issue.
,
Dec 5 2016
,
Dec 6 2016
Issue 671628 has been merged into this issue.
,
Dec 6 2016
,
Dec 7 2016
We think the original issue is fixed but this is still crashing most of the time so needs more investigation before re-enabling.
,
Jan 17 2017
liberato@ pointed out to me that this may fix the remaining issue: https://codereview.chromium.org/2490783002
,
Feb 10 2017
liberato tested that the fix https://codereview.chromium.org/2490783002 did solve the problem. I intend to re-enable it in https://codereview.chromium.org/2684033009/ .
,
Feb 10 2017
,
Feb 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b4f0e124c5a8884a16459c67d956d011be8acc5a commit b4f0e124c5a8884a16459c67d956d011be8acc5a Author: crouleau <crouleau@chromium.org> Date: Fri Feb 10 02:56:12 2017 Re-enable media.android.tough_video_cases. This was disabled in cr/2402083002 and cr/2549373003. The problem was that we became idle during seek, so we would suspend if the seek took too long. sandersd@ fixed this in cr/2490783002. liberato@ tested this both right before and right after sandersd@'s change. Before the change it would usually fail but sometimes succeed. After the change it would always succeed. BUG= 647372 Review-Url: https://codereview.chromium.org/2684033009 Cr-Commit-Position: refs/heads/master@{#449538} [modify] https://crrev.com/b4f0e124c5a8884a16459c67d956d011be8acc5a/tools/perf/benchmarks/media.py
,
Feb 20 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by robert...@chromium.org
, Sep 16 2016