New issue
Advanced search Search tips

Issue 647357 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Should annotated_steps in recipes mark final step as failed when process returns non-zero?

Project Member Reported by sbc@chromium.org, Sep 15 2016

Issue description

We run into this issue in several different waterfalls now:

https://wasm-stat.us/console
https://build.chromium.org/p/client.nacl/waterfall
https://build.chromium.org/p/client.nacl.sdk/waterfall

The problem is that if there is, for example, a python exception
in the annotated_steps in the current stop should really be
marked as red.  Right no all the the steps remain green even
though the top level annotated_steps is red.

We can fix this by doing something like this I think, but it seems
like the kind of thing that the annotated_steps task could handle
automatically:

```
  try:
    return run()
  except:
    traceback.print_exc()
    if buildbot.current_step:
      buildbot.Fail()
    return 1
```

 
Components: -Infra Infra>Platform>Recipes

Comment 2 by sbc@chromium.org, Sep 15 2016

For webassembly I ended up rolling it myself:
https://github.com/WebAssembly/waterfall/commit/6c1f7c38678f48caf67dc795e4fd17f720f035ca.

Will see how it works out..
Status: WontFix (was: Untriaged)
Closing as wontfix, this is what happens when you use subannotations; you assume full responsibility for interfacing with buildbot.

Sign in to add a comment