Should annotated_steps in recipes mark final step as failed when process returns non-zero? |
||
Issue descriptionWe run into this issue in several different waterfalls now: https://wasm-stat.us/console https://build.chromium.org/p/client.nacl/waterfall https://build.chromium.org/p/client.nacl.sdk/waterfall The problem is that if there is, for example, a python exception in the annotated_steps in the current stop should really be marked as red. Right no all the the steps remain green even though the top level annotated_steps is red. We can fix this by doing something like this I think, but it seems like the kind of thing that the annotated_steps task could handle automatically: ``` try: return run() except: traceback.print_exc() if buildbot.current_step: buildbot.Fail() return 1 ```
,
Sep 15 2016
For webassembly I ended up rolling it myself: https://github.com/WebAssembly/waterfall/commit/6c1f7c38678f48caf67dc795e4fd17f720f035ca. Will see how it works out..
,
May 15 2017
Closing as wontfix, this is what happens when you use subannotations; you assume full responsibility for interfacing with buildbot. |
||
►
Sign in to add a comment |
||
Comment 1 by seanmccullough@google.com
, Sep 15 2016