New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 647353 link

Starred by 1 user

Issue metadata

Status: Duplicate
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 636212



Sign in to add a comment

scripts/slave/recipe_modules/archive/api.py should filter out .obj files in gn builds

Project Member Reported by thakis@chromium.org, Sep 15 2016

Issue description

gn puts .obj / .o files in various subdirectories, one per toolchain. scripts/slave/recipe_modules/archive/api.py currently only filters out .obj files in the root of the build dir. It needs to filter them out in subdirs too.

(I guess there's some subtlety with making sure the zip commandline doesn't run into system limits.)

machenbach, looks like you wrote this recipe, can you take a look?
 
Components: Infra
Owner: ----
I converted the legacy archive script into the recipe, not changing any logic. Passing this to chromium infra.

Comment 2 by thakis@chromium.org, Sep 19 2016

Cc: benhenry@chromium.org
Ben, do you know who could look at this? It's causing gigabytes of unneeded traffic on some bots.

Comment 3 by aarya@google.com, Sep 19 2016

Cc: mmoroz@chromium.org
Labels: -Pri-3 Pri-1
Raising priority. Ben, can you please take a look soon, see also https://bugs.chromium.org/p/chromium/issues/detail?id=636212#c36
Components: -Infra Infra>Platform>Recipes
Owner: iannucci@chromium.org
Status: Assigned (was: Untriaged)
Robbie...tag, you're it.
Ping - please provide an update to your high priority bug. This bug is stale. Is it really P-1?

Comment 6 by mmoroz@chromium.org, Mar 18 2017

Mergedinto: 654550
Status: Duplicate (was: Assigned)
I think this has been resolved as issue 654550.
https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/archive/resources/filter_build_files.py deletes object files and reduces number of files in build archive by 80-90% (see stats in https://bugs.chromium.org/p/chromium/issues/detail?id=654550#c33).

Please feel free to re-open if there is something else to be done.

Sign in to add a comment